You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/30 04:49:12 UTC

[GitHub] [flink-ml] lindong28 opened a new pull request, #186: [hotfix] Add Python quickstart link in README

lindong28 opened a new pull request, #186:
URL: https://github.com/apache/flink-ml/pull/186

   ## What is the purpose of the change
   
   Add Python quickstart link in README
   
   ## Brief change log
   
   Added Python quickstart link in README
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicatble
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-ml] lindong28 commented on pull request #186: [hotfix] Add Python quickstart link in README

Posted by GitBox <gi...@apache.org>.
lindong28 commented on PR #186:
URL: https://github.com/apache/flink-ml/pull/186#issuecomment-1331639878

   @zhipeng93 Can you review this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-ml] zhipeng93 commented on pull request #186: [hotfix] Add Python quickstart link in README

Posted by GitBox <gi...@apache.org>.
zhipeng93 commented on PR #186:
URL: https://github.com/apache/flink-ml/pull/186#issuecomment-1331976083

   Thanks for the PR. LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #186: [hotfix] Add Python quickstart link in README

Posted by GitBox <gi...@apache.org>.
zhipeng93 commented on code in PR #186:
URL: https://github.com/apache/flink-ml/pull/186#discussion_r1035817144


##########
README.md:
##########
@@ -8,9 +8,11 @@ Flink](https://flink.apache.org/).
 
 ## <a name="start"></a>Getting Started
 
-You can follow this [quick
+You can follow the [Python quick
+start](https://nightlies.apache.org/flink/flink-ml-docs-master/docs/try-flink-ml/python/quick-start/)
+and the [Java quick
 start](https://nightlies.apache.org/flink/flink-ml-docs-master/docs/try-flink-ml/java/quick-start/)
-guideline to get hands-on experience with Flink ML.
+to get hands-on experience with Flink ML Python and Java APIs respectively.

Review Comment:
   This link seems does not contain Java APIs. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-ml] zhipeng93 merged pull request #186: [hotfix] Add Python quickstart link in README

Posted by GitBox <gi...@apache.org>.
zhipeng93 merged PR #186:
URL: https://github.com/apache/flink-ml/pull/186


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org