[GitHub] [iceberg] massdosage commented on a change in pull request #1394: Hive: Add logging for Hive related classes

[GitBox <gi...@apache.org>]

massdosage commented on a change in pull request #1394:
URL: https://github.com/apache/iceberg/pull/1394#discussion_r478400542



##########
File path: hive/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
##########
@@ -177,6 +182,8 @@ public void renameTable(TableIdentifier from, TableIdentifier originalTo) {
         return null;
       });
 
+      LOG.info("Renamed table form: [{}], to: [{}]", from, to);

Review comment:
       ```suggestion
         LOG.info("Renamed table from: [{}], to: [{}]", from, to);
   ```

##########
File path: hive/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
##########
@@ -465,9 +495,14 @@ protected void finalize() throws Throwable {
     super.finalize();
     if (!closed) {
       close(); // releasing resources is more important than printing the warning
-      String trace = Joiner.on("\n\t").join(
+      String trace = Joiner.on("\\n\t").join(

Review comment:
       Is the additional `\` here intentional? If so, what behaviour changes?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org