You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/21 00:17:45 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
dongjoon-hyun opened a new pull request #31909:
URL: https://github.com/apache/spark/pull/31909
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31909:
URL: https://github.com/apache/spark/pull/31909#issuecomment-803515659
@bozhang2820 the test failure seems related to your PR https://github.com/apache/spark/commit/86ea5203201a1b7611f0beaa9c7759d480fb21af. Yeah I can also confirm that the test failure is not related to this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31909:
URL: https://github.com/apache/spark/pull/31909#issuecomment-803493780
**[Test build #136290 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136290/testReport)** for PR 31909 at commit [`e34c5ae`](https://github.com/apache/spark/commit/e34c5aeac04ffc0d4f372472b863ee7401644187).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31909:
URL: https://github.com/apache/spark/pull/31909#issuecomment-803497999
There were some PRs reverted (e.g., https://github.com/apache/spark/pull/13181 and SPARK-15393) that make me wary .. but I think the change here is fine ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31909:
URL: https://github.com/apache/spark/pull/31909#issuecomment-803536664
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136299/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31909:
URL: https://github.com/apache/spark/pull/31909#issuecomment-803512564
The failure is irrelevant.
```
[info] - SPARK-34757: should ignore cache for SNAPSHOT dependencies *** FAILED *** (1 second, 254 milliseconds)
[info] 0 equaled 0 (SparkSubmitUtilsSuite.scala:321)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31909:
URL: https://github.com/apache/spark/pull/31909#issuecomment-803502131
Also, cc @mridulm since this is a behavior change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31909:
URL: https://github.com/apache/spark/pull/31909#issuecomment-803536664
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136299/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31909:
URL: https://github.com/apache/spark/pull/31909#issuecomment-803522439
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40881/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31909:
URL: https://github.com/apache/spark/pull/31909#issuecomment-803503757
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136290/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31909:
URL: https://github.com/apache/spark/pull/31909#issuecomment-803531860
**[Test build #136299 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136299/testReport)** for PR 31909 at commit [`e34c5ae`](https://github.com/apache/spark/commit/e34c5aeac04ffc0d4f372472b863ee7401644187).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #31909:
URL: https://github.com/apache/spark/pull/31909#issuecomment-803663826
Merged to master for Apache Spark 3.2.0.
Thank you all!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31909:
URL: https://github.com/apache/spark/pull/31909#issuecomment-803498246
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40872/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31909:
URL: https://github.com/apache/spark/pull/31909#issuecomment-807442686
Thank you, @mridulm and @cloud-fan .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31909:
URL: https://github.com/apache/spark/pull/31909#issuecomment-803503757
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136290/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #31909:
URL: https://github.com/apache/spark/pull/31909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm edited a comment on pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
Posted by GitBox <gi...@apache.org>.
mridulm edited a comment on pull request #31909:
URL: https://github.com/apache/spark/pull/31909#issuecomment-807221683
late LGTM, thanks for working on this @dongjoon-hyun !
This will impact custom map side join, etc ... but given it can be re-enabled by flag, it is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31909:
URL: https://github.com/apache/spark/pull/31909#issuecomment-803499019
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40872/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31909:
URL: https://github.com/apache/spark/pull/31909#issuecomment-803519024
Thank you so much, @attilapiros !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31909:
URL: https://github.com/apache/spark/pull/31909#issuecomment-803494412
Thank you, @viirya !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31909:
URL: https://github.com/apache/spark/pull/31909#issuecomment-803501833
Thank you, @HyukjinKwon . Ya, I remember those commits. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31909:
URL: https://github.com/apache/spark/pull/31909#issuecomment-803502542
**[Test build #136290 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136290/testReport)** for PR 31909 at commit [`e34c5ae`](https://github.com/apache/spark/commit/e34c5aeac04ffc0d4f372472b863ee7401644187).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31909:
URL: https://github.com/apache/spark/pull/31909#issuecomment-803523183
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40881/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31909:
URL: https://github.com/apache/spark/pull/31909#issuecomment-803497525
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40872/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31909:
URL: https://github.com/apache/spark/pull/31909#issuecomment-803493780
**[Test build #136290 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136290/testReport)** for PR 31909 at commit [`e34c5ae`](https://github.com/apache/spark/commit/e34c5aeac04ffc0d4f372472b863ee7401644187).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31909:
URL: https://github.com/apache/spark/pull/31909#issuecomment-803518829
**[Test build #136299 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136299/testReport)** for PR 31909 at commit [`e34c5ae`](https://github.com/apache/spark/commit/e34c5aeac04ffc0d4f372472b863ee7401644187).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31909:
URL: https://github.com/apache/spark/pull/31909#issuecomment-803497412
Thanks for cc'ing me @dongjoon-hyun.
Also cc @jiangxb1987 and @cloud-fan from https://github.com/apache/spark/pull/19504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31909:
URL: https://github.com/apache/spark/pull/31909#issuecomment-803492567
Could you review this PR, @HyukjinKwon , @viirya , @attilapiros ? Personally, I tested this in my repo first.
- https://github.com/dongjoon-hyun/spark/pull/54
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
Posted by GitBox <gi...@apache.org>.
mridulm commented on pull request #31909:
URL: https://github.com/apache/spark/pull/31909#issuecomment-807221683
late LGTM, thanks for working on this @dongjoon-hyun !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31909:
URL: https://github.com/apache/spark/pull/31909#issuecomment-803663826
Merged to master for Apache Spark 3.1.0.
Thank you all!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31909:
URL: https://github.com/apache/spark/pull/31909#issuecomment-803809778
late LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31909:
URL: https://github.com/apache/spark/pull/31909#issuecomment-803521816
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40881/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31909:
URL: https://github.com/apache/spark/pull/31909#issuecomment-803523183
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40881/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31909:
URL: https://github.com/apache/spark/pull/31909#issuecomment-803499019
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40872/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31909:
URL: https://github.com/apache/spark/pull/31909#issuecomment-803518829
**[Test build #136299 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136299/testReport)** for PR 31909 at commit [`e34c5ae`](https://github.com/apache/spark/commit/e34c5aeac04ffc0d4f372472b863ee7401644187).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31909: [SPARK-34809][CORE] Enable spark.hadoopRDD.ignoreEmptySplits by default
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31909:
URL: https://github.com/apache/spark/pull/31909#issuecomment-803515683
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org