You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by sandhyasun <gi...@git.apache.org> on 2017/04/02 04:51:37 UTC
[GitHub] incubator-trafodion pull request #1041: Rework the fix for [TRAFODION-2516] ...
GitHub user sandhyasun opened a pull request:
https://github.com/apache/incubator-trafodion/pull/1041
Rework the fix for [TRAFODION-2516] to returntype for param as LOB in\u2026
\u2026stead of coercing the type by default to char type since it confuses JDBC and Catalog APIs. The expected input param still is expected as a varchar format. Also added testcases both for the regression as well as the clitestdriver program. Added support for update with param as well. Fixed a problem with GC limit where GC was happening too often when the "update lob" interface was called becuase the limit was not taken as MB and was taken as bytes instead.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sandhyasun/incubator-trafodion 2.2_work
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/1041.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1041
----
commit ac9b22737ee98d782d5ecb9986d36ba8c4fa28e5
Author: Sandhya Sundaresan <sa...@apache.org>
Date: 2017-04-02T04:46:59Z
Rework the fix for [TRAFODION-2516] to returntype for param as LOB instead of coercing the type by default to char type since it confuses JDBC and Catalog APIs. The expected input param still is expected as a varchar format. Also added testcases both for the regression as well as the clitestdriver program.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #1041: Rework the fix for [TRAFODION-2516] ...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1041#discussion_r111035970
--- Diff: core/sql/bin/clitest.cpp ---
@@ -316,7 +317,9 @@ case 7:
return retcode;
}
cout << "LOB handle for "<< columnname << ": " << lobHandle << endl;
- retcode = updateAppendBufferToLobHandle(cliGlob,lobHandle);
+ char *source= new char[300];
--- End diff --
This is a test program so I suppose we don't care about the memory leak here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #1041: Rework the fix for [TRAFODION-2516] ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/1041
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #1041: Rework the fix for [TRAFODION-2516] ...
Posted by sandhyasun <gi...@git.apache.org>.
Github user sandhyasun commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1041#discussion_r111848014
--- Diff: core/sql/bin/clitest.cpp ---
@@ -316,7 +317,9 @@ case 7:
return retcode;
}
cout << "LOB handle for "<< columnname << ": " << lobHandle << endl;
- retcode = updateAppendBufferToLobHandle(cliGlob,lobHandle);
+ char *source= new char[300];
--- End diff --
I can fix this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---