You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/09 12:47:48 UTC

[GitHub] [pulsar] asafm commented on a diff in pull request #14348: Expose BookKeeper client thread pool metrics

asafm commented on code in PR #14348:
URL: https://github.com/apache/pulsar/pull/14348#discussion_r893459633


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/metrics/PrometheusMetricsProvider.java:
##########
@@ -107,20 +74,30 @@ public void stop() {
 
     @Override
     public StatsLogger getStatsLogger(String scope) {
-        return this.cachingStatsProvider.getStatsLogger(scope);
+        Map<String, String> labels = new HashMap<>();

Review Comment:
   @hangc0276 Previously there was a caching layer called `cachingStatsProvider` which saved in a map every `StatsLogger` created via `getStatsLogger`. If it was created previously it would return it. 
   Now it is removed
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org