You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Taher Alkhateeb <sl...@gmail.com> on 2015/05/03 10:52:14 UTC
Java 8 and functional programming in trunk
Hi everyone,
I would like to work on a few JIRAs and at the same refactor some existing
code to utilize Lambdas and Streams utilizing Java 8 features.
Is it acceptable to develop with JDK 8 features into trunk?
Taher Alkhateeb
Re: Java 8 and functional programming in trunk
Posted by Ron Wheeler <rw...@artifact-software.com>.
+1
Java 8 works well, is supported and opens a lot of doors for new ways to
write clearer code.
Ron
On 07/05/2015 4:58 AM, Michael Brohl wrote:
> +1
>
> I think it would be strange to do a 1st release of 14.12 without
> moving from (then non-supported) Java 1.7 to 1.8.
>
> Michael
> ecomify GmbH
> www.ecomify.de
>
> Am 07.05.15 um 09:58 schrieb Jacopo Cappellato:
>> On May 7, 2015, at 9:52 AM, Pierre Smits <pi...@gmail.com> wrote:
>>
>>> I don't think that it is a question of using or not using J8. It is
>>> more
>>> about when to move it into trunk, as from that moment on there will be
>>> backward compatibility issues.
>> I think we could do it also in the 14.12 release branch because no
>> releases have been issued from it. And in this way it will be easier
>> to backport future fixes from trunk to 14.12 (an important factor
>> because 14.12 will be maintained for years, unless we change our
>> release strategy).
>>
>> Jacopo
>>
>
>
--
Ron Wheeler
President
Artifact Software Inc
email: rwheeler@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102
Re: Java 8 and functional programming in trunk
Posted by Michael Brohl <mi...@ecomify.de>.
+1
I think it would be strange to do a 1st release of 14.12 without moving
from (then non-supported) Java 1.7 to 1.8.
Michael
ecomify GmbH
www.ecomify.de
Am 07.05.15 um 09:58 schrieb Jacopo Cappellato:
> On May 7, 2015, at 9:52 AM, Pierre Smits <pi...@gmail.com> wrote:
>
>> I don't think that it is a question of using or not using J8. It is more
>> about when to move it into trunk, as from that moment on there will be
>> backward compatibility issues.
> I think we could do it also in the 14.12 release branch because no releases have been issued from it. And in this way it will be easier to backport future fixes from trunk to 14.12 (an important factor because 14.12 will be maintained for years, unless we change our release strategy).
>
> Jacopo
>
Re: Java 8 and functional programming in trunk
Posted by Jacques Le Roux <ja...@les7arts.com>.
I tend to agree
Jacques
Le 07/05/2015 09:58, Jacopo Cappellato a écrit :
> On May 7, 2015, at 9:52 AM, Pierre Smits <pi...@gmail.com> wrote:
>
>> I don't think that it is a question of using or not using J8. It is more
>> about when to move it into trunk, as from that moment on there will be
>> backward compatibility issues.
> I think we could do it also in the 14.12 release branch because no releases have been issued from it. And in this way it will be easier to backport future fixes from trunk to 14.12 (an important factor because 14.12 will be maintained for years, unless we change our release strategy).
>
> Jacopo
>
>
>
Re: Java 8 and functional programming in trunk
Posted by Jacques Le Roux <ja...@les7arts.com>.
Not a separate instance, just a change in the Python BuildBot script; nothing complicated
Jacques
Le 07/05/2015 10:12, Pierre Smits a écrit :
> Wouldn't we need a separate CI instance on J8 to ensure that tests don't
> fail?
>
> Best regards,
>
> Pierre Smits
>
> *ORRTIZ.COM <http://www.orrtiz.com>*
> Services & Solutions for Cloud-
> Based Manufacturing, Professional
> Services and Retail & Trade
> http://www.orrtiz.com
>
> On Thu, May 7, 2015 at 9:58 AM, Jacopo Cappellato <
> jacopo.cappellato@hotwaxsystems.com> wrote:
>
>> On May 7, 2015, at 9:52 AM, Pierre Smits <pi...@gmail.com> wrote:
>>
>>> I don't think that it is a question of using or not using J8. It is more
>>> about when to move it into trunk, as from that moment on there will be
>>> backward compatibility issues.
>> I think we could do it also in the 14.12 release branch because no
>> releases have been issued from it. And in this way it will be easier to
>> backport future fixes from trunk to 14.12 (an important factor because
>> 14.12 will be maintained for years, unless we change our release strategy).
>>
>> Jacopo
>>
>>
Re: Java 8 and functional programming in trunk
Posted by Pierre Smits <pi...@gmail.com>.
Wouldn't we need a separate CI instance on J8 to ensure that tests don't
fail?
Best regards,
Pierre Smits
*ORRTIZ.COM <http://www.orrtiz.com>*
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com
On Thu, May 7, 2015 at 9:58 AM, Jacopo Cappellato <
jacopo.cappellato@hotwaxsystems.com> wrote:
> On May 7, 2015, at 9:52 AM, Pierre Smits <pi...@gmail.com> wrote:
>
> > I don't think that it is a question of using or not using J8. It is more
> > about when to move it into trunk, as from that moment on there will be
> > backward compatibility issues.
>
> I think we could do it also in the 14.12 release branch because no
> releases have been issued from it. And in this way it will be easier to
> backport future fixes from trunk to 14.12 (an important factor because
> 14.12 will be maintained for years, unless we change our release strategy).
>
> Jacopo
>
>
Re: Java 8 and functional programming in trunk
Posted by Jacopo Cappellato <ja...@hotwaxsystems.com>.
On May 7, 2015, at 9:52 AM, Pierre Smits <pi...@gmail.com> wrote:
> I don't think that it is a question of using or not using J8. It is more
> about when to move it into trunk, as from that moment on there will be
> backward compatibility issues.
I think we could do it also in the 14.12 release branch because no releases have been issued from it. And in this way it will be easier to backport future fixes from trunk to 14.12 (an important factor because 14.12 will be maintained for years, unless we change our release strategy).
Jacopo
Re: Java 8 and functional programming in trunk
Posted by Pierre Smits <pi...@gmail.com>.
So we need to plan for it, and tie it to a release branch?
Best regards,
Pierre Smits
*OFBiz Extensions Marketplace*
http://oem.ofbizci.net/oci-2/
On Wed, Oct 14, 2015 at 11:23 AM, Jacques Le Roux <
jacques.le.roux@les7arts.com> wrote:
> I tend to agree. Actually there are 2 points,
> 1) use Java 8 to compile
> 2) use new Java 8 features
>
> We can already do 1, but we should maybe wait the next freezed branch to
> do 2. That should be discussed but does not prevent 1. Of course any commit
> with 2 will be rejected as long as an agreement on 2 will not be reached
>
> Jacques
>
>
> Le 11/10/2015 19:09, Ron Wheeler a écrit :
>
>> I am not sure why backwards compatibility is an issue with moving to Java
>> 8.
>>
>> It works well,
>> it is the supported version of Java.
>> As far as I have heard, the Java 8 JVM runs code compiled with earlier
>> versions of Java. (My own experience is uniformly positive).
>>
>> I can see no reason to think that anyone who is developing or using OFBiz
>> would need to compile or run with an older version of Java.
>>
>> In this day of VM and Docker Containers, it is hard to imagine that
>> someone would be stuck on an older JVM in a production environment and
>> unable to come up with a configuration that would allow them to run JVM 8
>> to support OFBiz.
>>
>> IMHO, we should just move to requiring the supported version of Java as
>> soon as possible.
>>
>> Ron
>>
>>
>> On 11/10/2015 4:14 AM, Taher Alkhateeb wrote:
>>
>>> Hello Everyone,
>>>
>>> We created and provided the patches for this issue since June and OFBiz
>>> is pretty much ready to move to JDK 8. I'm not sure if lazy consensus is
>>> enough or whether a vote is warranted to move this issue forward?
>>>
>>> Cheers,
>>>
>>> Taher Alkhateeb
>>>
>>> ----- Original Message -----
>>>
>>> From: "Pierre Smits" <pi...@gmail.com>
>>> To: dev@ofbiz.apache.org
>>> Sent: Thursday, 7 May, 2015 10:52:00 AM
>>> Subject: Re: Java 8 and functional programming in trunk
>>>
>>> I don't think that it is a question of using or not using J8. It is more
>>> about when to move it into trunk, as from that moment on there will be
>>> backward compatibility issues.
>>> A helpful solution in this respect could be to designate a specific
>>> release
>>> branch now (e.g. r15 or r16), create the version in JIRA and setup the
>>> dev
>>> branch in svn. Doing it that way J8 related issues can get registered,
>>> changes can get implemented and assessed (in the dev branch) without
>>> breaking current stuff in trunk.
>>>
>>> But it also ensures that we can create awareness prior to releasing
>>> stuff.
>>>
>>> Best regards,
>>>
>>>
>>>
>>> Pierre Smits
>>>
>>> *ORRTIZ.COM <http://www.orrtiz.com>*
>>> Services & Solutions for Cloud-
>>> Based Manufacturing, Professional
>>> Services and Retail & Trade
>>> http://www.orrtiz.com
>>>
>>> On Thu, May 7, 2015 at 9:30 AM, Nicolas Malin <ni...@nereide.fr>
>>> wrote:
>>>
>>> Ok Thanks Scott and Jacques.
>>>>
>>>> So Who is against use java 8 and more on trunk ?
>>>>
>>>> :)
>>>>
>>>> Nicolas
>>>>
>>>>
>>>> Le 07/05/2015 08:46, Jacques Le Roux a écrit :
>>>>
>>>> Yes (lazy) consensus over vote ;)
>>>>>
>>>>> Jacques
>>>>>
>>>>> Le 07/05/2015 05:02, Scott Gray a écrit :
>>>>>
>>>>> I'm not sure if a vote is necessary, particularly if no one has any
>>>>>> objections.
>>>>>>
>>>>>> Regards
>>>>>> Scott
>>>>>> On 7 May 2015 07:44, "Nicolas Malin" <ni...@nereide.fr>
>>>>>> wrote:
>>>>>>
>>>>>> I'm favorable to use java 8.
>>>>>>
>>>>>>> I think it's will be pretty fin if you can support oracle jdk8 and
>>>>>>> openjdk8 also.
>>>>>>>
>>>>>>> I propose to organize a vote to validate or not this proposition
>>>>>>>
>>>>>>> Nicolas
>>>>>>>
>>>>>>> Le 03/05/2015 11:52, Jacques Le Roux a écrit :
>>>>>>>
>>>>>>> Hi Taher,
>>>>>>>
>>>>>>>> Yes I think so. For now well known (I hope ;)) security reasons, if
>>>>>>>> people want to use Oracle JDK they need to use Java 8.
>>>>>>>> So implementing with new Java 8 features now in trunk sounds good to
>>>>>>>> me.
>>>>>>>> BTW this is only my opinion...
>>>>>>>>
>>>>>>>> Note that our demos are still using OpenJDK 1.7 I'm not quite sure
>>>>>>>> of
>>>>>>>> the
>>>>>>>> policy
>>>>>>>>
>>>>>>>>
>>>>>>>> http://www.cvedetails.com/vulnerability-list/vendor_id-93/product_id-23642/version_id-138218/Oracle-Openjdk-1.7.0.html
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Jacques
>>>>>>>>
>>>>>>>>
>>>>>>>> Le 03/05/2015 10:52, Taher Alkhateeb a écrit :
>>>>>>>>
>>>>>>>> Hi everyone,
>>>>>>>>
>>>>>>>>> I would like to work on a few JIRAs and at the same refactor some
>>>>>>>>> existing
>>>>>>>>> code to utilize Lambdas and Streams utilizing Java 8 features.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Is it acceptable to develop with JDK 8 features into trunk?
>>>>>>>>>
>>>>>>>>> Taher Alkhateeb
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>
>>
>>
Re: Java 8 and functional programming in trunk
Posted by Jacques Le Roux <ja...@les7arts.com>.
All demos now run with Java 8. Still Buildbot pending...
Jacques
Le 19/10/2015 10:34, Nicolas Malin a écrit :
> Le 18/10/2015 23:23, Jacques Le Roux a écrit :
>> Thanks Taher,
>>
>> It should be OK, but I'll remember ;)
>>
>> Jacques
> Jacques, Taher, hanks for this issue and your time !
>
Re: Java 8 and functional programming in trunk
Posted by Nicolas Malin <ni...@nereide.fr>.
Le 18/10/2015 23:23, Jacques Le Roux a écrit :
> Thanks Taher,
>
> It should be OK, but I'll remember ;)
>
> Jacques
Jacques, Taher, hanks for this issue and your time !
Re: Java 8 and functional programming in trunk
Posted by Jacques Le Roux <ja...@les7arts.com>.
Thanks Taher,
It should be OK, but I'll remember ;)
Jacques
Le 18/10/2015 20:55, Taher Alkhateeb a écrit :
> Thank you for the support Jacques. Please tell if I can help.
>
> Taher Alkhateeb
> On Oct 18, 2015 9:49 PM, "Jacques Le Roux" <ja...@les7arts.com>
> wrote:
>
>> WIP for both Buildbot and the demos...
>> The trunk demo will still run with Java 7 for now
>>
>> Jacques
>>
>> Le 18/10/2015 14:37, Jacques Le Roux a écrit :
>>
>>> Ha we have also Buildbot...
>>>
>>> Le 18/10/2015 14:37, Jacques Le Roux a écrit :
>>>
>>>> I can tweak that on the VM for now;) Doing it right now...
>>>>
>>>> Jacques
>>>>
>>>> Le 18/10/2015 12:39, Taher Alkhateeb a écrit :
>>>>
>>>>> Hi Jacques,
>>>>>
>>>>> Actually I think it will be required immediately because the build will
>>>>> fail. Below is the exact patch line in macros.xml that would fail the
>>>>> builds:
>>>>>
>>>>> + <fail unless="javaatleast18" message="Please upgrade java to at least
>>>>> 1.8. Current Java version is ${ant.java.version}"/>
>>>>>
>>>>> Taher Alkhateeb
>>>>>
>>>>> ----- Original Message -----
>>>>>
>>>>> From: "Jacques Le Roux" <ja...@les7arts.com>
>>>>> To: dev@ofbiz.apache.org
>>>>> Sent: Sunday, 18 October, 2015 1:36:22 PM
>>>>> Subject: Re: Java 8 and functional programming in trunk
>>>>>
>>>>> Hi Taher,
>>>>>
>>>>> Yes I remember now, that's exactly why I was reluctant to do so. I have
>>>>> a message remembering me that popping everyday... for months (I have tons of
>>>>> others :D)
>>>>>
>>>>> Actually it should not be a burden. I have just to upload Java 8 on the
>>>>> VM and set trunk to use it. it will be mandatory only when we will really
>>>>> begin to commit Java 8 features...
>>>>>
>>>>> Jacques
>>>>>
>>>>> Le 18/10/2015 12:21, Taher Alkhateeb a écrit :
>>>>>
>>>>>> Hello Everyone,
>>>>>>
>>>>>> I have updated the patch to upgrade to JDK 8 in JIRA
>>>>>> https://issues.apache.org/jira/browse/OFBIZ-6458 and ran all tests
>>>>>> and everything is okay from my side. If no one objects I will go ahead and
>>>>>> commit this patch.
>>>>>>
>>>>>> Jacques, we will need your help to upgrade the CI build system for
>>>>>> trunk to use JDK 8.
>>>>>>
>>>>>> Taher Alkhateeb
>>>>>>
>>>>>> ----- Original Message -----
>>>>>>
>>>>>> From: "Ron Wheeler" <rw...@artifact-software.com>
>>>>>> To: dev@ofbiz.apache.org
>>>>>> Sent: Wednesday, 14 October, 2015 3:40:33 PM
>>>>>> Subject: Re: Java 8 and functional programming in trunk
>>>>>>
>>>>>> Good point about the backporting.
>>>>>> This will have an effect on the enthusiasm for backporting fixes.
>>>>>>
>>>>>> Comparing trunk and backported code will certainly make for some good
>>>>>> examples about how to use Java 8 to write more concise and clearer
>>>>>> code.
>>>>>>
>>>>>> Ron
>>>>>>
>>>>>> On 14/10/2015 8:29 AM, Jacques Le Roux wrote:
>>>>>>
>>>>>>> Yes I think I confused myself on this one (for my defense I got a
>>>>>>> *strong* cold recently and I'm just recovering :p)
>>>>>>>
>>>>>>> Inline...
>>>>>>>
>>>>>>> Le 14/10/2015 14:05, Ron Wheeler a écrit :
>>>>>>>
>>>>>>>> +1 on Tahar Alkhateeb's points.
>>>>>>>>
>>>>>>>> I don't think that anyone is proposing to convert all existing code
>>>>>>>> to use the latest Java 8 features.
>>>>>>>>
>>>>>>>> I think that once you force people to run the Java 8 JVM by doing the
>>>>>>>> compile with Java 8, you are pretty much done.
>>>>>>>>
>>>>>>>> If someone adds a Stream function in their code and the code is
>>>>>>>> validated to work correctly, that should be the end of the story.
>>>>>>>> We don't vote on other code changes.
>>>>>>>>
>>>>>>>> Who is going to check new patches to ensure that they do not depend
>>>>>>>> on Java 8 features or bugs fixed in Java 8?
>>>>>>>>
>>>>>>> As explained in my answer to Taher, we need to be sure we don't
>>>>>>> backport Java 8 features in released branches which are supposed to
>>>>>>> work with Java 7, that's all.
>>>>>>>
>>>>>>> What was the process when Java 7 features where allowed into the
>>>>>>>> trunk? Was a 2 part vote required?
>>>>>>>>
>>>>>>> Nope, mistake on my side
>>>>>>>
>>>>>>> Jacques
>>>>>>>
>>>>>>> Ron
>>>>>>>> On 14/10/2015 6:17 AM, Taher Alkhateeb wrote:
>>>>>>>>
>>>>>>>>> Hi Jacques,
>>>>>>>>>
>>>>>>>>> I am a bit confused? Why wait for a frozen branch for anything? I
>>>>>>>>> thought trunk is your development/unstable bleeding-edge part of the
>>>>>>>>> code. This is where you introduce changes without worrying about
>>>>>>>>> people's stable systems because they base their systems on release
>>>>>>>>> branches. In fact, branches exist only to stabilize trunk at certain
>>>>>>>>> points of time.
>>>>>>>>>
>>>>>>>>> Furthermore, if we introduce Java 8 into trunk, what possible
>>>>>>>>> logical reason exists for _voting_ to use the new features of the
>>>>>>>>> language? Why did you upgrade in the first place if you do not
>>>>>>>>> intend to use the newer features?
>>>>>>>>>
>>>>>>>>> Taher Alkhateeb
>>>>>>>>>
>>>>>>>>> ----- Original Message -----
>>>>>>>>>
>>>>>>>>> From: "Jacques Le Roux" <ja...@les7arts.com>
>>>>>>>>> To: dev@ofbiz.apache.org
>>>>>>>>> Sent: Wednesday, 14 October, 2015 12:23:31 PM
>>>>>>>>> Subject: Re: Java 8 and functional programming in trunk
>>>>>>>>>
>>>>>>>>> I tend to agree. Actually there are 2 points,
>>>>>>>>> 1) use Java 8 to compile
>>>>>>>>> 2) use new Java 8 features
>>>>>>>>>
>>>>>>>>> We can already do 1, but we should maybe wait the next freezed
>>>>>>>>> branch to do 2. That should be discussed but does not prevent 1. Of
>>>>>>>>> course any commit
>>>>>>>>> with 2 will be rejected as long as an agreement on 2 will not be
>>>>>>>>> reached
>>>>>>>>>
>>>>>>>>> Jacques
>>>>>>>>>
>>>>>>>>> Le 11/10/2015 19:09, Ron Wheeler a écrit :
>>>>>>>>>
>>>>>>>>>> I am not sure why backwards compatibility is an issue with moving
>>>>>>>>>> to Java 8.
>>>>>>>>>>
>>>>>>>>>> It works well,
>>>>>>>>>> it is the supported version of Java.
>>>>>>>>>> As far as I have heard, the Java 8 JVM runs code compiled with
>>>>>>>>>> earlier versions of Java. (My own experience is uniformly
>>>>>>>>>> positive).
>>>>>>>>>>
>>>>>>>>>> I can see no reason to think that anyone who is developing or using
>>>>>>>>>> OFBiz would need to compile or run with an older version of Java.
>>>>>>>>>>
>>>>>>>>>> In this day of VM and Docker Containers, it is hard to imagine that
>>>>>>>>>> someone would be stuck on an older JVM in a production environment
>>>>>>>>>> and unable to
>>>>>>>>>> come up with a configuration that would allow them to run JVM 8 to
>>>>>>>>>> support OFBiz.
>>>>>>>>>>
>>>>>>>>>> IMHO, we should just move to requiring the supported version of
>>>>>>>>>> Java as soon as possible.
>>>>>>>>>>
>>>>>>>>>> Ron
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On 11/10/2015 4:14 AM, Taher Alkhateeb wrote:
>>>>>>>>>>
>>>>>>>>>>> Hello Everyone,
>>>>>>>>>>>
>>>>>>>>>>> We created and provided the patches for this issue since June and
>>>>>>>>>>> OFBiz is pretty much ready to move to JDK 8. I'm not sure if lazy
>>>>>>>>>>> consensus is
>>>>>>>>>>> enough or whether a vote is warranted to move this issue forward?
>>>>>>>>>>>
>>>>>>>>>>> Cheers,
>>>>>>>>>>>
>>>>>>>>>>> Taher Alkhateeb
>>>>>>>>>>>
>>>>>>>>>>> ----- Original Message -----
>>>>>>>>>>>
>>>>>>>>>>> From: "Pierre Smits" <pi...@gmail.com>
>>>>>>>>>>> To: dev@ofbiz.apache.org
>>>>>>>>>>> Sent: Thursday, 7 May, 2015 10:52:00 AM
>>>>>>>>>>> Subject: Re: Java 8 and functional programming in trunk
>>>>>>>>>>>
>>>>>>>>>>> I don't think that it is a question of using or not using J8. It
>>>>>>>>>>> is more
>>>>>>>>>>> about when to move it into trunk, as from that moment on there
>>>>>>>>>>> will be
>>>>>>>>>>> backward compatibility issues.
>>>>>>>>>>> A helpful solution in this respect could be to designate a
>>>>>>>>>>> specific release
>>>>>>>>>>> branch now (e.g. r15 or r16), create the version in JIRA and setup
>>>>>>>>>>> the dev
>>>>>>>>>>> branch in svn. Doing it that way J8 related issues can get
>>>>>>>>>>> registered,
>>>>>>>>>>> changes can get implemented and assessed (in the dev branch)
>>>>>>>>>>> without
>>>>>>>>>>> breaking current stuff in trunk.
>>>>>>>>>>>
>>>>>>>>>>> But it also ensures that we can create awareness prior to
>>>>>>>>>>> releasing stuff.
>>>>>>>>>>>
>>>>>>>>>>> Best regards,
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Pierre Smits
>>>>>>>>>>>
>>>>>>>>>>> *ORRTIZ.COM <http://www.orrtiz.com>*
>>>>>>>>>>> Services & Solutions for Cloud-
>>>>>>>>>>> Based Manufacturing, Professional
>>>>>>>>>>> Services and Retail & Trade
>>>>>>>>>>> http://www.orrtiz.com
>>>>>>>>>>>
>>>>>>>>>>> On Thu, May 7, 2015 at 9:30 AM, Nicolas Malin
>>>>>>>>>>> <ni...@nereide.fr>
>>>>>>>>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>> Ok Thanks Scott and Jacques.
>>>>>>>>>>>> So Who is against use java 8 and more on trunk ?
>>>>>>>>>>>>
>>>>>>>>>>>> :)
>>>>>>>>>>>>
>>>>>>>>>>>> Nicolas
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Le 07/05/2015 08:46, Jacques Le Roux a écrit :
>>>>>>>>>>>>
>>>>>>>>>>>> Yes (lazy) consensus over vote ;)
>>>>>>>>>>>>> Jacques
>>>>>>>>>>>>>
>>>>>>>>>>>>> Le 07/05/2015 05:02, Scott Gray a écrit :
>>>>>>>>>>>>>
>>>>>>>>>>>>> I'm not sure if a vote is necessary, particularly if no one has
>>>>>>>>>>>>>> any
>>>>>>>>>>>>>> objections.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Regards
>>>>>>>>>>>>>> Scott
>>>>>>>>>>>>>> On 7 May 2015 07:44, "Nicolas Malin" <nicolas.malin@nereide.fr
>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> I'm favorable to use java 8.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> I think it's will be pretty fin if you can support oracle jdk8
>>>>>>>>>>>>>>> and
>>>>>>>>>>>>>>> openjdk8 also.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> I propose to organize a vote to validate or not this
>>>>>>>>>>>>>>> proposition
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Nicolas
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Le 03/05/2015 11:52, Jacques Le Roux a écrit :
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Hi Taher,
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Yes I think so. For now well known (I hope ;)) security
>>>>>>>>>>>>>>>> reasons, if
>>>>>>>>>>>>>>>> people want to use Oracle JDK they need to use Java 8.
>>>>>>>>>>>>>>>> So implementing with new Java 8 features now in trunk sounds
>>>>>>>>>>>>>>>> good to
>>>>>>>>>>>>>>>> me.
>>>>>>>>>>>>>>>> BTW this is only my opinion...
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Note that our demos are still using OpenJDK 1.7 I'm not quite
>>>>>>>>>>>>>>>> sure of
>>>>>>>>>>>>>>>> the
>>>>>>>>>>>>>>>> policy
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> http://www.cvedetails.com/vulnerability-list/vendor_id-93/product_id-23642/version_id-138218/Oracle-Openjdk-1.7.0.html
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Jacques
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Le 03/05/2015 10:52, Taher Alkhateeb a écrit :
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Hi everyone,
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> I would like to work on a few JIRAs and at the same refactor
>>>>>>>>>>>>>>>>> some
>>>>>>>>>>>>>>>>> existing
>>>>>>>>>>>>>>>>> code to utilize Lambdas and Streams utilizing Java 8
>>>>>>>>>>>>>>>>> features.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Is it acceptable to develop with JDK 8 features into trunk?
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Taher Alkhateeb
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
Re: Java 8 and functional programming in trunk
Posted by Taher Alkhateeb <sl...@gmail.com>.
Thank you for the support Jacques. Please tell if I can help.
Taher Alkhateeb
On Oct 18, 2015 9:49 PM, "Jacques Le Roux" <ja...@les7arts.com>
wrote:
> WIP for both Buildbot and the demos...
> The trunk demo will still run with Java 7 for now
>
> Jacques
>
> Le 18/10/2015 14:37, Jacques Le Roux a écrit :
>
>> Ha we have also Buildbot...
>>
>> Le 18/10/2015 14:37, Jacques Le Roux a écrit :
>>
>>> I can tweak that on the VM for now;) Doing it right now...
>>>
>>> Jacques
>>>
>>> Le 18/10/2015 12:39, Taher Alkhateeb a écrit :
>>>
>>>> Hi Jacques,
>>>>
>>>> Actually I think it will be required immediately because the build will
>>>> fail. Below is the exact patch line in macros.xml that would fail the
>>>> builds:
>>>>
>>>> + <fail unless="javaatleast18" message="Please upgrade java to at least
>>>> 1.8. Current Java version is ${ant.java.version}"/>
>>>>
>>>> Taher Alkhateeb
>>>>
>>>> ----- Original Message -----
>>>>
>>>> From: "Jacques Le Roux" <ja...@les7arts.com>
>>>> To: dev@ofbiz.apache.org
>>>> Sent: Sunday, 18 October, 2015 1:36:22 PM
>>>> Subject: Re: Java 8 and functional programming in trunk
>>>>
>>>> Hi Taher,
>>>>
>>>> Yes I remember now, that's exactly why I was reluctant to do so. I have
>>>> a message remembering me that popping everyday... for months (I have tons of
>>>> others :D)
>>>>
>>>> Actually it should not be a burden. I have just to upload Java 8 on the
>>>> VM and set trunk to use it. it will be mandatory only when we will really
>>>> begin to commit Java 8 features...
>>>>
>>>> Jacques
>>>>
>>>> Le 18/10/2015 12:21, Taher Alkhateeb a écrit :
>>>>
>>>>> Hello Everyone,
>>>>>
>>>>> I have updated the patch to upgrade to JDK 8 in JIRA
>>>>> https://issues.apache.org/jira/browse/OFBIZ-6458 and ran all tests
>>>>> and everything is okay from my side. If no one objects I will go ahead and
>>>>> commit this patch.
>>>>>
>>>>> Jacques, we will need your help to upgrade the CI build system for
>>>>> trunk to use JDK 8.
>>>>>
>>>>> Taher Alkhateeb
>>>>>
>>>>> ----- Original Message -----
>>>>>
>>>>> From: "Ron Wheeler" <rw...@artifact-software.com>
>>>>> To: dev@ofbiz.apache.org
>>>>> Sent: Wednesday, 14 October, 2015 3:40:33 PM
>>>>> Subject: Re: Java 8 and functional programming in trunk
>>>>>
>>>>> Good point about the backporting.
>>>>> This will have an effect on the enthusiasm for backporting fixes.
>>>>>
>>>>> Comparing trunk and backported code will certainly make for some good
>>>>> examples about how to use Java 8 to write more concise and clearer
>>>>> code.
>>>>>
>>>>> Ron
>>>>>
>>>>> On 14/10/2015 8:29 AM, Jacques Le Roux wrote:
>>>>>
>>>>>> Yes I think I confused myself on this one (for my defense I got a
>>>>>> *strong* cold recently and I'm just recovering :p)
>>>>>>
>>>>>> Inline...
>>>>>>
>>>>>> Le 14/10/2015 14:05, Ron Wheeler a écrit :
>>>>>>
>>>>>>> +1 on Tahar Alkhateeb's points.
>>>>>>>
>>>>>>> I don't think that anyone is proposing to convert all existing code
>>>>>>> to use the latest Java 8 features.
>>>>>>>
>>>>>>> I think that once you force people to run the Java 8 JVM by doing the
>>>>>>> compile with Java 8, you are pretty much done.
>>>>>>>
>>>>>>> If someone adds a Stream function in their code and the code is
>>>>>>> validated to work correctly, that should be the end of the story.
>>>>>>> We don't vote on other code changes.
>>>>>>>
>>>>>>> Who is going to check new patches to ensure that they do not depend
>>>>>>> on Java 8 features or bugs fixed in Java 8?
>>>>>>>
>>>>>> As explained in my answer to Taher, we need to be sure we don't
>>>>>> backport Java 8 features in released branches which are supposed to
>>>>>> work with Java 7, that's all.
>>>>>>
>>>>>> What was the process when Java 7 features where allowed into the
>>>>>>> trunk? Was a 2 part vote required?
>>>>>>>
>>>>>> Nope, mistake on my side
>>>>>>
>>>>>> Jacques
>>>>>>
>>>>>> Ron
>>>>>>>
>>>>>>> On 14/10/2015 6:17 AM, Taher Alkhateeb wrote:
>>>>>>>
>>>>>>>> Hi Jacques,
>>>>>>>>
>>>>>>>> I am a bit confused? Why wait for a frozen branch for anything? I
>>>>>>>> thought trunk is your development/unstable bleeding-edge part of the
>>>>>>>> code. This is where you introduce changes without worrying about
>>>>>>>> people's stable systems because they base their systems on release
>>>>>>>> branches. In fact, branches exist only to stabilize trunk at certain
>>>>>>>> points of time.
>>>>>>>>
>>>>>>>> Furthermore, if we introduce Java 8 into trunk, what possible
>>>>>>>> logical reason exists for _voting_ to use the new features of the
>>>>>>>> language? Why did you upgrade in the first place if you do not
>>>>>>>> intend to use the newer features?
>>>>>>>>
>>>>>>>> Taher Alkhateeb
>>>>>>>>
>>>>>>>> ----- Original Message -----
>>>>>>>>
>>>>>>>> From: "Jacques Le Roux" <ja...@les7arts.com>
>>>>>>>> To: dev@ofbiz.apache.org
>>>>>>>> Sent: Wednesday, 14 October, 2015 12:23:31 PM
>>>>>>>> Subject: Re: Java 8 and functional programming in trunk
>>>>>>>>
>>>>>>>> I tend to agree. Actually there are 2 points,
>>>>>>>> 1) use Java 8 to compile
>>>>>>>> 2) use new Java 8 features
>>>>>>>>
>>>>>>>> We can already do 1, but we should maybe wait the next freezed
>>>>>>>> branch to do 2. That should be discussed but does not prevent 1. Of
>>>>>>>> course any commit
>>>>>>>> with 2 will be rejected as long as an agreement on 2 will not be
>>>>>>>> reached
>>>>>>>>
>>>>>>>> Jacques
>>>>>>>>
>>>>>>>> Le 11/10/2015 19:09, Ron Wheeler a écrit :
>>>>>>>>
>>>>>>>>> I am not sure why backwards compatibility is an issue with moving
>>>>>>>>> to Java 8.
>>>>>>>>>
>>>>>>>>> It works well,
>>>>>>>>> it is the supported version of Java.
>>>>>>>>> As far as I have heard, the Java 8 JVM runs code compiled with
>>>>>>>>> earlier versions of Java. (My own experience is uniformly
>>>>>>>>> positive).
>>>>>>>>>
>>>>>>>>> I can see no reason to think that anyone who is developing or using
>>>>>>>>> OFBiz would need to compile or run with an older version of Java.
>>>>>>>>>
>>>>>>>>> In this day of VM and Docker Containers, it is hard to imagine that
>>>>>>>>> someone would be stuck on an older JVM in a production environment
>>>>>>>>> and unable to
>>>>>>>>> come up with a configuration that would allow them to run JVM 8 to
>>>>>>>>> support OFBiz.
>>>>>>>>>
>>>>>>>>> IMHO, we should just move to requiring the supported version of
>>>>>>>>> Java as soon as possible.
>>>>>>>>>
>>>>>>>>> Ron
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On 11/10/2015 4:14 AM, Taher Alkhateeb wrote:
>>>>>>>>>
>>>>>>>>>> Hello Everyone,
>>>>>>>>>>
>>>>>>>>>> We created and provided the patches for this issue since June and
>>>>>>>>>> OFBiz is pretty much ready to move to JDK 8. I'm not sure if lazy
>>>>>>>>>> consensus is
>>>>>>>>>> enough or whether a vote is warranted to move this issue forward?
>>>>>>>>>>
>>>>>>>>>> Cheers,
>>>>>>>>>>
>>>>>>>>>> Taher Alkhateeb
>>>>>>>>>>
>>>>>>>>>> ----- Original Message -----
>>>>>>>>>>
>>>>>>>>>> From: "Pierre Smits" <pi...@gmail.com>
>>>>>>>>>> To: dev@ofbiz.apache.org
>>>>>>>>>> Sent: Thursday, 7 May, 2015 10:52:00 AM
>>>>>>>>>> Subject: Re: Java 8 and functional programming in trunk
>>>>>>>>>>
>>>>>>>>>> I don't think that it is a question of using or not using J8. It
>>>>>>>>>> is more
>>>>>>>>>> about when to move it into trunk, as from that moment on there
>>>>>>>>>> will be
>>>>>>>>>> backward compatibility issues.
>>>>>>>>>> A helpful solution in this respect could be to designate a
>>>>>>>>>> specific release
>>>>>>>>>> branch now (e.g. r15 or r16), create the version in JIRA and setup
>>>>>>>>>> the dev
>>>>>>>>>> branch in svn. Doing it that way J8 related issues can get
>>>>>>>>>> registered,
>>>>>>>>>> changes can get implemented and assessed (in the dev branch)
>>>>>>>>>> without
>>>>>>>>>> breaking current stuff in trunk.
>>>>>>>>>>
>>>>>>>>>> But it also ensures that we can create awareness prior to
>>>>>>>>>> releasing stuff.
>>>>>>>>>>
>>>>>>>>>> Best regards,
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Pierre Smits
>>>>>>>>>>
>>>>>>>>>> *ORRTIZ.COM <http://www.orrtiz.com>*
>>>>>>>>>> Services & Solutions for Cloud-
>>>>>>>>>> Based Manufacturing, Professional
>>>>>>>>>> Services and Retail & Trade
>>>>>>>>>> http://www.orrtiz.com
>>>>>>>>>>
>>>>>>>>>> On Thu, May 7, 2015 at 9:30 AM, Nicolas Malin
>>>>>>>>>> <ni...@nereide.fr>
>>>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>> Ok Thanks Scott and Jacques.
>>>>>>>>>>>
>>>>>>>>>>> So Who is against use java 8 and more on trunk ?
>>>>>>>>>>>
>>>>>>>>>>> :)
>>>>>>>>>>>
>>>>>>>>>>> Nicolas
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Le 07/05/2015 08:46, Jacques Le Roux a écrit :
>>>>>>>>>>>
>>>>>>>>>>> Yes (lazy) consensus over vote ;)
>>>>>>>>>>>>
>>>>>>>>>>>> Jacques
>>>>>>>>>>>>
>>>>>>>>>>>> Le 07/05/2015 05:02, Scott Gray a écrit :
>>>>>>>>>>>>
>>>>>>>>>>>> I'm not sure if a vote is necessary, particularly if no one has
>>>>>>>>>>>>> any
>>>>>>>>>>>>> objections.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Regards
>>>>>>>>>>>>> Scott
>>>>>>>>>>>>> On 7 May 2015 07:44, "Nicolas Malin" <nicolas.malin@nereide.fr
>>>>>>>>>>>>> >
>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>> I'm favorable to use java 8.
>>>>>>>>>>>>>
>>>>>>>>>>>>>> I think it's will be pretty fin if you can support oracle jdk8
>>>>>>>>>>>>>> and
>>>>>>>>>>>>>> openjdk8 also.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> I propose to organize a vote to validate or not this
>>>>>>>>>>>>>> proposition
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Nicolas
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Le 03/05/2015 11:52, Jacques Le Roux a écrit :
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Hi Taher,
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Yes I think so. For now well known (I hope ;)) security
>>>>>>>>>>>>>>> reasons, if
>>>>>>>>>>>>>>> people want to use Oracle JDK they need to use Java 8.
>>>>>>>>>>>>>>> So implementing with new Java 8 features now in trunk sounds
>>>>>>>>>>>>>>> good to
>>>>>>>>>>>>>>> me.
>>>>>>>>>>>>>>> BTW this is only my opinion...
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Note that our demos are still using OpenJDK 1.7 I'm not quite
>>>>>>>>>>>>>>> sure of
>>>>>>>>>>>>>>> the
>>>>>>>>>>>>>>> policy
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> http://www.cvedetails.com/vulnerability-list/vendor_id-93/product_id-23642/version_id-138218/Oracle-Openjdk-1.7.0.html
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Jacques
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Le 03/05/2015 10:52, Taher Alkhateeb a écrit :
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Hi everyone,
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> I would like to work on a few JIRAs and at the same refactor
>>>>>>>>>>>>>>>> some
>>>>>>>>>>>>>>>> existing
>>>>>>>>>>>>>>>> code to utilize Lambdas and Streams utilizing Java 8
>>>>>>>>>>>>>>>> features.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Is it acceptable to develop with JDK 8 features into trunk?
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Taher Alkhateeb
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>
>>>
>>
Re: Java 8 and functional programming in trunk
Posted by Jacques Le Roux <ja...@les7arts.com>.
WIP for both Buildbot and the demos...
The trunk demo will still run with Java 7 for now
Jacques
Le 18/10/2015 14:37, Jacques Le Roux a écrit :
> Ha we have also Buildbot...
>
> Le 18/10/2015 14:37, Jacques Le Roux a écrit :
>> I can tweak that on the VM for now;) Doing it right now...
>>
>> Jacques
>>
>> Le 18/10/2015 12:39, Taher Alkhateeb a écrit :
>>> Hi Jacques,
>>>
>>> Actually I think it will be required immediately because the build will fail. Below is the exact patch line in macros.xml that would fail the builds:
>>>
>>> + <fail unless="javaatleast18" message="Please upgrade java to at least 1.8. Current Java version is ${ant.java.version}"/>
>>>
>>> Taher Alkhateeb
>>>
>>> ----- Original Message -----
>>>
>>> From: "Jacques Le Roux" <ja...@les7arts.com>
>>> To: dev@ofbiz.apache.org
>>> Sent: Sunday, 18 October, 2015 1:36:22 PM
>>> Subject: Re: Java 8 and functional programming in trunk
>>>
>>> Hi Taher,
>>>
>>> Yes I remember now, that's exactly why I was reluctant to do so. I have a message remembering me that popping everyday... for months (I have tons of
>>> others :D)
>>>
>>> Actually it should not be a burden. I have just to upload Java 8 on the VM and set trunk to use it. it will be mandatory only when we will really
>>> begin to commit Java 8 features...
>>>
>>> Jacques
>>>
>>> Le 18/10/2015 12:21, Taher Alkhateeb a écrit :
>>>> Hello Everyone,
>>>>
>>>> I have updated the patch to upgrade to JDK 8 in JIRA https://issues.apache.org/jira/browse/OFBIZ-6458 and ran all tests and everything is okay
>>>> from my side. If no one objects I will go ahead and commit this patch.
>>>>
>>>> Jacques, we will need your help to upgrade the CI build system for trunk to use JDK 8.
>>>>
>>>> Taher Alkhateeb
>>>>
>>>> ----- Original Message -----
>>>>
>>>> From: "Ron Wheeler" <rw...@artifact-software.com>
>>>> To: dev@ofbiz.apache.org
>>>> Sent: Wednesday, 14 October, 2015 3:40:33 PM
>>>> Subject: Re: Java 8 and functional programming in trunk
>>>>
>>>> Good point about the backporting.
>>>> This will have an effect on the enthusiasm for backporting fixes.
>>>>
>>>> Comparing trunk and backported code will certainly make for some good
>>>> examples about how to use Java 8 to write more concise and clearer code.
>>>>
>>>> Ron
>>>>
>>>> On 14/10/2015 8:29 AM, Jacques Le Roux wrote:
>>>>> Yes I think I confused myself on this one (for my defense I got a
>>>>> *strong* cold recently and I'm just recovering :p)
>>>>>
>>>>> Inline...
>>>>>
>>>>> Le 14/10/2015 14:05, Ron Wheeler a écrit :
>>>>>> +1 on Tahar Alkhateeb's points.
>>>>>>
>>>>>> I don't think that anyone is proposing to convert all existing code
>>>>>> to use the latest Java 8 features.
>>>>>>
>>>>>> I think that once you force people to run the Java 8 JVM by doing the
>>>>>> compile with Java 8, you are pretty much done.
>>>>>>
>>>>>> If someone adds a Stream function in their code and the code is
>>>>>> validated to work correctly, that should be the end of the story.
>>>>>> We don't vote on other code changes.
>>>>>>
>>>>>> Who is going to check new patches to ensure that they do not depend
>>>>>> on Java 8 features or bugs fixed in Java 8?
>>>>> As explained in my answer to Taher, we need to be sure we don't
>>>>> backport Java 8 features in released branches which are supposed to
>>>>> work with Java 7, that's all.
>>>>>
>>>>>> What was the process when Java 7 features where allowed into the
>>>>>> trunk? Was a 2 part vote required?
>>>>> Nope, mistake on my side
>>>>>
>>>>> Jacques
>>>>>
>>>>>> Ron
>>>>>>
>>>>>> On 14/10/2015 6:17 AM, Taher Alkhateeb wrote:
>>>>>>> Hi Jacques,
>>>>>>>
>>>>>>> I am a bit confused? Why wait for a frozen branch for anything? I
>>>>>>> thought trunk is your development/unstable bleeding-edge part of the
>>>>>>> code. This is where you introduce changes without worrying about
>>>>>>> people's stable systems because they base their systems on release
>>>>>>> branches. In fact, branches exist only to stabilize trunk at certain
>>>>>>> points of time.
>>>>>>>
>>>>>>> Furthermore, if we introduce Java 8 into trunk, what possible
>>>>>>> logical reason exists for _voting_ to use the new features of the
>>>>>>> language? Why did you upgrade in the first place if you do not
>>>>>>> intend to use the newer features?
>>>>>>>
>>>>>>> Taher Alkhateeb
>>>>>>>
>>>>>>> ----- Original Message -----
>>>>>>>
>>>>>>> From: "Jacques Le Roux" <ja...@les7arts.com>
>>>>>>> To: dev@ofbiz.apache.org
>>>>>>> Sent: Wednesday, 14 October, 2015 12:23:31 PM
>>>>>>> Subject: Re: Java 8 and functional programming in trunk
>>>>>>>
>>>>>>> I tend to agree. Actually there are 2 points,
>>>>>>> 1) use Java 8 to compile
>>>>>>> 2) use new Java 8 features
>>>>>>>
>>>>>>> We can already do 1, but we should maybe wait the next freezed
>>>>>>> branch to do 2. That should be discussed but does not prevent 1. Of
>>>>>>> course any commit
>>>>>>> with 2 will be rejected as long as an agreement on 2 will not be
>>>>>>> reached
>>>>>>>
>>>>>>> Jacques
>>>>>>>
>>>>>>> Le 11/10/2015 19:09, Ron Wheeler a écrit :
>>>>>>>> I am not sure why backwards compatibility is an issue with moving
>>>>>>>> to Java 8.
>>>>>>>>
>>>>>>>> It works well,
>>>>>>>> it is the supported version of Java.
>>>>>>>> As far as I have heard, the Java 8 JVM runs code compiled with
>>>>>>>> earlier versions of Java. (My own experience is uniformly positive).
>>>>>>>>
>>>>>>>> I can see no reason to think that anyone who is developing or using
>>>>>>>> OFBiz would need to compile or run with an older version of Java.
>>>>>>>>
>>>>>>>> In this day of VM and Docker Containers, it is hard to imagine that
>>>>>>>> someone would be stuck on an older JVM in a production environment
>>>>>>>> and unable to
>>>>>>>> come up with a configuration that would allow them to run JVM 8 to
>>>>>>>> support OFBiz.
>>>>>>>>
>>>>>>>> IMHO, we should just move to requiring the supported version of
>>>>>>>> Java as soon as possible.
>>>>>>>>
>>>>>>>> Ron
>>>>>>>>
>>>>>>>>
>>>>>>>> On 11/10/2015 4:14 AM, Taher Alkhateeb wrote:
>>>>>>>>> Hello Everyone,
>>>>>>>>>
>>>>>>>>> We created and provided the patches for this issue since June and
>>>>>>>>> OFBiz is pretty much ready to move to JDK 8. I'm not sure if lazy
>>>>>>>>> consensus is
>>>>>>>>> enough or whether a vote is warranted to move this issue forward?
>>>>>>>>>
>>>>>>>>> Cheers,
>>>>>>>>>
>>>>>>>>> Taher Alkhateeb
>>>>>>>>>
>>>>>>>>> ----- Original Message -----
>>>>>>>>>
>>>>>>>>> From: "Pierre Smits" <pi...@gmail.com>
>>>>>>>>> To: dev@ofbiz.apache.org
>>>>>>>>> Sent: Thursday, 7 May, 2015 10:52:00 AM
>>>>>>>>> Subject: Re: Java 8 and functional programming in trunk
>>>>>>>>>
>>>>>>>>> I don't think that it is a question of using or not using J8. It
>>>>>>>>> is more
>>>>>>>>> about when to move it into trunk, as from that moment on there
>>>>>>>>> will be
>>>>>>>>> backward compatibility issues.
>>>>>>>>> A helpful solution in this respect could be to designate a
>>>>>>>>> specific release
>>>>>>>>> branch now (e.g. r15 or r16), create the version in JIRA and setup
>>>>>>>>> the dev
>>>>>>>>> branch in svn. Doing it that way J8 related issues can get
>>>>>>>>> registered,
>>>>>>>>> changes can get implemented and assessed (in the dev branch) without
>>>>>>>>> breaking current stuff in trunk.
>>>>>>>>>
>>>>>>>>> But it also ensures that we can create awareness prior to
>>>>>>>>> releasing stuff.
>>>>>>>>>
>>>>>>>>> Best regards,
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Pierre Smits
>>>>>>>>>
>>>>>>>>> *ORRTIZ.COM <http://www.orrtiz.com>*
>>>>>>>>> Services & Solutions for Cloud-
>>>>>>>>> Based Manufacturing, Professional
>>>>>>>>> Services and Retail & Trade
>>>>>>>>> http://www.orrtiz.com
>>>>>>>>>
>>>>>>>>> On Thu, May 7, 2015 at 9:30 AM, Nicolas Malin
>>>>>>>>> <ni...@nereide.fr>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>> Ok Thanks Scott and Jacques.
>>>>>>>>>>
>>>>>>>>>> So Who is against use java 8 and more on trunk ?
>>>>>>>>>>
>>>>>>>>>> :)
>>>>>>>>>>
>>>>>>>>>> Nicolas
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Le 07/05/2015 08:46, Jacques Le Roux a écrit :
>>>>>>>>>>
>>>>>>>>>>> Yes (lazy) consensus over vote ;)
>>>>>>>>>>>
>>>>>>>>>>> Jacques
>>>>>>>>>>>
>>>>>>>>>>> Le 07/05/2015 05:02, Scott Gray a écrit :
>>>>>>>>>>>
>>>>>>>>>>>> I'm not sure if a vote is necessary, particularly if no one has
>>>>>>>>>>>> any
>>>>>>>>>>>> objections.
>>>>>>>>>>>>
>>>>>>>>>>>> Regards
>>>>>>>>>>>> Scott
>>>>>>>>>>>> On 7 May 2015 07:44, "Nicolas Malin" <ni...@nereide.fr>
>>>>>>>>>>>> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>> I'm favorable to use java 8.
>>>>>>>>>>>>> I think it's will be pretty fin if you can support oracle jdk8
>>>>>>>>>>>>> and
>>>>>>>>>>>>> openjdk8 also.
>>>>>>>>>>>>>
>>>>>>>>>>>>> I propose to organize a vote to validate or not this proposition
>>>>>>>>>>>>>
>>>>>>>>>>>>> Nicolas
>>>>>>>>>>>>>
>>>>>>>>>>>>> Le 03/05/2015 11:52, Jacques Le Roux a écrit :
>>>>>>>>>>>>>
>>>>>>>>>>>>> Hi Taher,
>>>>>>>>>>>>>> Yes I think so. For now well known (I hope ;)) security
>>>>>>>>>>>>>> reasons, if
>>>>>>>>>>>>>> people want to use Oracle JDK they need to use Java 8.
>>>>>>>>>>>>>> So implementing with new Java 8 features now in trunk sounds
>>>>>>>>>>>>>> good to
>>>>>>>>>>>>>> me.
>>>>>>>>>>>>>> BTW this is only my opinion...
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Note that our demos are still using OpenJDK 1.7 I'm not quite
>>>>>>>>>>>>>> sure of
>>>>>>>>>>>>>> the
>>>>>>>>>>>>>> policy
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> http://www.cvedetails.com/vulnerability-list/vendor_id-93/product_id-23642/version_id-138218/Oracle-Openjdk-1.7.0.html
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Jacques
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Le 03/05/2015 10:52, Taher Alkhateeb a écrit :
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Hi everyone,
>>>>>>>>>>>>>>> I would like to work on a few JIRAs and at the same refactor
>>>>>>>>>>>>>>> some
>>>>>>>>>>>>>>> existing
>>>>>>>>>>>>>>> code to utilize Lambdas and Streams utilizing Java 8 features.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Is it acceptable to develop with JDK 8 features into trunk?
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Taher Alkhateeb
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>
>>
>
Re: Java 8 and functional programming in trunk
Posted by Jacques Le Roux <ja...@les7arts.com>.
Ha we have also Buildbot...
Le 18/10/2015 14:37, Jacques Le Roux a écrit :
> I can tweak that on the VM for now;) Doing it right now...
>
> Jacques
>
> Le 18/10/2015 12:39, Taher Alkhateeb a écrit :
>> Hi Jacques,
>>
>> Actually I think it will be required immediately because the build will fail. Below is the exact patch line in macros.xml that would fail the builds:
>>
>> + <fail unless="javaatleast18" message="Please upgrade java to at least 1.8. Current Java version is ${ant.java.version}"/>
>>
>> Taher Alkhateeb
>>
>> ----- Original Message -----
>>
>> From: "Jacques Le Roux" <ja...@les7arts.com>
>> To: dev@ofbiz.apache.org
>> Sent: Sunday, 18 October, 2015 1:36:22 PM
>> Subject: Re: Java 8 and functional programming in trunk
>>
>> Hi Taher,
>>
>> Yes I remember now, that's exactly why I was reluctant to do so. I have a message remembering me that popping everyday... for months (I have tons of
>> others :D)
>>
>> Actually it should not be a burden. I have just to upload Java 8 on the VM and set trunk to use it. it will be mandatory only when we will really
>> begin to commit Java 8 features...
>>
>> Jacques
>>
>> Le 18/10/2015 12:21, Taher Alkhateeb a écrit :
>>> Hello Everyone,
>>>
>>> I have updated the patch to upgrade to JDK 8 in JIRA https://issues.apache.org/jira/browse/OFBIZ-6458 and ran all tests and everything is okay
>>> from my side. If no one objects I will go ahead and commit this patch.
>>>
>>> Jacques, we will need your help to upgrade the CI build system for trunk to use JDK 8.
>>>
>>> Taher Alkhateeb
>>>
>>> ----- Original Message -----
>>>
>>> From: "Ron Wheeler" <rw...@artifact-software.com>
>>> To: dev@ofbiz.apache.org
>>> Sent: Wednesday, 14 October, 2015 3:40:33 PM
>>> Subject: Re: Java 8 and functional programming in trunk
>>>
>>> Good point about the backporting.
>>> This will have an effect on the enthusiasm for backporting fixes.
>>>
>>> Comparing trunk and backported code will certainly make for some good
>>> examples about how to use Java 8 to write more concise and clearer code.
>>>
>>> Ron
>>>
>>> On 14/10/2015 8:29 AM, Jacques Le Roux wrote:
>>>> Yes I think I confused myself on this one (for my defense I got a
>>>> *strong* cold recently and I'm just recovering :p)
>>>>
>>>> Inline...
>>>>
>>>> Le 14/10/2015 14:05, Ron Wheeler a écrit :
>>>>> +1 on Tahar Alkhateeb's points.
>>>>>
>>>>> I don't think that anyone is proposing to convert all existing code
>>>>> to use the latest Java 8 features.
>>>>>
>>>>> I think that once you force people to run the Java 8 JVM by doing the
>>>>> compile with Java 8, you are pretty much done.
>>>>>
>>>>> If someone adds a Stream function in their code and the code is
>>>>> validated to work correctly, that should be the end of the story.
>>>>> We don't vote on other code changes.
>>>>>
>>>>> Who is going to check new patches to ensure that they do not depend
>>>>> on Java 8 features or bugs fixed in Java 8?
>>>> As explained in my answer to Taher, we need to be sure we don't
>>>> backport Java 8 features in released branches which are supposed to
>>>> work with Java 7, that's all.
>>>>
>>>>> What was the process when Java 7 features where allowed into the
>>>>> trunk? Was a 2 part vote required?
>>>> Nope, mistake on my side
>>>>
>>>> Jacques
>>>>
>>>>> Ron
>>>>>
>>>>> On 14/10/2015 6:17 AM, Taher Alkhateeb wrote:
>>>>>> Hi Jacques,
>>>>>>
>>>>>> I am a bit confused? Why wait for a frozen branch for anything? I
>>>>>> thought trunk is your development/unstable bleeding-edge part of the
>>>>>> code. This is where you introduce changes without worrying about
>>>>>> people's stable systems because they base their systems on release
>>>>>> branches. In fact, branches exist only to stabilize trunk at certain
>>>>>> points of time.
>>>>>>
>>>>>> Furthermore, if we introduce Java 8 into trunk, what possible
>>>>>> logical reason exists for _voting_ to use the new features of the
>>>>>> language? Why did you upgrade in the first place if you do not
>>>>>> intend to use the newer features?
>>>>>>
>>>>>> Taher Alkhateeb
>>>>>>
>>>>>> ----- Original Message -----
>>>>>>
>>>>>> From: "Jacques Le Roux" <ja...@les7arts.com>
>>>>>> To: dev@ofbiz.apache.org
>>>>>> Sent: Wednesday, 14 October, 2015 12:23:31 PM
>>>>>> Subject: Re: Java 8 and functional programming in trunk
>>>>>>
>>>>>> I tend to agree. Actually there are 2 points,
>>>>>> 1) use Java 8 to compile
>>>>>> 2) use new Java 8 features
>>>>>>
>>>>>> We can already do 1, but we should maybe wait the next freezed
>>>>>> branch to do 2. That should be discussed but does not prevent 1. Of
>>>>>> course any commit
>>>>>> with 2 will be rejected as long as an agreement on 2 will not be
>>>>>> reached
>>>>>>
>>>>>> Jacques
>>>>>>
>>>>>> Le 11/10/2015 19:09, Ron Wheeler a écrit :
>>>>>>> I am not sure why backwards compatibility is an issue with moving
>>>>>>> to Java 8.
>>>>>>>
>>>>>>> It works well,
>>>>>>> it is the supported version of Java.
>>>>>>> As far as I have heard, the Java 8 JVM runs code compiled with
>>>>>>> earlier versions of Java. (My own experience is uniformly positive).
>>>>>>>
>>>>>>> I can see no reason to think that anyone who is developing or using
>>>>>>> OFBiz would need to compile or run with an older version of Java.
>>>>>>>
>>>>>>> In this day of VM and Docker Containers, it is hard to imagine that
>>>>>>> someone would be stuck on an older JVM in a production environment
>>>>>>> and unable to
>>>>>>> come up with a configuration that would allow them to run JVM 8 to
>>>>>>> support OFBiz.
>>>>>>>
>>>>>>> IMHO, we should just move to requiring the supported version of
>>>>>>> Java as soon as possible.
>>>>>>>
>>>>>>> Ron
>>>>>>>
>>>>>>>
>>>>>>> On 11/10/2015 4:14 AM, Taher Alkhateeb wrote:
>>>>>>>> Hello Everyone,
>>>>>>>>
>>>>>>>> We created and provided the patches for this issue since June and
>>>>>>>> OFBiz is pretty much ready to move to JDK 8. I'm not sure if lazy
>>>>>>>> consensus is
>>>>>>>> enough or whether a vote is warranted to move this issue forward?
>>>>>>>>
>>>>>>>> Cheers,
>>>>>>>>
>>>>>>>> Taher Alkhateeb
>>>>>>>>
>>>>>>>> ----- Original Message -----
>>>>>>>>
>>>>>>>> From: "Pierre Smits" <pi...@gmail.com>
>>>>>>>> To: dev@ofbiz.apache.org
>>>>>>>> Sent: Thursday, 7 May, 2015 10:52:00 AM
>>>>>>>> Subject: Re: Java 8 and functional programming in trunk
>>>>>>>>
>>>>>>>> I don't think that it is a question of using or not using J8. It
>>>>>>>> is more
>>>>>>>> about when to move it into trunk, as from that moment on there
>>>>>>>> will be
>>>>>>>> backward compatibility issues.
>>>>>>>> A helpful solution in this respect could be to designate a
>>>>>>>> specific release
>>>>>>>> branch now (e.g. r15 or r16), create the version in JIRA and setup
>>>>>>>> the dev
>>>>>>>> branch in svn. Doing it that way J8 related issues can get
>>>>>>>> registered,
>>>>>>>> changes can get implemented and assessed (in the dev branch) without
>>>>>>>> breaking current stuff in trunk.
>>>>>>>>
>>>>>>>> But it also ensures that we can create awareness prior to
>>>>>>>> releasing stuff.
>>>>>>>>
>>>>>>>> Best regards,
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Pierre Smits
>>>>>>>>
>>>>>>>> *ORRTIZ.COM <http://www.orrtiz.com>*
>>>>>>>> Services & Solutions for Cloud-
>>>>>>>> Based Manufacturing, Professional
>>>>>>>> Services and Retail & Trade
>>>>>>>> http://www.orrtiz.com
>>>>>>>>
>>>>>>>> On Thu, May 7, 2015 at 9:30 AM, Nicolas Malin
>>>>>>>> <ni...@nereide.fr>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Ok Thanks Scott and Jacques.
>>>>>>>>>
>>>>>>>>> So Who is against use java 8 and more on trunk ?
>>>>>>>>>
>>>>>>>>> :)
>>>>>>>>>
>>>>>>>>> Nicolas
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Le 07/05/2015 08:46, Jacques Le Roux a écrit :
>>>>>>>>>
>>>>>>>>>> Yes (lazy) consensus over vote ;)
>>>>>>>>>>
>>>>>>>>>> Jacques
>>>>>>>>>>
>>>>>>>>>> Le 07/05/2015 05:02, Scott Gray a écrit :
>>>>>>>>>>
>>>>>>>>>>> I'm not sure if a vote is necessary, particularly if no one has
>>>>>>>>>>> any
>>>>>>>>>>> objections.
>>>>>>>>>>>
>>>>>>>>>>> Regards
>>>>>>>>>>> Scott
>>>>>>>>>>> On 7 May 2015 07:44, "Nicolas Malin" <ni...@nereide.fr>
>>>>>>>>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>> I'm favorable to use java 8.
>>>>>>>>>>>> I think it's will be pretty fin if you can support oracle jdk8
>>>>>>>>>>>> and
>>>>>>>>>>>> openjdk8 also.
>>>>>>>>>>>>
>>>>>>>>>>>> I propose to organize a vote to validate or not this proposition
>>>>>>>>>>>>
>>>>>>>>>>>> Nicolas
>>>>>>>>>>>>
>>>>>>>>>>>> Le 03/05/2015 11:52, Jacques Le Roux a écrit :
>>>>>>>>>>>>
>>>>>>>>>>>> Hi Taher,
>>>>>>>>>>>>> Yes I think so. For now well known (I hope ;)) security
>>>>>>>>>>>>> reasons, if
>>>>>>>>>>>>> people want to use Oracle JDK they need to use Java 8.
>>>>>>>>>>>>> So implementing with new Java 8 features now in trunk sounds
>>>>>>>>>>>>> good to
>>>>>>>>>>>>> me.
>>>>>>>>>>>>> BTW this is only my opinion...
>>>>>>>>>>>>>
>>>>>>>>>>>>> Note that our demos are still using OpenJDK 1.7 I'm not quite
>>>>>>>>>>>>> sure of
>>>>>>>>>>>>> the
>>>>>>>>>>>>> policy
>>>>>>>>>>>>>
>>>>>>>>>>>>> http://www.cvedetails.com/vulnerability-list/vendor_id-93/product_id-23642/version_id-138218/Oracle-Openjdk-1.7.0.html
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> Jacques
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> Le 03/05/2015 10:52, Taher Alkhateeb a écrit :
>>>>>>>>>>>>>
>>>>>>>>>>>>> Hi everyone,
>>>>>>>>>>>>>> I would like to work on a few JIRAs and at the same refactor
>>>>>>>>>>>>>> some
>>>>>>>>>>>>>> existing
>>>>>>>>>>>>>> code to utilize Lambdas and Streams utilizing Java 8 features.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Is it acceptable to develop with JDK 8 features into trunk?
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Taher Alkhateeb
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>
>
Re: Java 8 and functional programming in trunk
Posted by Jacques Le Roux <ja...@les7arts.com>.
I can tweak that on the VM for now;) Doing it right now...
Jacques
Le 18/10/2015 12:39, Taher Alkhateeb a écrit :
> Hi Jacques,
>
> Actually I think it will be required immediately because the build will fail. Below is the exact patch line in macros.xml that would fail the builds:
>
> + <fail unless="javaatleast18" message="Please upgrade java to at least 1.8. Current Java version is ${ant.java.version}"/>
>
> Taher Alkhateeb
>
> ----- Original Message -----
>
> From: "Jacques Le Roux" <ja...@les7arts.com>
> To: dev@ofbiz.apache.org
> Sent: Sunday, 18 October, 2015 1:36:22 PM
> Subject: Re: Java 8 and functional programming in trunk
>
> Hi Taher,
>
> Yes I remember now, that's exactly why I was reluctant to do so. I have a message remembering me that popping everyday... for months (I have tons of
> others :D)
>
> Actually it should not be a burden. I have just to upload Java 8 on the VM and set trunk to use it. it will be mandatory only when we will really
> begin to commit Java 8 features...
>
> Jacques
>
> Le 18/10/2015 12:21, Taher Alkhateeb a écrit :
>> Hello Everyone,
>>
>> I have updated the patch to upgrade to JDK 8 in JIRA https://issues.apache.org/jira/browse/OFBIZ-6458 and ran all tests and everything is okay from my side. If no one objects I will go ahead and commit this patch.
>>
>> Jacques, we will need your help to upgrade the CI build system for trunk to use JDK 8.
>>
>> Taher Alkhateeb
>>
>> ----- Original Message -----
>>
>> From: "Ron Wheeler" <rw...@artifact-software.com>
>> To: dev@ofbiz.apache.org
>> Sent: Wednesday, 14 October, 2015 3:40:33 PM
>> Subject: Re: Java 8 and functional programming in trunk
>>
>> Good point about the backporting.
>> This will have an effect on the enthusiasm for backporting fixes.
>>
>> Comparing trunk and backported code will certainly make for some good
>> examples about how to use Java 8 to write more concise and clearer code.
>>
>> Ron
>>
>> On 14/10/2015 8:29 AM, Jacques Le Roux wrote:
>>> Yes I think I confused myself on this one (for my defense I got a
>>> *strong* cold recently and I'm just recovering :p)
>>>
>>> Inline...
>>>
>>> Le 14/10/2015 14:05, Ron Wheeler a écrit :
>>>> +1 on Tahar Alkhateeb's points.
>>>>
>>>> I don't think that anyone is proposing to convert all existing code
>>>> to use the latest Java 8 features.
>>>>
>>>> I think that once you force people to run the Java 8 JVM by doing the
>>>> compile with Java 8, you are pretty much done.
>>>>
>>>> If someone adds a Stream function in their code and the code is
>>>> validated to work correctly, that should be the end of the story.
>>>> We don't vote on other code changes.
>>>>
>>>> Who is going to check new patches to ensure that they do not depend
>>>> on Java 8 features or bugs fixed in Java 8?
>>> As explained in my answer to Taher, we need to be sure we don't
>>> backport Java 8 features in released branches which are supposed to
>>> work with Java 7, that's all.
>>>
>>>> What was the process when Java 7 features where allowed into the
>>>> trunk? Was a 2 part vote required?
>>> Nope, mistake on my side
>>>
>>> Jacques
>>>
>>>> Ron
>>>>
>>>> On 14/10/2015 6:17 AM, Taher Alkhateeb wrote:
>>>>> Hi Jacques,
>>>>>
>>>>> I am a bit confused? Why wait for a frozen branch for anything? I
>>>>> thought trunk is your development/unstable bleeding-edge part of the
>>>>> code. This is where you introduce changes without worrying about
>>>>> people's stable systems because they base their systems on release
>>>>> branches. In fact, branches exist only to stabilize trunk at certain
>>>>> points of time.
>>>>>
>>>>> Furthermore, if we introduce Java 8 into trunk, what possible
>>>>> logical reason exists for _voting_ to use the new features of the
>>>>> language? Why did you upgrade in the first place if you do not
>>>>> intend to use the newer features?
>>>>>
>>>>> Taher Alkhateeb
>>>>>
>>>>> ----- Original Message -----
>>>>>
>>>>> From: "Jacques Le Roux" <ja...@les7arts.com>
>>>>> To: dev@ofbiz.apache.org
>>>>> Sent: Wednesday, 14 October, 2015 12:23:31 PM
>>>>> Subject: Re: Java 8 and functional programming in trunk
>>>>>
>>>>> I tend to agree. Actually there are 2 points,
>>>>> 1) use Java 8 to compile
>>>>> 2) use new Java 8 features
>>>>>
>>>>> We can already do 1, but we should maybe wait the next freezed
>>>>> branch to do 2. That should be discussed but does not prevent 1. Of
>>>>> course any commit
>>>>> with 2 will be rejected as long as an agreement on 2 will not be
>>>>> reached
>>>>>
>>>>> Jacques
>>>>>
>>>>> Le 11/10/2015 19:09, Ron Wheeler a écrit :
>>>>>> I am not sure why backwards compatibility is an issue with moving
>>>>>> to Java 8.
>>>>>>
>>>>>> It works well,
>>>>>> it is the supported version of Java.
>>>>>> As far as I have heard, the Java 8 JVM runs code compiled with
>>>>>> earlier versions of Java. (My own experience is uniformly positive).
>>>>>>
>>>>>> I can see no reason to think that anyone who is developing or using
>>>>>> OFBiz would need to compile or run with an older version of Java.
>>>>>>
>>>>>> In this day of VM and Docker Containers, it is hard to imagine that
>>>>>> someone would be stuck on an older JVM in a production environment
>>>>>> and unable to
>>>>>> come up with a configuration that would allow them to run JVM 8 to
>>>>>> support OFBiz.
>>>>>>
>>>>>> IMHO, we should just move to requiring the supported version of
>>>>>> Java as soon as possible.
>>>>>>
>>>>>> Ron
>>>>>>
>>>>>>
>>>>>> On 11/10/2015 4:14 AM, Taher Alkhateeb wrote:
>>>>>>> Hello Everyone,
>>>>>>>
>>>>>>> We created and provided the patches for this issue since June and
>>>>>>> OFBiz is pretty much ready to move to JDK 8. I'm not sure if lazy
>>>>>>> consensus is
>>>>>>> enough or whether a vote is warranted to move this issue forward?
>>>>>>>
>>>>>>> Cheers,
>>>>>>>
>>>>>>> Taher Alkhateeb
>>>>>>>
>>>>>>> ----- Original Message -----
>>>>>>>
>>>>>>> From: "Pierre Smits" <pi...@gmail.com>
>>>>>>> To: dev@ofbiz.apache.org
>>>>>>> Sent: Thursday, 7 May, 2015 10:52:00 AM
>>>>>>> Subject: Re: Java 8 and functional programming in trunk
>>>>>>>
>>>>>>> I don't think that it is a question of using or not using J8. It
>>>>>>> is more
>>>>>>> about when to move it into trunk, as from that moment on there
>>>>>>> will be
>>>>>>> backward compatibility issues.
>>>>>>> A helpful solution in this respect could be to designate a
>>>>>>> specific release
>>>>>>> branch now (e.g. r15 or r16), create the version in JIRA and setup
>>>>>>> the dev
>>>>>>> branch in svn. Doing it that way J8 related issues can get
>>>>>>> registered,
>>>>>>> changes can get implemented and assessed (in the dev branch) without
>>>>>>> breaking current stuff in trunk.
>>>>>>>
>>>>>>> But it also ensures that we can create awareness prior to
>>>>>>> releasing stuff.
>>>>>>>
>>>>>>> Best regards,
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Pierre Smits
>>>>>>>
>>>>>>> *ORRTIZ.COM <http://www.orrtiz.com>*
>>>>>>> Services & Solutions for Cloud-
>>>>>>> Based Manufacturing, Professional
>>>>>>> Services and Retail & Trade
>>>>>>> http://www.orrtiz.com
>>>>>>>
>>>>>>> On Thu, May 7, 2015 at 9:30 AM, Nicolas Malin
>>>>>>> <ni...@nereide.fr>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Ok Thanks Scott and Jacques.
>>>>>>>>
>>>>>>>> So Who is against use java 8 and more on trunk ?
>>>>>>>>
>>>>>>>> :)
>>>>>>>>
>>>>>>>> Nicolas
>>>>>>>>
>>>>>>>>
>>>>>>>> Le 07/05/2015 08:46, Jacques Le Roux a écrit :
>>>>>>>>
>>>>>>>>> Yes (lazy) consensus over vote ;)
>>>>>>>>>
>>>>>>>>> Jacques
>>>>>>>>>
>>>>>>>>> Le 07/05/2015 05:02, Scott Gray a écrit :
>>>>>>>>>
>>>>>>>>>> I'm not sure if a vote is necessary, particularly if no one has
>>>>>>>>>> any
>>>>>>>>>> objections.
>>>>>>>>>>
>>>>>>>>>> Regards
>>>>>>>>>> Scott
>>>>>>>>>> On 7 May 2015 07:44, "Nicolas Malin" <ni...@nereide.fr>
>>>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>> I'm favorable to use java 8.
>>>>>>>>>>> I think it's will be pretty fin if you can support oracle jdk8
>>>>>>>>>>> and
>>>>>>>>>>> openjdk8 also.
>>>>>>>>>>>
>>>>>>>>>>> I propose to organize a vote to validate or not this proposition
>>>>>>>>>>>
>>>>>>>>>>> Nicolas
>>>>>>>>>>>
>>>>>>>>>>> Le 03/05/2015 11:52, Jacques Le Roux a écrit :
>>>>>>>>>>>
>>>>>>>>>>> Hi Taher,
>>>>>>>>>>>> Yes I think so. For now well known (I hope ;)) security
>>>>>>>>>>>> reasons, if
>>>>>>>>>>>> people want to use Oracle JDK they need to use Java 8.
>>>>>>>>>>>> So implementing with new Java 8 features now in trunk sounds
>>>>>>>>>>>> good to
>>>>>>>>>>>> me.
>>>>>>>>>>>> BTW this is only my opinion...
>>>>>>>>>>>>
>>>>>>>>>>>> Note that our demos are still using OpenJDK 1.7 I'm not quite
>>>>>>>>>>>> sure of
>>>>>>>>>>>> the
>>>>>>>>>>>> policy
>>>>>>>>>>>>
>>>>>>>>>>>> http://www.cvedetails.com/vulnerability-list/vendor_id-93/product_id-23642/version_id-138218/Oracle-Openjdk-1.7.0.html
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Jacques
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Le 03/05/2015 10:52, Taher Alkhateeb a écrit :
>>>>>>>>>>>>
>>>>>>>>>>>> Hi everyone,
>>>>>>>>>>>>> I would like to work on a few JIRAs and at the same refactor
>>>>>>>>>>>>> some
>>>>>>>>>>>>> existing
>>>>>>>>>>>>> code to utilize Lambdas and Streams utilizing Java 8 features.
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> Is it acceptable to develop with JDK 8 features into trunk?
>>>>>>>>>>>>>
>>>>>>>>>>>>> Taher Alkhateeb
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>
Re: Java 8 and functional programming in trunk
Posted by Taher Alkhateeb <sl...@gmail.com>.
Hi Jacques,
Actually I think it will be required immediately because the build will fail. Below is the exact patch line in macros.xml that would fail the builds:
+ <fail unless="javaatleast18" message="Please upgrade java to at least 1.8. Current Java version is ${ant.java.version}"/>
Taher Alkhateeb
----- Original Message -----
From: "Jacques Le Roux" <ja...@les7arts.com>
To: dev@ofbiz.apache.org
Sent: Sunday, 18 October, 2015 1:36:22 PM
Subject: Re: Java 8 and functional programming in trunk
Hi Taher,
Yes I remember now, that's exactly why I was reluctant to do so. I have a message remembering me that popping everyday... for months (I have tons of
others :D)
Actually it should not be a burden. I have just to upload Java 8 on the VM and set trunk to use it. it will be mandatory only when we will really
begin to commit Java 8 features...
Jacques
Le 18/10/2015 12:21, Taher Alkhateeb a écrit :
> Hello Everyone,
>
> I have updated the patch to upgrade to JDK 8 in JIRA https://issues.apache.org/jira/browse/OFBIZ-6458 and ran all tests and everything is okay from my side. If no one objects I will go ahead and commit this patch.
>
> Jacques, we will need your help to upgrade the CI build system for trunk to use JDK 8.
>
> Taher Alkhateeb
>
> ----- Original Message -----
>
> From: "Ron Wheeler" <rw...@artifact-software.com>
> To: dev@ofbiz.apache.org
> Sent: Wednesday, 14 October, 2015 3:40:33 PM
> Subject: Re: Java 8 and functional programming in trunk
>
> Good point about the backporting.
> This will have an effect on the enthusiasm for backporting fixes.
>
> Comparing trunk and backported code will certainly make for some good
> examples about how to use Java 8 to write more concise and clearer code.
>
> Ron
>
> On 14/10/2015 8:29 AM, Jacques Le Roux wrote:
>> Yes I think I confused myself on this one (for my defense I got a
>> *strong* cold recently and I'm just recovering :p)
>>
>> Inline...
>>
>> Le 14/10/2015 14:05, Ron Wheeler a écrit :
>>> +1 on Tahar Alkhateeb's points.
>>>
>>> I don't think that anyone is proposing to convert all existing code
>>> to use the latest Java 8 features.
>>>
>>> I think that once you force people to run the Java 8 JVM by doing the
>>> compile with Java 8, you are pretty much done.
>>>
>>> If someone adds a Stream function in their code and the code is
>>> validated to work correctly, that should be the end of the story.
>>> We don't vote on other code changes.
>>>
>>> Who is going to check new patches to ensure that they do not depend
>>> on Java 8 features or bugs fixed in Java 8?
>> As explained in my answer to Taher, we need to be sure we don't
>> backport Java 8 features in released branches which are supposed to
>> work with Java 7, that's all.
>>
>>> What was the process when Java 7 features where allowed into the
>>> trunk? Was a 2 part vote required?
>> Nope, mistake on my side
>>
>> Jacques
>>
>>> Ron
>>>
>>> On 14/10/2015 6:17 AM, Taher Alkhateeb wrote:
>>>> Hi Jacques,
>>>>
>>>> I am a bit confused? Why wait for a frozen branch for anything? I
>>>> thought trunk is your development/unstable bleeding-edge part of the
>>>> code. This is where you introduce changes without worrying about
>>>> people's stable systems because they base their systems on release
>>>> branches. In fact, branches exist only to stabilize trunk at certain
>>>> points of time.
>>>>
>>>> Furthermore, if we introduce Java 8 into trunk, what possible
>>>> logical reason exists for _voting_ to use the new features of the
>>>> language? Why did you upgrade in the first place if you do not
>>>> intend to use the newer features?
>>>>
>>>> Taher Alkhateeb
>>>>
>>>> ----- Original Message -----
>>>>
>>>> From: "Jacques Le Roux" <ja...@les7arts.com>
>>>> To: dev@ofbiz.apache.org
>>>> Sent: Wednesday, 14 October, 2015 12:23:31 PM
>>>> Subject: Re: Java 8 and functional programming in trunk
>>>>
>>>> I tend to agree. Actually there are 2 points,
>>>> 1) use Java 8 to compile
>>>> 2) use new Java 8 features
>>>>
>>>> We can already do 1, but we should maybe wait the next freezed
>>>> branch to do 2. That should be discussed but does not prevent 1. Of
>>>> course any commit
>>>> with 2 will be rejected as long as an agreement on 2 will not be
>>>> reached
>>>>
>>>> Jacques
>>>>
>>>> Le 11/10/2015 19:09, Ron Wheeler a écrit :
>>>>> I am not sure why backwards compatibility is an issue with moving
>>>>> to Java 8.
>>>>>
>>>>> It works well,
>>>>> it is the supported version of Java.
>>>>> As far as I have heard, the Java 8 JVM runs code compiled with
>>>>> earlier versions of Java. (My own experience is uniformly positive).
>>>>>
>>>>> I can see no reason to think that anyone who is developing or using
>>>>> OFBiz would need to compile or run with an older version of Java.
>>>>>
>>>>> In this day of VM and Docker Containers, it is hard to imagine that
>>>>> someone would be stuck on an older JVM in a production environment
>>>>> and unable to
>>>>> come up with a configuration that would allow them to run JVM 8 to
>>>>> support OFBiz.
>>>>>
>>>>> IMHO, we should just move to requiring the supported version of
>>>>> Java as soon as possible.
>>>>>
>>>>> Ron
>>>>>
>>>>>
>>>>> On 11/10/2015 4:14 AM, Taher Alkhateeb wrote:
>>>>>> Hello Everyone,
>>>>>>
>>>>>> We created and provided the patches for this issue since June and
>>>>>> OFBiz is pretty much ready to move to JDK 8. I'm not sure if lazy
>>>>>> consensus is
>>>>>> enough or whether a vote is warranted to move this issue forward?
>>>>>>
>>>>>> Cheers,
>>>>>>
>>>>>> Taher Alkhateeb
>>>>>>
>>>>>> ----- Original Message -----
>>>>>>
>>>>>> From: "Pierre Smits" <pi...@gmail.com>
>>>>>> To: dev@ofbiz.apache.org
>>>>>> Sent: Thursday, 7 May, 2015 10:52:00 AM
>>>>>> Subject: Re: Java 8 and functional programming in trunk
>>>>>>
>>>>>> I don't think that it is a question of using or not using J8. It
>>>>>> is more
>>>>>> about when to move it into trunk, as from that moment on there
>>>>>> will be
>>>>>> backward compatibility issues.
>>>>>> A helpful solution in this respect could be to designate a
>>>>>> specific release
>>>>>> branch now (e.g. r15 or r16), create the version in JIRA and setup
>>>>>> the dev
>>>>>> branch in svn. Doing it that way J8 related issues can get
>>>>>> registered,
>>>>>> changes can get implemented and assessed (in the dev branch) without
>>>>>> breaking current stuff in trunk.
>>>>>>
>>>>>> But it also ensures that we can create awareness prior to
>>>>>> releasing stuff.
>>>>>>
>>>>>> Best regards,
>>>>>>
>>>>>>
>>>>>>
>>>>>> Pierre Smits
>>>>>>
>>>>>> *ORRTIZ.COM <http://www.orrtiz.com>*
>>>>>> Services & Solutions for Cloud-
>>>>>> Based Manufacturing, Professional
>>>>>> Services and Retail & Trade
>>>>>> http://www.orrtiz.com
>>>>>>
>>>>>> On Thu, May 7, 2015 at 9:30 AM, Nicolas Malin
>>>>>> <ni...@nereide.fr>
>>>>>> wrote:
>>>>>>
>>>>>>> Ok Thanks Scott and Jacques.
>>>>>>>
>>>>>>> So Who is against use java 8 and more on trunk ?
>>>>>>>
>>>>>>> :)
>>>>>>>
>>>>>>> Nicolas
>>>>>>>
>>>>>>>
>>>>>>> Le 07/05/2015 08:46, Jacques Le Roux a écrit :
>>>>>>>
>>>>>>>> Yes (lazy) consensus over vote ;)
>>>>>>>>
>>>>>>>> Jacques
>>>>>>>>
>>>>>>>> Le 07/05/2015 05:02, Scott Gray a écrit :
>>>>>>>>
>>>>>>>>> I'm not sure if a vote is necessary, particularly if no one has
>>>>>>>>> any
>>>>>>>>> objections.
>>>>>>>>>
>>>>>>>>> Regards
>>>>>>>>> Scott
>>>>>>>>> On 7 May 2015 07:44, "Nicolas Malin" <ni...@nereide.fr>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>> I'm favorable to use java 8.
>>>>>>>>>> I think it's will be pretty fin if you can support oracle jdk8
>>>>>>>>>> and
>>>>>>>>>> openjdk8 also.
>>>>>>>>>>
>>>>>>>>>> I propose to organize a vote to validate or not this proposition
>>>>>>>>>>
>>>>>>>>>> Nicolas
>>>>>>>>>>
>>>>>>>>>> Le 03/05/2015 11:52, Jacques Le Roux a écrit :
>>>>>>>>>>
>>>>>>>>>> Hi Taher,
>>>>>>>>>>> Yes I think so. For now well known (I hope ;)) security
>>>>>>>>>>> reasons, if
>>>>>>>>>>> people want to use Oracle JDK they need to use Java 8.
>>>>>>>>>>> So implementing with new Java 8 features now in trunk sounds
>>>>>>>>>>> good to
>>>>>>>>>>> me.
>>>>>>>>>>> BTW this is only my opinion...
>>>>>>>>>>>
>>>>>>>>>>> Note that our demos are still using OpenJDK 1.7 I'm not quite
>>>>>>>>>>> sure of
>>>>>>>>>>> the
>>>>>>>>>>> policy
>>>>>>>>>>>
>>>>>>>>>>> http://www.cvedetails.com/vulnerability-list/vendor_id-93/product_id-23642/version_id-138218/Oracle-Openjdk-1.7.0.html
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Jacques
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Le 03/05/2015 10:52, Taher Alkhateeb a écrit :
>>>>>>>>>>>
>>>>>>>>>>> Hi everyone,
>>>>>>>>>>>> I would like to work on a few JIRAs and at the same refactor
>>>>>>>>>>>> some
>>>>>>>>>>>> existing
>>>>>>>>>>>> code to utilize Lambdas and Streams utilizing Java 8 features.
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Is it acceptable to develop with JDK 8 features into trunk?
>>>>>>>>>>>>
>>>>>>>>>>>> Taher Alkhateeb
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>
>
Re: Java 8 and functional programming in trunk
Posted by Jacques Le Roux <ja...@les7arts.com>.
Hi Taher,
Yes I remember now, that's exactly why I was reluctant to do so. I have a message remembering me that popping everyday... for months (I have tons of
others :D)
Actually it should not be a burden. I have just to upload Java 8 on the VM and set trunk to use it. it will be mandatory only when we will really
begin to commit Java 8 features...
Jacques
Le 18/10/2015 12:21, Taher Alkhateeb a écrit :
> Hello Everyone,
>
> I have updated the patch to upgrade to JDK 8 in JIRA https://issues.apache.org/jira/browse/OFBIZ-6458 and ran all tests and everything is okay from my side. If no one objects I will go ahead and commit this patch.
>
> Jacques, we will need your help to upgrade the CI build system for trunk to use JDK 8.
>
> Taher Alkhateeb
>
> ----- Original Message -----
>
> From: "Ron Wheeler" <rw...@artifact-software.com>
> To: dev@ofbiz.apache.org
> Sent: Wednesday, 14 October, 2015 3:40:33 PM
> Subject: Re: Java 8 and functional programming in trunk
>
> Good point about the backporting.
> This will have an effect on the enthusiasm for backporting fixes.
>
> Comparing trunk and backported code will certainly make for some good
> examples about how to use Java 8 to write more concise and clearer code.
>
> Ron
>
> On 14/10/2015 8:29 AM, Jacques Le Roux wrote:
>> Yes I think I confused myself on this one (for my defense I got a
>> *strong* cold recently and I'm just recovering :p)
>>
>> Inline...
>>
>> Le 14/10/2015 14:05, Ron Wheeler a écrit :
>>> +1 on Tahar Alkhateeb's points.
>>>
>>> I don't think that anyone is proposing to convert all existing code
>>> to use the latest Java 8 features.
>>>
>>> I think that once you force people to run the Java 8 JVM by doing the
>>> compile with Java 8, you are pretty much done.
>>>
>>> If someone adds a Stream function in their code and the code is
>>> validated to work correctly, that should be the end of the story.
>>> We don't vote on other code changes.
>>>
>>> Who is going to check new patches to ensure that they do not depend
>>> on Java 8 features or bugs fixed in Java 8?
>> As explained in my answer to Taher, we need to be sure we don't
>> backport Java 8 features in released branches which are supposed to
>> work with Java 7, that's all.
>>
>>> What was the process when Java 7 features where allowed into the
>>> trunk? Was a 2 part vote required?
>> Nope, mistake on my side
>>
>> Jacques
>>
>>> Ron
>>>
>>> On 14/10/2015 6:17 AM, Taher Alkhateeb wrote:
>>>> Hi Jacques,
>>>>
>>>> I am a bit confused? Why wait for a frozen branch for anything? I
>>>> thought trunk is your development/unstable bleeding-edge part of the
>>>> code. This is where you introduce changes without worrying about
>>>> people's stable systems because they base their systems on release
>>>> branches. In fact, branches exist only to stabilize trunk at certain
>>>> points of time.
>>>>
>>>> Furthermore, if we introduce Java 8 into trunk, what possible
>>>> logical reason exists for _voting_ to use the new features of the
>>>> language? Why did you upgrade in the first place if you do not
>>>> intend to use the newer features?
>>>>
>>>> Taher Alkhateeb
>>>>
>>>> ----- Original Message -----
>>>>
>>>> From: "Jacques Le Roux" <ja...@les7arts.com>
>>>> To: dev@ofbiz.apache.org
>>>> Sent: Wednesday, 14 October, 2015 12:23:31 PM
>>>> Subject: Re: Java 8 and functional programming in trunk
>>>>
>>>> I tend to agree. Actually there are 2 points,
>>>> 1) use Java 8 to compile
>>>> 2) use new Java 8 features
>>>>
>>>> We can already do 1, but we should maybe wait the next freezed
>>>> branch to do 2. That should be discussed but does not prevent 1. Of
>>>> course any commit
>>>> with 2 will be rejected as long as an agreement on 2 will not be
>>>> reached
>>>>
>>>> Jacques
>>>>
>>>> Le 11/10/2015 19:09, Ron Wheeler a écrit :
>>>>> I am not sure why backwards compatibility is an issue with moving
>>>>> to Java 8.
>>>>>
>>>>> It works well,
>>>>> it is the supported version of Java.
>>>>> As far as I have heard, the Java 8 JVM runs code compiled with
>>>>> earlier versions of Java. (My own experience is uniformly positive).
>>>>>
>>>>> I can see no reason to think that anyone who is developing or using
>>>>> OFBiz would need to compile or run with an older version of Java.
>>>>>
>>>>> In this day of VM and Docker Containers, it is hard to imagine that
>>>>> someone would be stuck on an older JVM in a production environment
>>>>> and unable to
>>>>> come up with a configuration that would allow them to run JVM 8 to
>>>>> support OFBiz.
>>>>>
>>>>> IMHO, we should just move to requiring the supported version of
>>>>> Java as soon as possible.
>>>>>
>>>>> Ron
>>>>>
>>>>>
>>>>> On 11/10/2015 4:14 AM, Taher Alkhateeb wrote:
>>>>>> Hello Everyone,
>>>>>>
>>>>>> We created and provided the patches for this issue since June and
>>>>>> OFBiz is pretty much ready to move to JDK 8. I'm not sure if lazy
>>>>>> consensus is
>>>>>> enough or whether a vote is warranted to move this issue forward?
>>>>>>
>>>>>> Cheers,
>>>>>>
>>>>>> Taher Alkhateeb
>>>>>>
>>>>>> ----- Original Message -----
>>>>>>
>>>>>> From: "Pierre Smits" <pi...@gmail.com>
>>>>>> To: dev@ofbiz.apache.org
>>>>>> Sent: Thursday, 7 May, 2015 10:52:00 AM
>>>>>> Subject: Re: Java 8 and functional programming in trunk
>>>>>>
>>>>>> I don't think that it is a question of using or not using J8. It
>>>>>> is more
>>>>>> about when to move it into trunk, as from that moment on there
>>>>>> will be
>>>>>> backward compatibility issues.
>>>>>> A helpful solution in this respect could be to designate a
>>>>>> specific release
>>>>>> branch now (e.g. r15 or r16), create the version in JIRA and setup
>>>>>> the dev
>>>>>> branch in svn. Doing it that way J8 related issues can get
>>>>>> registered,
>>>>>> changes can get implemented and assessed (in the dev branch) without
>>>>>> breaking current stuff in trunk.
>>>>>>
>>>>>> But it also ensures that we can create awareness prior to
>>>>>> releasing stuff.
>>>>>>
>>>>>> Best regards,
>>>>>>
>>>>>>
>>>>>>
>>>>>> Pierre Smits
>>>>>>
>>>>>> *ORRTIZ.COM <http://www.orrtiz.com>*
>>>>>> Services & Solutions for Cloud-
>>>>>> Based Manufacturing, Professional
>>>>>> Services and Retail & Trade
>>>>>> http://www.orrtiz.com
>>>>>>
>>>>>> On Thu, May 7, 2015 at 9:30 AM, Nicolas Malin
>>>>>> <ni...@nereide.fr>
>>>>>> wrote:
>>>>>>
>>>>>>> Ok Thanks Scott and Jacques.
>>>>>>>
>>>>>>> So Who is against use java 8 and more on trunk ?
>>>>>>>
>>>>>>> :)
>>>>>>>
>>>>>>> Nicolas
>>>>>>>
>>>>>>>
>>>>>>> Le 07/05/2015 08:46, Jacques Le Roux a écrit :
>>>>>>>
>>>>>>>> Yes (lazy) consensus over vote ;)
>>>>>>>>
>>>>>>>> Jacques
>>>>>>>>
>>>>>>>> Le 07/05/2015 05:02, Scott Gray a écrit :
>>>>>>>>
>>>>>>>>> I'm not sure if a vote is necessary, particularly if no one has
>>>>>>>>> any
>>>>>>>>> objections.
>>>>>>>>>
>>>>>>>>> Regards
>>>>>>>>> Scott
>>>>>>>>> On 7 May 2015 07:44, "Nicolas Malin" <ni...@nereide.fr>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>> I'm favorable to use java 8.
>>>>>>>>>> I think it's will be pretty fin if you can support oracle jdk8
>>>>>>>>>> and
>>>>>>>>>> openjdk8 also.
>>>>>>>>>>
>>>>>>>>>> I propose to organize a vote to validate or not this proposition
>>>>>>>>>>
>>>>>>>>>> Nicolas
>>>>>>>>>>
>>>>>>>>>> Le 03/05/2015 11:52, Jacques Le Roux a écrit :
>>>>>>>>>>
>>>>>>>>>> Hi Taher,
>>>>>>>>>>> Yes I think so. For now well known (I hope ;)) security
>>>>>>>>>>> reasons, if
>>>>>>>>>>> people want to use Oracle JDK they need to use Java 8.
>>>>>>>>>>> So implementing with new Java 8 features now in trunk sounds
>>>>>>>>>>> good to
>>>>>>>>>>> me.
>>>>>>>>>>> BTW this is only my opinion...
>>>>>>>>>>>
>>>>>>>>>>> Note that our demos are still using OpenJDK 1.7 I'm not quite
>>>>>>>>>>> sure of
>>>>>>>>>>> the
>>>>>>>>>>> policy
>>>>>>>>>>>
>>>>>>>>>>> http://www.cvedetails.com/vulnerability-list/vendor_id-93/product_id-23642/version_id-138218/Oracle-Openjdk-1.7.0.html
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Jacques
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Le 03/05/2015 10:52, Taher Alkhateeb a écrit :
>>>>>>>>>>>
>>>>>>>>>>> Hi everyone,
>>>>>>>>>>>> I would like to work on a few JIRAs and at the same refactor
>>>>>>>>>>>> some
>>>>>>>>>>>> existing
>>>>>>>>>>>> code to utilize Lambdas and Streams utilizing Java 8 features.
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Is it acceptable to develop with JDK 8 features into trunk?
>>>>>>>>>>>>
>>>>>>>>>>>> Taher Alkhateeb
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>
>
Re: Java 8 and functional programming in trunk
Posted by Taher Alkhateeb <sl...@gmail.com>.
Hello Everyone,
I have updated the patch to upgrade to JDK 8 in JIRA https://issues.apache.org/jira/browse/OFBIZ-6458 and ran all tests and everything is okay from my side. If no one objects I will go ahead and commit this patch.
Jacques, we will need your help to upgrade the CI build system for trunk to use JDK 8.
Taher Alkhateeb
----- Original Message -----
From: "Ron Wheeler" <rw...@artifact-software.com>
To: dev@ofbiz.apache.org
Sent: Wednesday, 14 October, 2015 3:40:33 PM
Subject: Re: Java 8 and functional programming in trunk
Good point about the backporting.
This will have an effect on the enthusiasm for backporting fixes.
Comparing trunk and backported code will certainly make for some good
examples about how to use Java 8 to write more concise and clearer code.
Ron
On 14/10/2015 8:29 AM, Jacques Le Roux wrote:
> Yes I think I confused myself on this one (for my defense I got a
> *strong* cold recently and I'm just recovering :p)
>
> Inline...
>
> Le 14/10/2015 14:05, Ron Wheeler a écrit :
>> +1 on Tahar Alkhateeb's points.
>>
>> I don't think that anyone is proposing to convert all existing code
>> to use the latest Java 8 features.
>>
>> I think that once you force people to run the Java 8 JVM by doing the
>> compile with Java 8, you are pretty much done.
>>
>> If someone adds a Stream function in their code and the code is
>> validated to work correctly, that should be the end of the story.
>> We don't vote on other code changes.
>>
>> Who is going to check new patches to ensure that they do not depend
>> on Java 8 features or bugs fixed in Java 8?
>
> As explained in my answer to Taher, we need to be sure we don't
> backport Java 8 features in released branches which are supposed to
> work with Java 7, that's all.
>
>>
>> What was the process when Java 7 features where allowed into the
>> trunk? Was a 2 part vote required?
>
> Nope, mistake on my side
>
> Jacques
>
>>
>> Ron
>>
>> On 14/10/2015 6:17 AM, Taher Alkhateeb wrote:
>>> Hi Jacques,
>>>
>>> I am a bit confused? Why wait for a frozen branch for anything? I
>>> thought trunk is your development/unstable bleeding-edge part of the
>>> code. This is where you introduce changes without worrying about
>>> people's stable systems because they base their systems on release
>>> branches. In fact, branches exist only to stabilize trunk at certain
>>> points of time.
>>>
>>> Furthermore, if we introduce Java 8 into trunk, what possible
>>> logical reason exists for _voting_ to use the new features of the
>>> language? Why did you upgrade in the first place if you do not
>>> intend to use the newer features?
>>>
>>> Taher Alkhateeb
>>>
>>> ----- Original Message -----
>>>
>>> From: "Jacques Le Roux" <ja...@les7arts.com>
>>> To: dev@ofbiz.apache.org
>>> Sent: Wednesday, 14 October, 2015 12:23:31 PM
>>> Subject: Re: Java 8 and functional programming in trunk
>>>
>>> I tend to agree. Actually there are 2 points,
>>> 1) use Java 8 to compile
>>> 2) use new Java 8 features
>>>
>>> We can already do 1, but we should maybe wait the next freezed
>>> branch to do 2. That should be discussed but does not prevent 1. Of
>>> course any commit
>>> with 2 will be rejected as long as an agreement on 2 will not be
>>> reached
>>>
>>> Jacques
>>>
>>> Le 11/10/2015 19:09, Ron Wheeler a écrit :
>>>> I am not sure why backwards compatibility is an issue with moving
>>>> to Java 8.
>>>>
>>>> It works well,
>>>> it is the supported version of Java.
>>>> As far as I have heard, the Java 8 JVM runs code compiled with
>>>> earlier versions of Java. (My own experience is uniformly positive).
>>>>
>>>> I can see no reason to think that anyone who is developing or using
>>>> OFBiz would need to compile or run with an older version of Java.
>>>>
>>>> In this day of VM and Docker Containers, it is hard to imagine that
>>>> someone would be stuck on an older JVM in a production environment
>>>> and unable to
>>>> come up with a configuration that would allow them to run JVM 8 to
>>>> support OFBiz.
>>>>
>>>> IMHO, we should just move to requiring the supported version of
>>>> Java as soon as possible.
>>>>
>>>> Ron
>>>>
>>>>
>>>> On 11/10/2015 4:14 AM, Taher Alkhateeb wrote:
>>>>> Hello Everyone,
>>>>>
>>>>> We created and provided the patches for this issue since June and
>>>>> OFBiz is pretty much ready to move to JDK 8. I'm not sure if lazy
>>>>> consensus is
>>>>> enough or whether a vote is warranted to move this issue forward?
>>>>>
>>>>> Cheers,
>>>>>
>>>>> Taher Alkhateeb
>>>>>
>>>>> ----- Original Message -----
>>>>>
>>>>> From: "Pierre Smits" <pi...@gmail.com>
>>>>> To: dev@ofbiz.apache.org
>>>>> Sent: Thursday, 7 May, 2015 10:52:00 AM
>>>>> Subject: Re: Java 8 and functional programming in trunk
>>>>>
>>>>> I don't think that it is a question of using or not using J8. It
>>>>> is more
>>>>> about when to move it into trunk, as from that moment on there
>>>>> will be
>>>>> backward compatibility issues.
>>>>> A helpful solution in this respect could be to designate a
>>>>> specific release
>>>>> branch now (e.g. r15 or r16), create the version in JIRA and setup
>>>>> the dev
>>>>> branch in svn. Doing it that way J8 related issues can get
>>>>> registered,
>>>>> changes can get implemented and assessed (in the dev branch) without
>>>>> breaking current stuff in trunk.
>>>>>
>>>>> But it also ensures that we can create awareness prior to
>>>>> releasing stuff.
>>>>>
>>>>> Best regards,
>>>>>
>>>>>
>>>>>
>>>>> Pierre Smits
>>>>>
>>>>> *ORRTIZ.COM <http://www.orrtiz.com>*
>>>>> Services & Solutions for Cloud-
>>>>> Based Manufacturing, Professional
>>>>> Services and Retail & Trade
>>>>> http://www.orrtiz.com
>>>>>
>>>>> On Thu, May 7, 2015 at 9:30 AM, Nicolas Malin
>>>>> <ni...@nereide.fr>
>>>>> wrote:
>>>>>
>>>>>> Ok Thanks Scott and Jacques.
>>>>>>
>>>>>> So Who is against use java 8 and more on trunk ?
>>>>>>
>>>>>> :)
>>>>>>
>>>>>> Nicolas
>>>>>>
>>>>>>
>>>>>> Le 07/05/2015 08:46, Jacques Le Roux a écrit :
>>>>>>
>>>>>>> Yes (lazy) consensus over vote ;)
>>>>>>>
>>>>>>> Jacques
>>>>>>>
>>>>>>> Le 07/05/2015 05:02, Scott Gray a écrit :
>>>>>>>
>>>>>>>> I'm not sure if a vote is necessary, particularly if no one has
>>>>>>>> any
>>>>>>>> objections.
>>>>>>>>
>>>>>>>> Regards
>>>>>>>> Scott
>>>>>>>> On 7 May 2015 07:44, "Nicolas Malin" <ni...@nereide.fr>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>> I'm favorable to use java 8.
>>>>>>>>> I think it's will be pretty fin if you can support oracle jdk8
>>>>>>>>> and
>>>>>>>>> openjdk8 also.
>>>>>>>>>
>>>>>>>>> I propose to organize a vote to validate or not this proposition
>>>>>>>>>
>>>>>>>>> Nicolas
>>>>>>>>>
>>>>>>>>> Le 03/05/2015 11:52, Jacques Le Roux a écrit :
>>>>>>>>>
>>>>>>>>> Hi Taher,
>>>>>>>>>> Yes I think so. For now well known (I hope ;)) security
>>>>>>>>>> reasons, if
>>>>>>>>>> people want to use Oracle JDK they need to use Java 8.
>>>>>>>>>> So implementing with new Java 8 features now in trunk sounds
>>>>>>>>>> good to
>>>>>>>>>> me.
>>>>>>>>>> BTW this is only my opinion...
>>>>>>>>>>
>>>>>>>>>> Note that our demos are still using OpenJDK 1.7 I'm not quite
>>>>>>>>>> sure of
>>>>>>>>>> the
>>>>>>>>>> policy
>>>>>>>>>>
>>>>>>>>>> http://www.cvedetails.com/vulnerability-list/vendor_id-93/product_id-23642/version_id-138218/Oracle-Openjdk-1.7.0.html
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Jacques
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Le 03/05/2015 10:52, Taher Alkhateeb a écrit :
>>>>>>>>>>
>>>>>>>>>> Hi everyone,
>>>>>>>>>>> I would like to work on a few JIRAs and at the same refactor
>>>>>>>>>>> some
>>>>>>>>>>> existing
>>>>>>>>>>> code to utilize Lambdas and Streams utilizing Java 8 features.
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Is it acceptable to develop with JDK 8 features into trunk?
>>>>>>>>>>>
>>>>>>>>>>> Taher Alkhateeb
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>
>>>
>>
>>
>
--
Ron Wheeler
President
Artifact Software Inc
email: rwheeler@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102
Re: Java 8 and functional programming in trunk
Posted by Ron Wheeler <rw...@artifact-software.com>.
Good point about the backporting.
This will have an effect on the enthusiasm for backporting fixes.
Comparing trunk and backported code will certainly make for some good
examples about how to use Java 8 to write more concise and clearer code.
Ron
On 14/10/2015 8:29 AM, Jacques Le Roux wrote:
> Yes I think I confused myself on this one (for my defense I got a
> *strong* cold recently and I'm just recovering :p)
>
> Inline...
>
> Le 14/10/2015 14:05, Ron Wheeler a écrit :
>> +1 on Tahar Alkhateeb's points.
>>
>> I don't think that anyone is proposing to convert all existing code
>> to use the latest Java 8 features.
>>
>> I think that once you force people to run the Java 8 JVM by doing the
>> compile with Java 8, you are pretty much done.
>>
>> If someone adds a Stream function in their code and the code is
>> validated to work correctly, that should be the end of the story.
>> We don't vote on other code changes.
>>
>> Who is going to check new patches to ensure that they do not depend
>> on Java 8 features or bugs fixed in Java 8?
>
> As explained in my answer to Taher, we need to be sure we don't
> backport Java 8 features in released branches which are supposed to
> work with Java 7, that's all.
>
>>
>> What was the process when Java 7 features where allowed into the
>> trunk? Was a 2 part vote required?
>
> Nope, mistake on my side
>
> Jacques
>
>>
>> Ron
>>
>> On 14/10/2015 6:17 AM, Taher Alkhateeb wrote:
>>> Hi Jacques,
>>>
>>> I am a bit confused? Why wait for a frozen branch for anything? I
>>> thought trunk is your development/unstable bleeding-edge part of the
>>> code. This is where you introduce changes without worrying about
>>> people's stable systems because they base their systems on release
>>> branches. In fact, branches exist only to stabilize trunk at certain
>>> points of time.
>>>
>>> Furthermore, if we introduce Java 8 into trunk, what possible
>>> logical reason exists for _voting_ to use the new features of the
>>> language? Why did you upgrade in the first place if you do not
>>> intend to use the newer features?
>>>
>>> Taher Alkhateeb
>>>
>>> ----- Original Message -----
>>>
>>> From: "Jacques Le Roux" <ja...@les7arts.com>
>>> To: dev@ofbiz.apache.org
>>> Sent: Wednesday, 14 October, 2015 12:23:31 PM
>>> Subject: Re: Java 8 and functional programming in trunk
>>>
>>> I tend to agree. Actually there are 2 points,
>>> 1) use Java 8 to compile
>>> 2) use new Java 8 features
>>>
>>> We can already do 1, but we should maybe wait the next freezed
>>> branch to do 2. That should be discussed but does not prevent 1. Of
>>> course any commit
>>> with 2 will be rejected as long as an agreement on 2 will not be
>>> reached
>>>
>>> Jacques
>>>
>>> Le 11/10/2015 19:09, Ron Wheeler a écrit :
>>>> I am not sure why backwards compatibility is an issue with moving
>>>> to Java 8.
>>>>
>>>> It works well,
>>>> it is the supported version of Java.
>>>> As far as I have heard, the Java 8 JVM runs code compiled with
>>>> earlier versions of Java. (My own experience is uniformly positive).
>>>>
>>>> I can see no reason to think that anyone who is developing or using
>>>> OFBiz would need to compile or run with an older version of Java.
>>>>
>>>> In this day of VM and Docker Containers, it is hard to imagine that
>>>> someone would be stuck on an older JVM in a production environment
>>>> and unable to
>>>> come up with a configuration that would allow them to run JVM 8 to
>>>> support OFBiz.
>>>>
>>>> IMHO, we should just move to requiring the supported version of
>>>> Java as soon as possible.
>>>>
>>>> Ron
>>>>
>>>>
>>>> On 11/10/2015 4:14 AM, Taher Alkhateeb wrote:
>>>>> Hello Everyone,
>>>>>
>>>>> We created and provided the patches for this issue since June and
>>>>> OFBiz is pretty much ready to move to JDK 8. I'm not sure if lazy
>>>>> consensus is
>>>>> enough or whether a vote is warranted to move this issue forward?
>>>>>
>>>>> Cheers,
>>>>>
>>>>> Taher Alkhateeb
>>>>>
>>>>> ----- Original Message -----
>>>>>
>>>>> From: "Pierre Smits" <pi...@gmail.com>
>>>>> To: dev@ofbiz.apache.org
>>>>> Sent: Thursday, 7 May, 2015 10:52:00 AM
>>>>> Subject: Re: Java 8 and functional programming in trunk
>>>>>
>>>>> I don't think that it is a question of using or not using J8. It
>>>>> is more
>>>>> about when to move it into trunk, as from that moment on there
>>>>> will be
>>>>> backward compatibility issues.
>>>>> A helpful solution in this respect could be to designate a
>>>>> specific release
>>>>> branch now (e.g. r15 or r16), create the version in JIRA and setup
>>>>> the dev
>>>>> branch in svn. Doing it that way J8 related issues can get
>>>>> registered,
>>>>> changes can get implemented and assessed (in the dev branch) without
>>>>> breaking current stuff in trunk.
>>>>>
>>>>> But it also ensures that we can create awareness prior to
>>>>> releasing stuff.
>>>>>
>>>>> Best regards,
>>>>>
>>>>>
>>>>>
>>>>> Pierre Smits
>>>>>
>>>>> *ORRTIZ.COM <http://www.orrtiz.com>*
>>>>> Services & Solutions for Cloud-
>>>>> Based Manufacturing, Professional
>>>>> Services and Retail & Trade
>>>>> http://www.orrtiz.com
>>>>>
>>>>> On Thu, May 7, 2015 at 9:30 AM, Nicolas Malin
>>>>> <ni...@nereide.fr>
>>>>> wrote:
>>>>>
>>>>>> Ok Thanks Scott and Jacques.
>>>>>>
>>>>>> So Who is against use java 8 and more on trunk ?
>>>>>>
>>>>>> :)
>>>>>>
>>>>>> Nicolas
>>>>>>
>>>>>>
>>>>>> Le 07/05/2015 08:46, Jacques Le Roux a écrit :
>>>>>>
>>>>>>> Yes (lazy) consensus over vote ;)
>>>>>>>
>>>>>>> Jacques
>>>>>>>
>>>>>>> Le 07/05/2015 05:02, Scott Gray a écrit :
>>>>>>>
>>>>>>>> I'm not sure if a vote is necessary, particularly if no one has
>>>>>>>> any
>>>>>>>> objections.
>>>>>>>>
>>>>>>>> Regards
>>>>>>>> Scott
>>>>>>>> On 7 May 2015 07:44, "Nicolas Malin" <ni...@nereide.fr>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>> I'm favorable to use java 8.
>>>>>>>>> I think it's will be pretty fin if you can support oracle jdk8
>>>>>>>>> and
>>>>>>>>> openjdk8 also.
>>>>>>>>>
>>>>>>>>> I propose to organize a vote to validate or not this proposition
>>>>>>>>>
>>>>>>>>> Nicolas
>>>>>>>>>
>>>>>>>>> Le 03/05/2015 11:52, Jacques Le Roux a écrit :
>>>>>>>>>
>>>>>>>>> Hi Taher,
>>>>>>>>>> Yes I think so. For now well known (I hope ;)) security
>>>>>>>>>> reasons, if
>>>>>>>>>> people want to use Oracle JDK they need to use Java 8.
>>>>>>>>>> So implementing with new Java 8 features now in trunk sounds
>>>>>>>>>> good to
>>>>>>>>>> me.
>>>>>>>>>> BTW this is only my opinion...
>>>>>>>>>>
>>>>>>>>>> Note that our demos are still using OpenJDK 1.7 I'm not quite
>>>>>>>>>> sure of
>>>>>>>>>> the
>>>>>>>>>> policy
>>>>>>>>>>
>>>>>>>>>> http://www.cvedetails.com/vulnerability-list/vendor_id-93/product_id-23642/version_id-138218/Oracle-Openjdk-1.7.0.html
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Jacques
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Le 03/05/2015 10:52, Taher Alkhateeb a écrit :
>>>>>>>>>>
>>>>>>>>>> Hi everyone,
>>>>>>>>>>> I would like to work on a few JIRAs and at the same refactor
>>>>>>>>>>> some
>>>>>>>>>>> existing
>>>>>>>>>>> code to utilize Lambdas and Streams utilizing Java 8 features.
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Is it acceptable to develop with JDK 8 features into trunk?
>>>>>>>>>>>
>>>>>>>>>>> Taher Alkhateeb
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>
>>>
>>
>>
>
--
Ron Wheeler
President
Artifact Software Inc
email: rwheeler@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102
Re: Java 8 and functional programming in trunk
Posted by Jacques Le Roux <ja...@les7arts.com>.
Yes I think I confused myself on this one (for my defense I got a *strong* cold recently and I'm just recovering :p)
Inline...
Le 14/10/2015 14:05, Ron Wheeler a écrit :
> +1 on Tahar Alkhateeb's points.
>
> I don't think that anyone is proposing to convert all existing code to use the latest Java 8 features.
>
> I think that once you force people to run the Java 8 JVM by doing the compile with Java 8, you are pretty much done.
>
> If someone adds a Stream function in their code and the code is validated to work correctly, that should be the end of the story.
> We don't vote on other code changes.
>
> Who is going to check new patches to ensure that they do not depend on Java 8 features or bugs fixed in Java 8?
As explained in my answer to Taher, we need to be sure we don't backport Java 8 features in released branches which are supposed to work with Java 7,
that's all.
>
> What was the process when Java 7 features where allowed into the trunk? Was a 2 part vote required?
Nope, mistake on my side
Jacques
>
> Ron
>
> On 14/10/2015 6:17 AM, Taher Alkhateeb wrote:
>> Hi Jacques,
>>
>> I am a bit confused? Why wait for a frozen branch for anything? I thought trunk is your development/unstable bleeding-edge part of the code. This
>> is where you introduce changes without worrying about people's stable systems because they base their systems on release branches. In fact,
>> branches exist only to stabilize trunk at certain points of time.
>>
>> Furthermore, if we introduce Java 8 into trunk, what possible logical reason exists for _voting_ to use the new features of the language? Why did
>> you upgrade in the first place if you do not intend to use the newer features?
>>
>> Taher Alkhateeb
>>
>> ----- Original Message -----
>>
>> From: "Jacques Le Roux" <ja...@les7arts.com>
>> To: dev@ofbiz.apache.org
>> Sent: Wednesday, 14 October, 2015 12:23:31 PM
>> Subject: Re: Java 8 and functional programming in trunk
>>
>> I tend to agree. Actually there are 2 points,
>> 1) use Java 8 to compile
>> 2) use new Java 8 features
>>
>> We can already do 1, but we should maybe wait the next freezed branch to do 2. That should be discussed but does not prevent 1. Of course any commit
>> with 2 will be rejected as long as an agreement on 2 will not be reached
>>
>> Jacques
>>
>> Le 11/10/2015 19:09, Ron Wheeler a écrit :
>>> I am not sure why backwards compatibility is an issue with moving to Java 8.
>>>
>>> It works well,
>>> it is the supported version of Java.
>>> As far as I have heard, the Java 8 JVM runs code compiled with earlier versions of Java. (My own experience is uniformly positive).
>>>
>>> I can see no reason to think that anyone who is developing or using OFBiz would need to compile or run with an older version of Java.
>>>
>>> In this day of VM and Docker Containers, it is hard to imagine that someone would be stuck on an older JVM in a production environment and unable to
>>> come up with a configuration that would allow them to run JVM 8 to support OFBiz.
>>>
>>> IMHO, we should just move to requiring the supported version of Java as soon as possible.
>>>
>>> Ron
>>>
>>>
>>> On 11/10/2015 4:14 AM, Taher Alkhateeb wrote:
>>>> Hello Everyone,
>>>>
>>>> We created and provided the patches for this issue since June and OFBiz is pretty much ready to move to JDK 8. I'm not sure if lazy consensus is
>>>> enough or whether a vote is warranted to move this issue forward?
>>>>
>>>> Cheers,
>>>>
>>>> Taher Alkhateeb
>>>>
>>>> ----- Original Message -----
>>>>
>>>> From: "Pierre Smits" <pi...@gmail.com>
>>>> To: dev@ofbiz.apache.org
>>>> Sent: Thursday, 7 May, 2015 10:52:00 AM
>>>> Subject: Re: Java 8 and functional programming in trunk
>>>>
>>>> I don't think that it is a question of using or not using J8. It is more
>>>> about when to move it into trunk, as from that moment on there will be
>>>> backward compatibility issues.
>>>> A helpful solution in this respect could be to designate a specific release
>>>> branch now (e.g. r15 or r16), create the version in JIRA and setup the dev
>>>> branch in svn. Doing it that way J8 related issues can get registered,
>>>> changes can get implemented and assessed (in the dev branch) without
>>>> breaking current stuff in trunk.
>>>>
>>>> But it also ensures that we can create awareness prior to releasing stuff.
>>>>
>>>> Best regards,
>>>>
>>>>
>>>>
>>>> Pierre Smits
>>>>
>>>> *ORRTIZ.COM <http://www.orrtiz.com>*
>>>> Services & Solutions for Cloud-
>>>> Based Manufacturing, Professional
>>>> Services and Retail & Trade
>>>> http://www.orrtiz.com
>>>>
>>>> On Thu, May 7, 2015 at 9:30 AM, Nicolas Malin <ni...@nereide.fr>
>>>> wrote:
>>>>
>>>>> Ok Thanks Scott and Jacques.
>>>>>
>>>>> So Who is against use java 8 and more on trunk ?
>>>>>
>>>>> :)
>>>>>
>>>>> Nicolas
>>>>>
>>>>>
>>>>> Le 07/05/2015 08:46, Jacques Le Roux a écrit :
>>>>>
>>>>>> Yes (lazy) consensus over vote ;)
>>>>>>
>>>>>> Jacques
>>>>>>
>>>>>> Le 07/05/2015 05:02, Scott Gray a écrit :
>>>>>>
>>>>>>> I'm not sure if a vote is necessary, particularly if no one has any
>>>>>>> objections.
>>>>>>>
>>>>>>> Regards
>>>>>>> Scott
>>>>>>> On 7 May 2015 07:44, "Nicolas Malin" <ni...@nereide.fr> wrote:
>>>>>>>
>>>>>>> I'm favorable to use java 8.
>>>>>>>> I think it's will be pretty fin if you can support oracle jdk8 and
>>>>>>>> openjdk8 also.
>>>>>>>>
>>>>>>>> I propose to organize a vote to validate or not this proposition
>>>>>>>>
>>>>>>>> Nicolas
>>>>>>>>
>>>>>>>> Le 03/05/2015 11:52, Jacques Le Roux a écrit :
>>>>>>>>
>>>>>>>> Hi Taher,
>>>>>>>>> Yes I think so. For now well known (I hope ;)) security reasons, if
>>>>>>>>> people want to use Oracle JDK they need to use Java 8.
>>>>>>>>> So implementing with new Java 8 features now in trunk sounds good to
>>>>>>>>> me.
>>>>>>>>> BTW this is only my opinion...
>>>>>>>>>
>>>>>>>>> Note that our demos are still using OpenJDK 1.7 I'm not quite sure of
>>>>>>>>> the
>>>>>>>>> policy
>>>>>>>>>
>>>>>>>>> http://www.cvedetails.com/vulnerability-list/vendor_id-93/product_id-23642/version_id-138218/Oracle-Openjdk-1.7.0.html
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Jacques
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Le 03/05/2015 10:52, Taher Alkhateeb a écrit :
>>>>>>>>>
>>>>>>>>> Hi everyone,
>>>>>>>>>> I would like to work on a few JIRAs and at the same refactor some
>>>>>>>>>> existing
>>>>>>>>>> code to utilize Lambdas and Streams utilizing Java 8 features.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Is it acceptable to develop with JDK 8 features into trunk?
>>>>>>>>>>
>>>>>>>>>> Taher Alkhateeb
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>
>>
>
>
Re: Java 8 and functional programming in trunk
Posted by Ron Wheeler <rw...@artifact-software.com>.
+1 on Tahar Alkhateeb's points.
I don't think that anyone is proposing to convert all existing code to
use the latest Java 8 features.
I think that once you force people to run the Java 8 JVM by doing the
compile with Java 8, you are pretty much done.
If someone adds a Stream function in their code and the code is
validated to work correctly, that should be the end of the story.
We don't vote on other code changes.
Who is going to check new patches to ensure that they do not depend on
Java 8 features or bugs fixed in Java 8?
What was the process when Java 7 features where allowed into the trunk?
Was a 2 part vote required?
Ron
On 14/10/2015 6:17 AM, Taher Alkhateeb wrote:
> Hi Jacques,
>
> I am a bit confused? Why wait for a frozen branch for anything? I thought trunk is your development/unstable bleeding-edge part of the code. This is where you introduce changes without worrying about people's stable systems because they base their systems on release branches. In fact, branches exist only to stabilize trunk at certain points of time.
>
> Furthermore, if we introduce Java 8 into trunk, what possible logical reason exists for _voting_ to use the new features of the language? Why did you upgrade in the first place if you do not intend to use the newer features?
>
> Taher Alkhateeb
>
> ----- Original Message -----
>
> From: "Jacques Le Roux" <ja...@les7arts.com>
> To: dev@ofbiz.apache.org
> Sent: Wednesday, 14 October, 2015 12:23:31 PM
> Subject: Re: Java 8 and functional programming in trunk
>
> I tend to agree. Actually there are 2 points,
> 1) use Java 8 to compile
> 2) use new Java 8 features
>
> We can already do 1, but we should maybe wait the next freezed branch to do 2. That should be discussed but does not prevent 1. Of course any commit
> with 2 will be rejected as long as an agreement on 2 will not be reached
>
> Jacques
>
> Le 11/10/2015 19:09, Ron Wheeler a écrit :
>> I am not sure why backwards compatibility is an issue with moving to Java 8.
>>
>> It works well,
>> it is the supported version of Java.
>> As far as I have heard, the Java 8 JVM runs code compiled with earlier versions of Java. (My own experience is uniformly positive).
>>
>> I can see no reason to think that anyone who is developing or using OFBiz would need to compile or run with an older version of Java.
>>
>> In this day of VM and Docker Containers, it is hard to imagine that someone would be stuck on an older JVM in a production environment and unable to
>> come up with a configuration that would allow them to run JVM 8 to support OFBiz.
>>
>> IMHO, we should just move to requiring the supported version of Java as soon as possible.
>>
>> Ron
>>
>>
>> On 11/10/2015 4:14 AM, Taher Alkhateeb wrote:
>>> Hello Everyone,
>>>
>>> We created and provided the patches for this issue since June and OFBiz is pretty much ready to move to JDK 8. I'm not sure if lazy consensus is
>>> enough or whether a vote is warranted to move this issue forward?
>>>
>>> Cheers,
>>>
>>> Taher Alkhateeb
>>>
>>> ----- Original Message -----
>>>
>>> From: "Pierre Smits" <pi...@gmail.com>
>>> To: dev@ofbiz.apache.org
>>> Sent: Thursday, 7 May, 2015 10:52:00 AM
>>> Subject: Re: Java 8 and functional programming in trunk
>>>
>>> I don't think that it is a question of using or not using J8. It is more
>>> about when to move it into trunk, as from that moment on there will be
>>> backward compatibility issues.
>>> A helpful solution in this respect could be to designate a specific release
>>> branch now (e.g. r15 or r16), create the version in JIRA and setup the dev
>>> branch in svn. Doing it that way J8 related issues can get registered,
>>> changes can get implemented and assessed (in the dev branch) without
>>> breaking current stuff in trunk.
>>>
>>> But it also ensures that we can create awareness prior to releasing stuff.
>>>
>>> Best regards,
>>>
>>>
>>>
>>> Pierre Smits
>>>
>>> *ORRTIZ.COM <http://www.orrtiz.com>*
>>> Services & Solutions for Cloud-
>>> Based Manufacturing, Professional
>>> Services and Retail & Trade
>>> http://www.orrtiz.com
>>>
>>> On Thu, May 7, 2015 at 9:30 AM, Nicolas Malin <ni...@nereide.fr>
>>> wrote:
>>>
>>>> Ok Thanks Scott and Jacques.
>>>>
>>>> So Who is against use java 8 and more on trunk ?
>>>>
>>>> :)
>>>>
>>>> Nicolas
>>>>
>>>>
>>>> Le 07/05/2015 08:46, Jacques Le Roux a écrit :
>>>>
>>>>> Yes (lazy) consensus over vote ;)
>>>>>
>>>>> Jacques
>>>>>
>>>>> Le 07/05/2015 05:02, Scott Gray a écrit :
>>>>>
>>>>>> I'm not sure if a vote is necessary, particularly if no one has any
>>>>>> objections.
>>>>>>
>>>>>> Regards
>>>>>> Scott
>>>>>> On 7 May 2015 07:44, "Nicolas Malin" <ni...@nereide.fr> wrote:
>>>>>>
>>>>>> I'm favorable to use java 8.
>>>>>>> I think it's will be pretty fin if you can support oracle jdk8 and
>>>>>>> openjdk8 also.
>>>>>>>
>>>>>>> I propose to organize a vote to validate or not this proposition
>>>>>>>
>>>>>>> Nicolas
>>>>>>>
>>>>>>> Le 03/05/2015 11:52, Jacques Le Roux a écrit :
>>>>>>>
>>>>>>> Hi Taher,
>>>>>>>> Yes I think so. For now well known (I hope ;)) security reasons, if
>>>>>>>> people want to use Oracle JDK they need to use Java 8.
>>>>>>>> So implementing with new Java 8 features now in trunk sounds good to
>>>>>>>> me.
>>>>>>>> BTW this is only my opinion...
>>>>>>>>
>>>>>>>> Note that our demos are still using OpenJDK 1.7 I'm not quite sure of
>>>>>>>> the
>>>>>>>> policy
>>>>>>>>
>>>>>>>> http://www.cvedetails.com/vulnerability-list/vendor_id-93/product_id-23642/version_id-138218/Oracle-Openjdk-1.7.0.html
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Jacques
>>>>>>>>
>>>>>>>>
>>>>>>>> Le 03/05/2015 10:52, Taher Alkhateeb a écrit :
>>>>>>>>
>>>>>>>> Hi everyone,
>>>>>>>>> I would like to work on a few JIRAs and at the same refactor some
>>>>>>>>> existing
>>>>>>>>> code to utilize Lambdas and Streams utilizing Java 8 features.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Is it acceptable to develop with JDK 8 features into trunk?
>>>>>>>>>
>>>>>>>>> Taher Alkhateeb
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>
>
--
Ron Wheeler
President
Artifact Software Inc
email: rwheeler@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102
Re: Java 8 and functional programming in trunk
Posted by Jacques Le Roux <ja...@les7arts.com>.
You are right there is no need to wait for a frozen branch, we can already put Java 8 new code features in trunk and we will have them in the next
frozen branch which will need Java 8. Though we still need to agreed on this, I see not reasons we will not, so yes it seems to me a lazy consensus
apply. On the other hand we need to be very careful when backporting to released branches. We shall not introduce Java 8 new code features in them,
they are supposed to work with Java 7 only for supported ones (older we no longer backport anyway)
Hoo I see https://issues.apache.org/jira/browse/OFBIZ-6458?focusedCommentId=14576325 :D
You are a committer, go ahead (maybe wait few days if ever someone is against)
BTW Java 8 is great but I believe Jigsaw in Java 9 will have even more impact, notably regarding the recent resurrection of the
http://ofbiz.markmail.org/message/25dse4jke2fp64mx thread in the "Moving groovy script files" thread
Jacques
Le 14/10/2015 12:17, Taher Alkhateeb a écrit :
> Hi Jacques,
>
> I am a bit confused? Why wait for a frozen branch for anything? I thought trunk is your development/unstable bleeding-edge part of the code. This is where you introduce changes without worrying about people's stable systems because they base their systems on release branches. In fact, branches exist only to stabilize trunk at certain points of time.
>
> Furthermore, if we introduce Java 8 into trunk, what possible logical reason exists for _voting_ to use the new features of the language? Why did you upgrade in the first place if you do not intend to use the newer features?
>
> Taher Alkhateeb
>
> ----- Original Message -----
>
> From: "Jacques Le Roux" <ja...@les7arts.com>
> To: dev@ofbiz.apache.org
> Sent: Wednesday, 14 October, 2015 12:23:31 PM
> Subject: Re: Java 8 and functional programming in trunk
>
> I tend to agree. Actually there are 2 points,
> 1) use Java 8 to compile
> 2) use new Java 8 features
>
> We can already do 1, but we should maybe wait the next freezed branch to do 2. That should be discussed but does not prevent 1. Of course any commit
> with 2 will be rejected as long as an agreement on 2 will not be reached
>
> Jacques
>
> Le 11/10/2015 19:09, Ron Wheeler a écrit :
>> I am not sure why backwards compatibility is an issue with moving to Java 8.
>>
>> It works well,
>> it is the supported version of Java.
>> As far as I have heard, the Java 8 JVM runs code compiled with earlier versions of Java. (My own experience is uniformly positive).
>>
>> I can see no reason to think that anyone who is developing or using OFBiz would need to compile or run with an older version of Java.
>>
>> In this day of VM and Docker Containers, it is hard to imagine that someone would be stuck on an older JVM in a production environment and unable to
>> come up with a configuration that would allow them to run JVM 8 to support OFBiz.
>>
>> IMHO, we should just move to requiring the supported version of Java as soon as possible.
>>
>> Ron
>>
>>
>> On 11/10/2015 4:14 AM, Taher Alkhateeb wrote:
>>> Hello Everyone,
>>>
>>> We created and provided the patches for this issue since June and OFBiz is pretty much ready to move to JDK 8. I'm not sure if lazy consensus is
>>> enough or whether a vote is warranted to move this issue forward?
>>>
>>> Cheers,
>>>
>>> Taher Alkhateeb
>>>
>>> ----- Original Message -----
>>>
>>> From: "Pierre Smits" <pi...@gmail.com>
>>> To: dev@ofbiz.apache.org
>>> Sent: Thursday, 7 May, 2015 10:52:00 AM
>>> Subject: Re: Java 8 and functional programming in trunk
>>>
>>> I don't think that it is a question of using or not using J8. It is more
>>> about when to move it into trunk, as from that moment on there will be
>>> backward compatibility issues.
>>> A helpful solution in this respect could be to designate a specific release
>>> branch now (e.g. r15 or r16), create the version in JIRA and setup the dev
>>> branch in svn. Doing it that way J8 related issues can get registered,
>>> changes can get implemented and assessed (in the dev branch) without
>>> breaking current stuff in trunk.
>>>
>>> But it also ensures that we can create awareness prior to releasing stuff.
>>>
>>> Best regards,
>>>
>>>
>>>
>>> Pierre Smits
>>>
>>> *ORRTIZ.COM <http://www.orrtiz.com>*
>>> Services & Solutions for Cloud-
>>> Based Manufacturing, Professional
>>> Services and Retail & Trade
>>> http://www.orrtiz.com
>>>
>>> On Thu, May 7, 2015 at 9:30 AM, Nicolas Malin <ni...@nereide.fr>
>>> wrote:
>>>
>>>> Ok Thanks Scott and Jacques.
>>>>
>>>> So Who is against use java 8 and more on trunk ?
>>>>
>>>> :)
>>>>
>>>> Nicolas
>>>>
>>>>
>>>> Le 07/05/2015 08:46, Jacques Le Roux a écrit :
>>>>
>>>>> Yes (lazy) consensus over vote ;)
>>>>>
>>>>> Jacques
>>>>>
>>>>> Le 07/05/2015 05:02, Scott Gray a écrit :
>>>>>
>>>>>> I'm not sure if a vote is necessary, particularly if no one has any
>>>>>> objections.
>>>>>>
>>>>>> Regards
>>>>>> Scott
>>>>>> On 7 May 2015 07:44, "Nicolas Malin" <ni...@nereide.fr> wrote:
>>>>>>
>>>>>> I'm favorable to use java 8.
>>>>>>> I think it's will be pretty fin if you can support oracle jdk8 and
>>>>>>> openjdk8 also.
>>>>>>>
>>>>>>> I propose to organize a vote to validate or not this proposition
>>>>>>>
>>>>>>> Nicolas
>>>>>>>
>>>>>>> Le 03/05/2015 11:52, Jacques Le Roux a écrit :
>>>>>>>
>>>>>>> Hi Taher,
>>>>>>>> Yes I think so. For now well known (I hope ;)) security reasons, if
>>>>>>>> people want to use Oracle JDK they need to use Java 8.
>>>>>>>> So implementing with new Java 8 features now in trunk sounds good to
>>>>>>>> me.
>>>>>>>> BTW this is only my opinion...
>>>>>>>>
>>>>>>>> Note that our demos are still using OpenJDK 1.7 I'm not quite sure of
>>>>>>>> the
>>>>>>>> policy
>>>>>>>>
>>>>>>>> http://www.cvedetails.com/vulnerability-list/vendor_id-93/product_id-23642/version_id-138218/Oracle-Openjdk-1.7.0.html
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Jacques
>>>>>>>>
>>>>>>>>
>>>>>>>> Le 03/05/2015 10:52, Taher Alkhateeb a écrit :
>>>>>>>>
>>>>>>>> Hi everyone,
>>>>>>>>> I would like to work on a few JIRAs and at the same refactor some
>>>>>>>>> existing
>>>>>>>>> code to utilize Lambdas and Streams utilizing Java 8 features.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Is it acceptable to develop with JDK 8 features into trunk?
>>>>>>>>>
>>>>>>>>> Taher Alkhateeb
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>
>
Re: Java 8 and functional programming in trunk
Posted by Taher Alkhateeb <sl...@gmail.com>.
Hi Jacques,
I am a bit confused? Why wait for a frozen branch for anything? I thought trunk is your development/unstable bleeding-edge part of the code. This is where you introduce changes without worrying about people's stable systems because they base their systems on release branches. In fact, branches exist only to stabilize trunk at certain points of time.
Furthermore, if we introduce Java 8 into trunk, what possible logical reason exists for _voting_ to use the new features of the language? Why did you upgrade in the first place if you do not intend to use the newer features?
Taher Alkhateeb
----- Original Message -----
From: "Jacques Le Roux" <ja...@les7arts.com>
To: dev@ofbiz.apache.org
Sent: Wednesday, 14 October, 2015 12:23:31 PM
Subject: Re: Java 8 and functional programming in trunk
I tend to agree. Actually there are 2 points,
1) use Java 8 to compile
2) use new Java 8 features
We can already do 1, but we should maybe wait the next freezed branch to do 2. That should be discussed but does not prevent 1. Of course any commit
with 2 will be rejected as long as an agreement on 2 will not be reached
Jacques
Le 11/10/2015 19:09, Ron Wheeler a écrit :
> I am not sure why backwards compatibility is an issue with moving to Java 8.
>
> It works well,
> it is the supported version of Java.
> As far as I have heard, the Java 8 JVM runs code compiled with earlier versions of Java. (My own experience is uniformly positive).
>
> I can see no reason to think that anyone who is developing or using OFBiz would need to compile or run with an older version of Java.
>
> In this day of VM and Docker Containers, it is hard to imagine that someone would be stuck on an older JVM in a production environment and unable to
> come up with a configuration that would allow them to run JVM 8 to support OFBiz.
>
> IMHO, we should just move to requiring the supported version of Java as soon as possible.
>
> Ron
>
>
> On 11/10/2015 4:14 AM, Taher Alkhateeb wrote:
>> Hello Everyone,
>>
>> We created and provided the patches for this issue since June and OFBiz is pretty much ready to move to JDK 8. I'm not sure if lazy consensus is
>> enough or whether a vote is warranted to move this issue forward?
>>
>> Cheers,
>>
>> Taher Alkhateeb
>>
>> ----- Original Message -----
>>
>> From: "Pierre Smits" <pi...@gmail.com>
>> To: dev@ofbiz.apache.org
>> Sent: Thursday, 7 May, 2015 10:52:00 AM
>> Subject: Re: Java 8 and functional programming in trunk
>>
>> I don't think that it is a question of using or not using J8. It is more
>> about when to move it into trunk, as from that moment on there will be
>> backward compatibility issues.
>> A helpful solution in this respect could be to designate a specific release
>> branch now (e.g. r15 or r16), create the version in JIRA and setup the dev
>> branch in svn. Doing it that way J8 related issues can get registered,
>> changes can get implemented and assessed (in the dev branch) without
>> breaking current stuff in trunk.
>>
>> But it also ensures that we can create awareness prior to releasing stuff.
>>
>> Best regards,
>>
>>
>>
>> Pierre Smits
>>
>> *ORRTIZ.COM <http://www.orrtiz.com>*
>> Services & Solutions for Cloud-
>> Based Manufacturing, Professional
>> Services and Retail & Trade
>> http://www.orrtiz.com
>>
>> On Thu, May 7, 2015 at 9:30 AM, Nicolas Malin <ni...@nereide.fr>
>> wrote:
>>
>>> Ok Thanks Scott and Jacques.
>>>
>>> So Who is against use java 8 and more on trunk ?
>>>
>>> :)
>>>
>>> Nicolas
>>>
>>>
>>> Le 07/05/2015 08:46, Jacques Le Roux a écrit :
>>>
>>>> Yes (lazy) consensus over vote ;)
>>>>
>>>> Jacques
>>>>
>>>> Le 07/05/2015 05:02, Scott Gray a écrit :
>>>>
>>>>> I'm not sure if a vote is necessary, particularly if no one has any
>>>>> objections.
>>>>>
>>>>> Regards
>>>>> Scott
>>>>> On 7 May 2015 07:44, "Nicolas Malin" <ni...@nereide.fr> wrote:
>>>>>
>>>>> I'm favorable to use java 8.
>>>>>> I think it's will be pretty fin if you can support oracle jdk8 and
>>>>>> openjdk8 also.
>>>>>>
>>>>>> I propose to organize a vote to validate or not this proposition
>>>>>>
>>>>>> Nicolas
>>>>>>
>>>>>> Le 03/05/2015 11:52, Jacques Le Roux a écrit :
>>>>>>
>>>>>> Hi Taher,
>>>>>>> Yes I think so. For now well known (I hope ;)) security reasons, if
>>>>>>> people want to use Oracle JDK they need to use Java 8.
>>>>>>> So implementing with new Java 8 features now in trunk sounds good to
>>>>>>> me.
>>>>>>> BTW this is only my opinion...
>>>>>>>
>>>>>>> Note that our demos are still using OpenJDK 1.7 I'm not quite sure of
>>>>>>> the
>>>>>>> policy
>>>>>>>
>>>>>>> http://www.cvedetails.com/vulnerability-list/vendor_id-93/product_id-23642/version_id-138218/Oracle-Openjdk-1.7.0.html
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Jacques
>>>>>>>
>>>>>>>
>>>>>>> Le 03/05/2015 10:52, Taher Alkhateeb a écrit :
>>>>>>>
>>>>>>> Hi everyone,
>>>>>>>> I would like to work on a few JIRAs and at the same refactor some
>>>>>>>> existing
>>>>>>>> code to utilize Lambdas and Streams utilizing Java 8 features.
>>>>>>>>
>>>>>>>>
>>>>>>>> Is it acceptable to develop with JDK 8 features into trunk?
>>>>>>>>
>>>>>>>> Taher Alkhateeb
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>
>
>
Re: Java 8 and functional programming in trunk
Posted by Jacques Le Roux <ja...@les7arts.com>.
I tend to agree. Actually there are 2 points,
1) use Java 8 to compile
2) use new Java 8 features
We can already do 1, but we should maybe wait the next freezed branch to do 2. That should be discussed but does not prevent 1. Of course any commit
with 2 will be rejected as long as an agreement on 2 will not be reached
Jacques
Le 11/10/2015 19:09, Ron Wheeler a écrit :
> I am not sure why backwards compatibility is an issue with moving to Java 8.
>
> It works well,
> it is the supported version of Java.
> As far as I have heard, the Java 8 JVM runs code compiled with earlier versions of Java. (My own experience is uniformly positive).
>
> I can see no reason to think that anyone who is developing or using OFBiz would need to compile or run with an older version of Java.
>
> In this day of VM and Docker Containers, it is hard to imagine that someone would be stuck on an older JVM in a production environment and unable to
> come up with a configuration that would allow them to run JVM 8 to support OFBiz.
>
> IMHO, we should just move to requiring the supported version of Java as soon as possible.
>
> Ron
>
>
> On 11/10/2015 4:14 AM, Taher Alkhateeb wrote:
>> Hello Everyone,
>>
>> We created and provided the patches for this issue since June and OFBiz is pretty much ready to move to JDK 8. I'm not sure if lazy consensus is
>> enough or whether a vote is warranted to move this issue forward?
>>
>> Cheers,
>>
>> Taher Alkhateeb
>>
>> ----- Original Message -----
>>
>> From: "Pierre Smits" <pi...@gmail.com>
>> To: dev@ofbiz.apache.org
>> Sent: Thursday, 7 May, 2015 10:52:00 AM
>> Subject: Re: Java 8 and functional programming in trunk
>>
>> I don't think that it is a question of using or not using J8. It is more
>> about when to move it into trunk, as from that moment on there will be
>> backward compatibility issues.
>> A helpful solution in this respect could be to designate a specific release
>> branch now (e.g. r15 or r16), create the version in JIRA and setup the dev
>> branch in svn. Doing it that way J8 related issues can get registered,
>> changes can get implemented and assessed (in the dev branch) without
>> breaking current stuff in trunk.
>>
>> But it also ensures that we can create awareness prior to releasing stuff.
>>
>> Best regards,
>>
>>
>>
>> Pierre Smits
>>
>> *ORRTIZ.COM <http://www.orrtiz.com>*
>> Services & Solutions for Cloud-
>> Based Manufacturing, Professional
>> Services and Retail & Trade
>> http://www.orrtiz.com
>>
>> On Thu, May 7, 2015 at 9:30 AM, Nicolas Malin <ni...@nereide.fr>
>> wrote:
>>
>>> Ok Thanks Scott and Jacques.
>>>
>>> So Who is against use java 8 and more on trunk ?
>>>
>>> :)
>>>
>>> Nicolas
>>>
>>>
>>> Le 07/05/2015 08:46, Jacques Le Roux a écrit :
>>>
>>>> Yes (lazy) consensus over vote ;)
>>>>
>>>> Jacques
>>>>
>>>> Le 07/05/2015 05:02, Scott Gray a écrit :
>>>>
>>>>> I'm not sure if a vote is necessary, particularly if no one has any
>>>>> objections.
>>>>>
>>>>> Regards
>>>>> Scott
>>>>> On 7 May 2015 07:44, "Nicolas Malin" <ni...@nereide.fr> wrote:
>>>>>
>>>>> I'm favorable to use java 8.
>>>>>> I think it's will be pretty fin if you can support oracle jdk8 and
>>>>>> openjdk8 also.
>>>>>>
>>>>>> I propose to organize a vote to validate or not this proposition
>>>>>>
>>>>>> Nicolas
>>>>>>
>>>>>> Le 03/05/2015 11:52, Jacques Le Roux a écrit :
>>>>>>
>>>>>> Hi Taher,
>>>>>>> Yes I think so. For now well known (I hope ;)) security reasons, if
>>>>>>> people want to use Oracle JDK they need to use Java 8.
>>>>>>> So implementing with new Java 8 features now in trunk sounds good to
>>>>>>> me.
>>>>>>> BTW this is only my opinion...
>>>>>>>
>>>>>>> Note that our demos are still using OpenJDK 1.7 I'm not quite sure of
>>>>>>> the
>>>>>>> policy
>>>>>>>
>>>>>>> http://www.cvedetails.com/vulnerability-list/vendor_id-93/product_id-23642/version_id-138218/Oracle-Openjdk-1.7.0.html
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Jacques
>>>>>>>
>>>>>>>
>>>>>>> Le 03/05/2015 10:52, Taher Alkhateeb a écrit :
>>>>>>>
>>>>>>> Hi everyone,
>>>>>>>> I would like to work on a few JIRAs and at the same refactor some
>>>>>>>> existing
>>>>>>>> code to utilize Lambdas and Streams utilizing Java 8 features.
>>>>>>>>
>>>>>>>>
>>>>>>>> Is it acceptable to develop with JDK 8 features into trunk?
>>>>>>>>
>>>>>>>> Taher Alkhateeb
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>
>
>
Re: Java 8 and functional programming in trunk
Posted by Ron Wheeler <rw...@artifact-software.com>.
I am not sure why backwards compatibility is an issue with moving to Java 8.
It works well,
it is the supported version of Java.
As far as I have heard, the Java 8 JVM runs code compiled with earlier
versions of Java. (My own experience is uniformly positive).
I can see no reason to think that anyone who is developing or using
OFBiz would need to compile or run with an older version of Java.
In this day of VM and Docker Containers, it is hard to imagine that
someone would be stuck on an older JVM in a production environment and
unable to come up with a configuration that would allow them to run JVM
8 to support OFBiz.
IMHO, we should just move to requiring the supported version of Java as
soon as possible.
Ron
On 11/10/2015 4:14 AM, Taher Alkhateeb wrote:
> Hello Everyone,
>
> We created and provided the patches for this issue since June and OFBiz is pretty much ready to move to JDK 8. I'm not sure if lazy consensus is enough or whether a vote is warranted to move this issue forward?
>
> Cheers,
>
> Taher Alkhateeb
>
> ----- Original Message -----
>
> From: "Pierre Smits" <pi...@gmail.com>
> To: dev@ofbiz.apache.org
> Sent: Thursday, 7 May, 2015 10:52:00 AM
> Subject: Re: Java 8 and functional programming in trunk
>
> I don't think that it is a question of using or not using J8. It is more
> about when to move it into trunk, as from that moment on there will be
> backward compatibility issues.
> A helpful solution in this respect could be to designate a specific release
> branch now (e.g. r15 or r16), create the version in JIRA and setup the dev
> branch in svn. Doing it that way J8 related issues can get registered,
> changes can get implemented and assessed (in the dev branch) without
> breaking current stuff in trunk.
>
> But it also ensures that we can create awareness prior to releasing stuff.
>
> Best regards,
>
>
>
> Pierre Smits
>
> *ORRTIZ.COM <http://www.orrtiz.com>*
> Services & Solutions for Cloud-
> Based Manufacturing, Professional
> Services and Retail & Trade
> http://www.orrtiz.com
>
> On Thu, May 7, 2015 at 9:30 AM, Nicolas Malin <ni...@nereide.fr>
> wrote:
>
>> Ok Thanks Scott and Jacques.
>>
>> So Who is against use java 8 and more on trunk ?
>>
>> :)
>>
>> Nicolas
>>
>>
>> Le 07/05/2015 08:46, Jacques Le Roux a écrit :
>>
>>> Yes (lazy) consensus over vote ;)
>>>
>>> Jacques
>>>
>>> Le 07/05/2015 05:02, Scott Gray a écrit :
>>>
>>>> I'm not sure if a vote is necessary, particularly if no one has any
>>>> objections.
>>>>
>>>> Regards
>>>> Scott
>>>> On 7 May 2015 07:44, "Nicolas Malin" <ni...@nereide.fr> wrote:
>>>>
>>>> I'm favorable to use java 8.
>>>>> I think it's will be pretty fin if you can support oracle jdk8 and
>>>>> openjdk8 also.
>>>>>
>>>>> I propose to organize a vote to validate or not this proposition
>>>>>
>>>>> Nicolas
>>>>>
>>>>> Le 03/05/2015 11:52, Jacques Le Roux a écrit :
>>>>>
>>>>> Hi Taher,
>>>>>> Yes I think so. For now well known (I hope ;)) security reasons, if
>>>>>> people want to use Oracle JDK they need to use Java 8.
>>>>>> So implementing with new Java 8 features now in trunk sounds good to
>>>>>> me.
>>>>>> BTW this is only my opinion...
>>>>>>
>>>>>> Note that our demos are still using OpenJDK 1.7 I'm not quite sure of
>>>>>> the
>>>>>> policy
>>>>>>
>>>>>> http://www.cvedetails.com/vulnerability-list/vendor_id-93/product_id-23642/version_id-138218/Oracle-Openjdk-1.7.0.html
>>>>>>
>>>>>>
>>>>>>
>>>>>> Jacques
>>>>>>
>>>>>>
>>>>>> Le 03/05/2015 10:52, Taher Alkhateeb a écrit :
>>>>>>
>>>>>> Hi everyone,
>>>>>>> I would like to work on a few JIRAs and at the same refactor some
>>>>>>> existing
>>>>>>> code to utilize Lambdas and Streams utilizing Java 8 features.
>>>>>>>
>>>>>>>
>>>>>>> Is it acceptable to develop with JDK 8 features into trunk?
>>>>>>>
>>>>>>> Taher Alkhateeb
>>>>>>>
>>>>>>>
>>>>>>>
>
--
Ron Wheeler
President
Artifact Software Inc
email: rwheeler@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102
Re: Java 8 and functional programming in trunk
Posted by Taher Alkhateeb <sl...@gmail.com>.
Hello Everyone,
We created and provided the patches for this issue since June and OFBiz is pretty much ready to move to JDK 8. I'm not sure if lazy consensus is enough or whether a vote is warranted to move this issue forward?
Cheers,
Taher Alkhateeb
----- Original Message -----
From: "Pierre Smits" <pi...@gmail.com>
To: dev@ofbiz.apache.org
Sent: Thursday, 7 May, 2015 10:52:00 AM
Subject: Re: Java 8 and functional programming in trunk
I don't think that it is a question of using or not using J8. It is more
about when to move it into trunk, as from that moment on there will be
backward compatibility issues.
A helpful solution in this respect could be to designate a specific release
branch now (e.g. r15 or r16), create the version in JIRA and setup the dev
branch in svn. Doing it that way J8 related issues can get registered,
changes can get implemented and assessed (in the dev branch) without
breaking current stuff in trunk.
But it also ensures that we can create awareness prior to releasing stuff.
Best regards,
Pierre Smits
*ORRTIZ.COM <http://www.orrtiz.com>*
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com
On Thu, May 7, 2015 at 9:30 AM, Nicolas Malin <ni...@nereide.fr>
wrote:
> Ok Thanks Scott and Jacques.
>
> So Who is against use java 8 and more on trunk ?
>
> :)
>
> Nicolas
>
>
> Le 07/05/2015 08:46, Jacques Le Roux a écrit :
>
>> Yes (lazy) consensus over vote ;)
>>
>> Jacques
>>
>> Le 07/05/2015 05:02, Scott Gray a écrit :
>>
>>> I'm not sure if a vote is necessary, particularly if no one has any
>>> objections.
>>>
>>> Regards
>>> Scott
>>> On 7 May 2015 07:44, "Nicolas Malin" <ni...@nereide.fr> wrote:
>>>
>>> I'm favorable to use java 8.
>>>> I think it's will be pretty fin if you can support oracle jdk8 and
>>>> openjdk8 also.
>>>>
>>>> I propose to organize a vote to validate or not this proposition
>>>>
>>>> Nicolas
>>>>
>>>> Le 03/05/2015 11:52, Jacques Le Roux a écrit :
>>>>
>>>> Hi Taher,
>>>>>
>>>>> Yes I think so. For now well known (I hope ;)) security reasons, if
>>>>> people want to use Oracle JDK they need to use Java 8.
>>>>> So implementing with new Java 8 features now in trunk sounds good to
>>>>> me.
>>>>> BTW this is only my opinion...
>>>>>
>>>>> Note that our demos are still using OpenJDK 1.7 I'm not quite sure of
>>>>> the
>>>>> policy
>>>>>
>>>>> http://www.cvedetails.com/vulnerability-list/vendor_id-93/product_id-23642/version_id-138218/Oracle-Openjdk-1.7.0.html
>>>>>
>>>>>
>>>>>
>>>>> Jacques
>>>>>
>>>>>
>>>>> Le 03/05/2015 10:52, Taher Alkhateeb a écrit :
>>>>>
>>>>> Hi everyone,
>>>>>>
>>>>>> I would like to work on a few JIRAs and at the same refactor some
>>>>>> existing
>>>>>> code to utilize Lambdas and Streams utilizing Java 8 features.
>>>>>>
>>>>>>
>>>>>> Is it acceptable to develop with JDK 8 features into trunk?
>>>>>>
>>>>>> Taher Alkhateeb
>>>>>>
>>>>>>
>>>>>>
>
Re: Java 8 and functional programming in trunk
Posted by Pierre Smits <pi...@gmail.com>.
I don't think that it is a question of using or not using J8. It is more
about when to move it into trunk, as from that moment on there will be
backward compatibility issues.
A helpful solution in this respect could be to designate a specific release
branch now (e.g. r15 or r16), create the version in JIRA and setup the dev
branch in svn. Doing it that way J8 related issues can get registered,
changes can get implemented and assessed (in the dev branch) without
breaking current stuff in trunk.
But it also ensures that we can create awareness prior to releasing stuff.
Best regards,
Pierre Smits
*ORRTIZ.COM <http://www.orrtiz.com>*
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com
On Thu, May 7, 2015 at 9:30 AM, Nicolas Malin <ni...@nereide.fr>
wrote:
> Ok Thanks Scott and Jacques.
>
> So Who is against use java 8 and more on trunk ?
>
> :)
>
> Nicolas
>
>
> Le 07/05/2015 08:46, Jacques Le Roux a écrit :
>
>> Yes (lazy) consensus over vote ;)
>>
>> Jacques
>>
>> Le 07/05/2015 05:02, Scott Gray a écrit :
>>
>>> I'm not sure if a vote is necessary, particularly if no one has any
>>> objections.
>>>
>>> Regards
>>> Scott
>>> On 7 May 2015 07:44, "Nicolas Malin" <ni...@nereide.fr> wrote:
>>>
>>> I'm favorable to use java 8.
>>>> I think it's will be pretty fin if you can support oracle jdk8 and
>>>> openjdk8 also.
>>>>
>>>> I propose to organize a vote to validate or not this proposition
>>>>
>>>> Nicolas
>>>>
>>>> Le 03/05/2015 11:52, Jacques Le Roux a écrit :
>>>>
>>>> Hi Taher,
>>>>>
>>>>> Yes I think so. For now well known (I hope ;)) security reasons, if
>>>>> people want to use Oracle JDK they need to use Java 8.
>>>>> So implementing with new Java 8 features now in trunk sounds good to
>>>>> me.
>>>>> BTW this is only my opinion...
>>>>>
>>>>> Note that our demos are still using OpenJDK 1.7 I'm not quite sure of
>>>>> the
>>>>> policy
>>>>>
>>>>> http://www.cvedetails.com/vulnerability-list/vendor_id-93/product_id-23642/version_id-138218/Oracle-Openjdk-1.7.0.html
>>>>>
>>>>>
>>>>>
>>>>> Jacques
>>>>>
>>>>>
>>>>> Le 03/05/2015 10:52, Taher Alkhateeb a écrit :
>>>>>
>>>>> Hi everyone,
>>>>>>
>>>>>> I would like to work on a few JIRAs and at the same refactor some
>>>>>> existing
>>>>>> code to utilize Lambdas and Streams utilizing Java 8 features.
>>>>>>
>>>>>>
>>>>>> Is it acceptable to develop with JDK 8 features into trunk?
>>>>>>
>>>>>> Taher Alkhateeb
>>>>>>
>>>>>>
>>>>>>
>
Re: Java 8 and functional programming in trunk
Posted by Nicolas Malin <ni...@nereide.fr>.
Ok Thanks Scott and Jacques.
So Who is against use java 8 and more on trunk ?
:)
Nicolas
Le 07/05/2015 08:46, Jacques Le Roux a écrit :
> Yes (lazy) consensus over vote ;)
>
> Jacques
>
> Le 07/05/2015 05:02, Scott Gray a écrit :
>> I'm not sure if a vote is necessary, particularly if no one has any
>> objections.
>>
>> Regards
>> Scott
>> On 7 May 2015 07:44, "Nicolas Malin" <ni...@nereide.fr> wrote:
>>
>>> I'm favorable to use java 8.
>>> I think it's will be pretty fin if you can support oracle jdk8 and
>>> openjdk8 also.
>>>
>>> I propose to organize a vote to validate or not this proposition
>>>
>>> Nicolas
>>>
>>> Le 03/05/2015 11:52, Jacques Le Roux a écrit :
>>>
>>>> Hi Taher,
>>>>
>>>> Yes I think so. For now well known (I hope ;)) security reasons, if
>>>> people want to use Oracle JDK they need to use Java 8.
>>>> So implementing with new Java 8 features now in trunk sounds good
>>>> to me.
>>>> BTW this is only my opinion...
>>>>
>>>> Note that our demos are still using OpenJDK 1.7 I'm not quite sure
>>>> of the
>>>> policy
>>>> http://www.cvedetails.com/vulnerability-list/vendor_id-93/product_id-23642/version_id-138218/Oracle-Openjdk-1.7.0.html
>>>>
>>>>
>>>>
>>>>
>>>> Jacques
>>>>
>>>>
>>>> Le 03/05/2015 10:52, Taher Alkhateeb a écrit :
>>>>
>>>>> Hi everyone,
>>>>>
>>>>> I would like to work on a few JIRAs and at the same refactor some
>>>>> existing
>>>>> code to utilize Lambdas and Streams utilizing Java 8 features.
>>>>>
>>>>>
>>>>> Is it acceptable to develop with JDK 8 features into trunk?
>>>>>
>>>>> Taher Alkhateeb
>>>>>
>>>>>
Re: Java 8 and functional programming in trunk
Posted by Taher Alkhateeb <sl...@gmail.com>.
Hi Adrian and everyone,
I have created JIRA OFBIZ-6458 which contains all the patches needed to upgrade to JDK 8. I do not want to commit because infrastructure is not upgraded. Any guidance on what to do next is appreciated.
Taher Alkhateeb
----- Original Message -----
From: "Adrian Crum" <ad...@sandglass-software.com>
To: dev@ofbiz.apache.org
Sent: Friday, 5 June, 2015 6:48:50 PM
Subject: Re: Java 8 and functional programming in trunk
I would recommend committing each fix separately, then log the revision
numbers in a single Jira issue.
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 6/5/2015 5:11 AM, Taher Alkhateeb wrote:
> Hi All,
>
> What is the proper process to move to JDK 8? I have a patch ready to move to JDK 8 and fix an issue which we describe below. Should we create a JIRA or request a vote or what exactly?
>
> While debugging I discovered a bug that was failing the tests when moving from JDK 7 to JDK 8 which has to do with the implementation of a HashMap. Essentially the HashMap in JDK 8 does not care for the insertion order while it does in JDK 7 (see below). A simple fix is to replace HashMap with LinkedHashMap. Now all the tests run in JDK 8.
>
> Taher Alkhateeb
>
> ==== debug outcome ====
> substitutionPatternMap.entrySet() under JDK 7 in the test testConvertOperatorSubstitutions (last assert test)
> {&&=@and, <==@lteq, ||=@or, >==@gteq, >=@gt, <=@lt}
>
> substitutionPatternMap.entrySet() under JDK 8 in the test testConvertOperatorSubstitutions (last assert test)
> {&&=@and, ||=@or, <==@lteq, <=@lt, >=@gt, >==@gteq}
>
> ----- Original Message -----
>
> From: "Taher Alkhateeb" <sl...@gmail.com>
> To: dev@ofbiz.apache.org
> Sent: Monday, 25 May, 2015 8:08:25 AM
> Subject: Re: Java 8 and functional programming in trunk
>
>
> Hello everyone,
>
> Okay, so it seems there is consensus on going ahead with Java 8. I tried testing this patch which I believe upgrades OFBiz to JDK 8.
>
> Running "./ant clean-all build load-demo run-tests" delivers a failure in "testConvertOperatorSubstitutions" (base tests). The error message is shown below . So the line giving the error is exactly this one in org.ofbiz.base.util.test.StringUtilTests
>
> assertEquals("all converions", "one && two || three > four >= five < six <= seven", StringUtil.convertOperatorSubstitutions("one @and two @or three @gt four @gteq five @lt six @lteq seven"));
>
> This is weird. I checked JDK 7 and JDK 8 implementations and I think they are identical in the matcher API. Yet when switching to JDK 8 the matcher evaluates on "@gt" of the "@qteq " pattern and so you end up with ">eq" instead of ">=" . This is without even applying the above patch.
>
> I hope I am not running on a wild goose chase and ignoring something simple or silly? Any Ideas?
>
> ==== error log start ====
> all converions expected:<...wo || three > four >[=] five < six <= seven> but was:<...wo || three > four >[eq] five < six <= seven>
>
> junit.framework.ComparisonFailure: all converions expected:<...wo || three > four >[=] five < six <= seven> but was:<...wo || three > four >[eq] five < six <= seven>
> at org.ofbiz.base.test.GenericTestCaseBase.assertEquals(GenericTestCaseBase.java:313)
> at org.ofbiz.base.util.test.StringUtilTests.testConvertOperatorSubstitutions(StringUtilTests.java:269)
> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:237)
> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:408)
> at org.ofbiz.base.start.Start.start(Start.java:434)
> at org.ofbiz.base.start.Start.main(Start.java:135)
> ==== error log end ====
>
> Taher Alkhateeb
>
>
> ----- Original Message -----
>
> From: "Ron Wheeler" <rw...@artifact-software.com>
> To: dev@ofbiz.apache.org
> Sent: Thursday, 7 May, 2015 8:12:20 PM
> Subject: Re: Java 8 and functional programming in trunk
>
> On 07/05/2015 12:37 PM, Christian Geisert wrote:
>> Well call it "Standards Office" or whatever, the guys who decide which
>> platforms are allowed to use in the company.
>
> Java 7 will be coming off the list in most companies if it has not
> already been done.
>
>>
>> Java 8 is available since just about a year..
>> Just the mentioned Ubuntu 12.04 LTS (= Longtime Support, which means
>> support for 5 years) has no Java 8 in the official repositories.
>> Is there a Java 8 for AS/400 ;-)
>
> http://tecadmin.net/install-oracle-java-8-jdk-8-ubuntu-via-ppa/
>
>> Anyway, my point is that there should be good reasons to switch to Java
>> 8 only.
>>
>> Christian
>>
>> Am 07.05.2015 17:58, schrieb Ron Wheeler:
>>> On 07/05/2015 11:32 AM, Christian Geisert wrote:
>>>> Yes, we must support Java 8, but we absolutely have the choice to still
>>>> support Java 7 (i.e. no use of Java 8 only features yet)
>>>>
>>>> IMHO there should be good reasons to use these Java 8 features (not just
>>>> because it's cool..)
>>>>
>>>> It's not a big deal to update a developer machine to Java 8 (well, my
>>>> laptop still runs Kubuntu 12.04 ..) but it's another thing in (big)
>>>> companies (old operating systems, get approvals from security office
>>>> etc...)
>>> Security officer is going to be insisting on an upgrade to Java 8
>>> since Java 7 is no longer going to get security fixes.
>>>
>>> Have we heard of any OS that supports Java 7 but not Java 8?
>>>
>>> Ron
>>>
>>>> Christian
>>>>
>>>> Am 07.05.2015 15:40, schrieb Adam Heath:
>>>>> Not a reply to Jacques, but if an absolutely java-8-only feature is
>>>>> used, be sure to update the regex in ${ofbiz.home}/macros.xml, then
>>>>> the source/target values in common.xml in the same folder.
>>>>>
>>>>> ps: I'm fine with moving towards 1.8. It's not a choice that we can
>>>>> make, actually.
>>>>>
>>>>> On 05/07/2015 01:46 AM, Jacques Le Roux wrote:
>>>>>> Yes (lazy) consensus over vote ;)
>>>>>>
>>>>>> Jacques
>>>>>>
>>>
>>
>
>
Re: Java 8 and functional programming in trunk
Posted by Adrian Crum <ad...@sandglass-software.com>.
I would recommend committing each fix separately, then log the revision
numbers in a single Jira issue.
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 6/5/2015 5:11 AM, Taher Alkhateeb wrote:
> Hi All,
>
> What is the proper process to move to JDK 8? I have a patch ready to move to JDK 8 and fix an issue which we describe below. Should we create a JIRA or request a vote or what exactly?
>
> While debugging I discovered a bug that was failing the tests when moving from JDK 7 to JDK 8 which has to do with the implementation of a HashMap. Essentially the HashMap in JDK 8 does not care for the insertion order while it does in JDK 7 (see below). A simple fix is to replace HashMap with LinkedHashMap. Now all the tests run in JDK 8.
>
> Taher Alkhateeb
>
> ==== debug outcome ====
> substitutionPatternMap.entrySet() under JDK 7 in the test testConvertOperatorSubstitutions (last assert test)
> {&&=@and, <==@lteq, ||=@or, >==@gteq, >=@gt, <=@lt}
>
> substitutionPatternMap.entrySet() under JDK 8 in the test testConvertOperatorSubstitutions (last assert test)
> {&&=@and, ||=@or, <==@lteq, <=@lt, >=@gt, >==@gteq}
>
> ----- Original Message -----
>
> From: "Taher Alkhateeb" <sl...@gmail.com>
> To: dev@ofbiz.apache.org
> Sent: Monday, 25 May, 2015 8:08:25 AM
> Subject: Re: Java 8 and functional programming in trunk
>
>
> Hello everyone,
>
> Okay, so it seems there is consensus on going ahead with Java 8. I tried testing this patch which I believe upgrades OFBiz to JDK 8.
>
> Running "./ant clean-all build load-demo run-tests" delivers a failure in "testConvertOperatorSubstitutions" (base tests). The error message is shown below . So the line giving the error is exactly this one in org.ofbiz.base.util.test.StringUtilTests
>
> assertEquals("all converions", "one && two || three > four >= five < six <= seven", StringUtil.convertOperatorSubstitutions("one @and two @or three @gt four @gteq five @lt six @lteq seven"));
>
> This is weird. I checked JDK 7 and JDK 8 implementations and I think they are identical in the matcher API. Yet when switching to JDK 8 the matcher evaluates on "@gt" of the "@qteq " pattern and so you end up with ">eq" instead of ">=" . This is without even applying the above patch.
>
> I hope I am not running on a wild goose chase and ignoring something simple or silly? Any Ideas?
>
> ==== error log start ====
> all converions expected:<...wo || three > four >[=] five < six <= seven> but was:<...wo || three > four >[eq] five < six <= seven>
>
> junit.framework.ComparisonFailure: all converions expected:<...wo || three > four >[=] five < six <= seven> but was:<...wo || three > four >[eq] five < six <= seven>
> at org.ofbiz.base.test.GenericTestCaseBase.assertEquals(GenericTestCaseBase.java:313)
> at org.ofbiz.base.util.test.StringUtilTests.testConvertOperatorSubstitutions(StringUtilTests.java:269)
> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:237)
> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:408)
> at org.ofbiz.base.start.Start.start(Start.java:434)
> at org.ofbiz.base.start.Start.main(Start.java:135)
> ==== error log end ====
>
> Taher Alkhateeb
>
>
> ----- Original Message -----
>
> From: "Ron Wheeler" <rw...@artifact-software.com>
> To: dev@ofbiz.apache.org
> Sent: Thursday, 7 May, 2015 8:12:20 PM
> Subject: Re: Java 8 and functional programming in trunk
>
> On 07/05/2015 12:37 PM, Christian Geisert wrote:
>> Well call it "Standards Office" or whatever, the guys who decide which
>> platforms are allowed to use in the company.
>
> Java 7 will be coming off the list in most companies if it has not
> already been done.
>
>>
>> Java 8 is available since just about a year..
>> Just the mentioned Ubuntu 12.04 LTS (= Longtime Support, which means
>> support for 5 years) has no Java 8 in the official repositories.
>> Is there a Java 8 for AS/400 ;-)
>
> http://tecadmin.net/install-oracle-java-8-jdk-8-ubuntu-via-ppa/
>
>> Anyway, my point is that there should be good reasons to switch to Java
>> 8 only.
>>
>> Christian
>>
>> Am 07.05.2015 17:58, schrieb Ron Wheeler:
>>> On 07/05/2015 11:32 AM, Christian Geisert wrote:
>>>> Yes, we must support Java 8, but we absolutely have the choice to still
>>>> support Java 7 (i.e. no use of Java 8 only features yet)
>>>>
>>>> IMHO there should be good reasons to use these Java 8 features (not just
>>>> because it's cool..)
>>>>
>>>> It's not a big deal to update a developer machine to Java 8 (well, my
>>>> laptop still runs Kubuntu 12.04 ..) but it's another thing in (big)
>>>> companies (old operating systems, get approvals from security office
>>>> etc...)
>>> Security officer is going to be insisting on an upgrade to Java 8
>>> since Java 7 is no longer going to get security fixes.
>>>
>>> Have we heard of any OS that supports Java 7 but not Java 8?
>>>
>>> Ron
>>>
>>>> Christian
>>>>
>>>> Am 07.05.2015 15:40, schrieb Adam Heath:
>>>>> Not a reply to Jacques, but if an absolutely java-8-only feature is
>>>>> used, be sure to update the regex in ${ofbiz.home}/macros.xml, then
>>>>> the source/target values in common.xml in the same folder.
>>>>>
>>>>> ps: I'm fine with moving towards 1.8. It's not a choice that we can
>>>>> make, actually.
>>>>>
>>>>> On 05/07/2015 01:46 AM, Jacques Le Roux wrote:
>>>>>> Yes (lazy) consensus over vote ;)
>>>>>>
>>>>>> Jacques
>>>>>>
>>>
>>
>
>
Re: Java 8 and functional programming in trunk
Posted by Taher Alkhateeb <sl...@gmail.com>.
Hi All,
What is the proper process to move to JDK 8? I have a patch ready to move to JDK 8 and fix an issue which we describe below. Should we create a JIRA or request a vote or what exactly?
While debugging I discovered a bug that was failing the tests when moving from JDK 7 to JDK 8 which has to do with the implementation of a HashMap. Essentially the HashMap in JDK 8 does not care for the insertion order while it does in JDK 7 (see below). A simple fix is to replace HashMap with LinkedHashMap. Now all the tests run in JDK 8.
Taher Alkhateeb
==== debug outcome ====
substitutionPatternMap.entrySet() under JDK 7 in the test testConvertOperatorSubstitutions (last assert test)
{&&=@and, <==@lteq, ||=@or, >==@gteq, >=@gt, <=@lt}
substitutionPatternMap.entrySet() under JDK 8 in the test testConvertOperatorSubstitutions (last assert test)
{&&=@and, ||=@or, <==@lteq, <=@lt, >=@gt, >==@gteq}
----- Original Message -----
From: "Taher Alkhateeb" <sl...@gmail.com>
To: dev@ofbiz.apache.org
Sent: Monday, 25 May, 2015 8:08:25 AM
Subject: Re: Java 8 and functional programming in trunk
Hello everyone,
Okay, so it seems there is consensus on going ahead with Java 8. I tried testing this patch which I believe upgrades OFBiz to JDK 8.
Running "./ant clean-all build load-demo run-tests" delivers a failure in "testConvertOperatorSubstitutions" (base tests). The error message is shown below . So the line giving the error is exactly this one in org.ofbiz.base.util.test.StringUtilTests
assertEquals("all converions", "one && two || three > four >= five < six <= seven", StringUtil.convertOperatorSubstitutions("one @and two @or three @gt four @gteq five @lt six @lteq seven"));
This is weird. I checked JDK 7 and JDK 8 implementations and I think they are identical in the matcher API. Yet when switching to JDK 8 the matcher evaluates on "@gt" of the "@qteq " pattern and so you end up with ">eq" instead of ">=" . This is without even applying the above patch.
I hope I am not running on a wild goose chase and ignoring something simple or silly? Any Ideas?
==== error log start ====
all converions expected:<...wo || three > four >[=] five < six <= seven> but was:<...wo || three > four >[eq] five < six <= seven>
junit.framework.ComparisonFailure: all converions expected:<...wo || three > four >[=] five < six <= seven> but was:<...wo || three > four >[eq] five < six <= seven>
at org.ofbiz.base.test.GenericTestCaseBase.assertEquals(GenericTestCaseBase.java:313)
at org.ofbiz.base.util.test.StringUtilTests.testConvertOperatorSubstitutions(StringUtilTests.java:269)
at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:237)
at org.ofbiz.base.start.Start.startStartLoaders(Start.java:408)
at org.ofbiz.base.start.Start.start(Start.java:434)
at org.ofbiz.base.start.Start.main(Start.java:135)
==== error log end ====
Taher Alkhateeb
----- Original Message -----
From: "Ron Wheeler" <rw...@artifact-software.com>
To: dev@ofbiz.apache.org
Sent: Thursday, 7 May, 2015 8:12:20 PM
Subject: Re: Java 8 and functional programming in trunk
On 07/05/2015 12:37 PM, Christian Geisert wrote:
> Well call it "Standards Office" or whatever, the guys who decide which
> platforms are allowed to use in the company.
Java 7 will be coming off the list in most companies if it has not
already been done.
>
> Java 8 is available since just about a year..
> Just the mentioned Ubuntu 12.04 LTS (= Longtime Support, which means
> support for 5 years) has no Java 8 in the official repositories.
> Is there a Java 8 for AS/400 ;-)
http://tecadmin.net/install-oracle-java-8-jdk-8-ubuntu-via-ppa/
> Anyway, my point is that there should be good reasons to switch to Java
> 8 only.
>
> Christian
>
> Am 07.05.2015 17:58, schrieb Ron Wheeler:
>> On 07/05/2015 11:32 AM, Christian Geisert wrote:
>>> Yes, we must support Java 8, but we absolutely have the choice to still
>>> support Java 7 (i.e. no use of Java 8 only features yet)
>>>
>>> IMHO there should be good reasons to use these Java 8 features (not just
>>> because it's cool..)
>>>
>>> It's not a big deal to update a developer machine to Java 8 (well, my
>>> laptop still runs Kubuntu 12.04 ..) but it's another thing in (big)
>>> companies (old operating systems, get approvals from security office
>>> etc...)
>> Security officer is going to be insisting on an upgrade to Java 8
>> since Java 7 is no longer going to get security fixes.
>>
>> Have we heard of any OS that supports Java 7 but not Java 8?
>>
>> Ron
>>
>>> Christian
>>>
>>> Am 07.05.2015 15:40, schrieb Adam Heath:
>>>> Not a reply to Jacques, but if an absolutely java-8-only feature is
>>>> used, be sure to update the regex in ${ofbiz.home}/macros.xml, then
>>>> the source/target values in common.xml in the same folder.
>>>>
>>>> ps: I'm fine with moving towards 1.8. It's not a choice that we can
>>>> make, actually.
>>>>
>>>> On 05/07/2015 01:46 AM, Jacques Le Roux wrote:
>>>>> Yes (lazy) consensus over vote ;)
>>>>>
>>>>> Jacques
>>>>>
>>
>
--
Ron Wheeler
President
Artifact Software Inc
email: rwheeler@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102
Re: Java 8 and functional programming in trunk
Posted by Taher Alkhateeb <sl...@gmail.com>.
Hello everyone,
Okay, so it seems there is consensus on going ahead with Java 8. I tried testing this patch which I believe upgrades OFBiz to JDK 8.
Running "./ant clean-all build load-demo run-tests" delivers a failure in "testConvertOperatorSubstitutions" (base tests). The error message is shown below . So the line giving the error is exactly this one in org.ofbiz.base.util.test.StringUtilTests
assertEquals("all converions", "one && two || three > four >= five < six <= seven", StringUtil.convertOperatorSubstitutions("one @and two @or three @gt four @gteq five @lt six @lteq seven"));
This is weird. I checked JDK 7 and JDK 8 implementations and I think they are identical in the matcher API. Yet when switching to JDK 8 the matcher evaluates on "@gt" of the "@qteq " pattern and so you end up with ">eq" instead of ">= " . This is without even applying the above patch.
I hope I am not running on a wild goose chase and ignoring something simple or silly? Any Ideas?
==== error log start ====
all converions expected:<...wo || three > four >[=] five < six <= seven> but was:<...wo || three > four >[eq] five < six <= seven>
junit.framework.ComparisonFailure: all converions expected:<...wo || three > four >[=] five < six <= seven> but was:<...wo || three > four >[eq] five < six <= seven>
at org.ofbiz.base.test.GenericTestCaseBase.assertEquals(GenericTestCaseBase.java:313)
at org.ofbiz.base.util.test.StringUtilTests.testConvertOperatorSubstitutions(StringUtilTests.java:269)
at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:237)
at org.ofbiz.base.start.Start.startStartLoaders(Start.java:408)
at org.ofbiz.base.start.Start.start(Start.java:434)
at org.ofbiz.base.start.Start.main(Start.java:135)
==== error log end ====
Taher Alkhateeb
----- Original Message -----
From: "Ron Wheeler" <rw...@artifact-software.com>
To: dev@ofbiz.apache.org
Sent: Thursday, 7 May, 2015 8:12:20 PM
Subject: Re: Java 8 and functional programming in trunk
On 07/05/2015 12:37 PM, Christian Geisert wrote:
> Well call it "Standards Office" or whatever, the guys who decide which
> platforms are allowed to use in the company.
Java 7 will be coming off the list in most companies if it has not
already been done.
>
> Java 8 is available since just about a year..
> Just the mentioned Ubuntu 12.04 LTS (= Longtime Support, which means
> support for 5 years) has no Java 8 in the official repositories.
> Is there a Java 8 for AS/400 ;-)
http://tecadmin.net/install-oracle-java-8-jdk-8-ubuntu-via-ppa/
> Anyway, my point is that there should be good reasons to switch to Java
> 8 only.
>
> Christian
>
> Am 07.05.2015 17:58, schrieb Ron Wheeler:
>> On 07/05/2015 11:32 AM, Christian Geisert wrote:
>>> Yes, we must support Java 8, but we absolutely have the choice to still
>>> support Java 7 (i.e. no use of Java 8 only features yet)
>>>
>>> IMHO there should be good reasons to use these Java 8 features (not just
>>> because it's cool..)
>>>
>>> It's not a big deal to update a developer machine to Java 8 (well, my
>>> laptop still runs Kubuntu 12.04 ..) but it's another thing in (big)
>>> companies (old operating systems, get approvals from security office
>>> etc...)
>> Security officer is going to be insisting on an upgrade to Java 8
>> since Java 7 is no longer going to get security fixes.
>>
>> Have we heard of any OS that supports Java 7 but not Java 8?
>>
>> Ron
>>
>>> Christian
>>>
>>> Am 07.05.2015 15:40, schrieb Adam Heath:
>>>> Not a reply to Jacques, but if an absolutely java-8-only feature is
>>>> used, be sure to update the regex in ${ofbiz.home}/macros.xml, then
>>>> the source/target values in common.xml in the same folder.
>>>>
>>>> ps: I'm fine with moving towards 1.8. It's not a choice that we can
>>>> make, actually.
>>>>
>>>> On 05/07/2015 01:46 AM, Jacques Le Roux wrote:
>>>>> Yes (lazy) consensus over vote ;)
>>>>>
>>>>> Jacques
>>>>>
>>
>
--
Ron Wheeler
President
Artifact Software Inc
email: rwheeler@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102
Re: Java 8 and functional programming in trunk
Posted by Ron Wheeler <rw...@artifact-software.com>.
On 07/05/2015 12:37 PM, Christian Geisert wrote:
> Well call it "Standards Office" or whatever, the guys who decide which
> platforms are allowed to use in the company.
Java 7 will be coming off the list in most companies if it has not
already been done.
>
> Java 8 is available since just about a year..
> Just the mentioned Ubuntu 12.04 LTS (= Longtime Support, which means
> support for 5 years) has no Java 8 in the official repositories.
> Is there a Java 8 for AS/400 ;-)
http://tecadmin.net/install-oracle-java-8-jdk-8-ubuntu-via-ppa/
> Anyway, my point is that there should be good reasons to switch to Java
> 8 only.
>
> Christian
>
> Am 07.05.2015 17:58, schrieb Ron Wheeler:
>> On 07/05/2015 11:32 AM, Christian Geisert wrote:
>>> Yes, we must support Java 8, but we absolutely have the choice to still
>>> support Java 7 (i.e. no use of Java 8 only features yet)
>>>
>>> IMHO there should be good reasons to use these Java 8 features (not just
>>> because it's cool..)
>>>
>>> It's not a big deal to update a developer machine to Java 8 (well, my
>>> laptop still runs Kubuntu 12.04 ..) but it's another thing in (big)
>>> companies (old operating systems, get approvals from security office
>>> etc...)
>> Security officer is going to be insisting on an upgrade to Java 8
>> since Java 7 is no longer going to get security fixes.
>>
>> Have we heard of any OS that supports Java 7 but not Java 8?
>>
>> Ron
>>
>>> Christian
>>>
>>> Am 07.05.2015 15:40, schrieb Adam Heath:
>>>> Not a reply to Jacques, but if an absolutely java-8-only feature is
>>>> used, be sure to update the regex in ${ofbiz.home}/macros.xml, then
>>>> the source/target values in common.xml in the same folder.
>>>>
>>>> ps: I'm fine with moving towards 1.8. It's not a choice that we can
>>>> make, actually.
>>>>
>>>> On 05/07/2015 01:46 AM, Jacques Le Roux wrote:
>>>>> Yes (lazy) consensus over vote ;)
>>>>>
>>>>> Jacques
>>>>>
>>
>
--
Ron Wheeler
President
Artifact Software Inc
email: rwheeler@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102
Re: Java 8 and functional programming in trunk
Posted by Christian Geisert <ch...@isu-gmbh.de>.
Well call it "Standards Office" or whatever, the guys who decide which
platforms are allowed to use in the company.
Java 8 is available since just about a year..
Just the mentioned Ubuntu 12.04 LTS (= Longtime Support, which means
support for 5 years) has no Java 8 in the official repositories.
Is there a Java 8 for AS/400 ;-)
Anyway, my point is that there should be good reasons to switch to Java
8 only.
Christian
Am 07.05.2015 17:58, schrieb Ron Wheeler:
> On 07/05/2015 11:32 AM, Christian Geisert wrote:
>> Yes, we must support Java 8, but we absolutely have the choice to still
>> support Java 7 (i.e. no use of Java 8 only features yet)
>>
>> IMHO there should be good reasons to use these Java 8 features (not just
>> because it's cool..)
>>
>> It's not a big deal to update a developer machine to Java 8 (well, my
>> laptop still runs Kubuntu 12.04 ..) but it's another thing in (big)
>> companies (old operating systems, get approvals from security office
>> etc...)
>
> Security officer is going to be insisting on an upgrade to Java 8
> since Java 7 is no longer going to get security fixes.
>
> Have we heard of any OS that supports Java 7 but not Java 8?
>
> Ron
>
>>
>> Christian
>>
>> Am 07.05.2015 15:40, schrieb Adam Heath:
>>> Not a reply to Jacques, but if an absolutely java-8-only feature is
>>> used, be sure to update the regex in ${ofbiz.home}/macros.xml, then
>>> the source/target values in common.xml in the same folder.
>>>
>>> ps: I'm fine with moving towards 1.8. It's not a choice that we can
>>> make, actually.
>>>
>>> On 05/07/2015 01:46 AM, Jacques Le Roux wrote:
>>>> Yes (lazy) consensus over vote ;)
>>>>
>>>> Jacques
>>>>
>>>
>>
>
>
Re: Java 8 and functional programming in trunk
Posted by Ron Wheeler <rw...@artifact-software.com>.
On 07/05/2015 11:32 AM, Christian Geisert wrote:
> Yes, we must support Java 8, but we absolutely have the choice to still
> support Java 7 (i.e. no use of Java 8 only features yet)
>
> IMHO there should be good reasons to use these Java 8 features (not just
> because it's cool..)
>
> It's not a big deal to update a developer machine to Java 8 (well, my
> laptop still runs Kubuntu 12.04 ..) but it's another thing in (big)
> companies (old operating systems, get approvals from security office etc...)
Security officer is going to be insisting on an upgrade to Java 8 since
Java 7 is no longer going to get security fixes.
Have we heard of any OS that supports Java 7 but not Java 8?
Ron
>
> Christian
>
> Am 07.05.2015 15:40, schrieb Adam Heath:
>> Not a reply to Jacques, but if an absolutely java-8-only feature is
>> used, be sure to update the regex in ${ofbiz.home}/macros.xml, then
>> the source/target values in common.xml in the same folder.
>>
>> ps: I'm fine with moving towards 1.8. It's not a choice that we can
>> make, actually.
>>
>> On 05/07/2015 01:46 AM, Jacques Le Roux wrote:
>>> Yes (lazy) consensus over vote ;)
>>>
>>> Jacques
>>>
>>
>
--
Ron Wheeler
President
Artifact Software Inc
email: rwheeler@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102
Re: Java 8 and functional programming in trunk
Posted by Christian Geisert <ch...@isu-gmbh.de>.
Yes, we must support Java 8, but we absolutely have the choice to still
support Java 7 (i.e. no use of Java 8 only features yet)
IMHO there should be good reasons to use these Java 8 features (not just
because it's cool..)
It's not a big deal to update a developer machine to Java 8 (well, my
laptop still runs Kubuntu 12.04 ..) but it's another thing in (big)
companies (old operating systems, get approvals from security office etc...)
Christian
Am 07.05.2015 15:40, schrieb Adam Heath:
> Not a reply to Jacques, but if an absolutely java-8-only feature is
> used, be sure to update the regex in ${ofbiz.home}/macros.xml, then
> the source/target values in common.xml in the same folder.
>
> ps: I'm fine with moving towards 1.8. It's not a choice that we can
> make, actually.
>
> On 05/07/2015 01:46 AM, Jacques Le Roux wrote:
>> Yes (lazy) consensus over vote ;)
>>
>> Jacques
>>
>
>
Re: Java 8 and functional programming in trunk
Posted by Adam Heath <do...@brainfood.com>.
Not a reply to Jacques, but if an absolutely java-8-only feature is
used, be sure to update the regex in ${ofbiz.home}/macros.xml, then the
source/target values in common.xml in the same folder.
ps: I'm fine with moving towards 1.8. It's not a choice that we can
make, actually.
On 05/07/2015 01:46 AM, Jacques Le Roux wrote:
> Yes (lazy) consensus over vote ;)
>
> Jacques
>
Re: Java 8 and functional programming in trunk
Posted by Jacques Le Roux <ja...@les7arts.com>.
Yes (lazy) consensus over vote ;)
Jacques
Le 07/05/2015 05:02, Scott Gray a écrit :
> I'm not sure if a vote is necessary, particularly if no one has any
> objections.
>
> Regards
> Scott
> On 7 May 2015 07:44, "Nicolas Malin" <ni...@nereide.fr> wrote:
>
>> I'm favorable to use java 8.
>> I think it's will be pretty fin if you can support oracle jdk8 and
>> openjdk8 also.
>>
>> I propose to organize a vote to validate or not this proposition
>>
>> Nicolas
>>
>> Le 03/05/2015 11:52, Jacques Le Roux a écrit :
>>
>>> Hi Taher,
>>>
>>> Yes I think so. For now well known (I hope ;)) security reasons, if
>>> people want to use Oracle JDK they need to use Java 8.
>>> So implementing with new Java 8 features now in trunk sounds good to me.
>>> BTW this is only my opinion...
>>>
>>> Note that our demos are still using OpenJDK 1.7 I'm not quite sure of the
>>> policy
>>> http://www.cvedetails.com/vulnerability-list/vendor_id-93/product_id-23642/version_id-138218/Oracle-Openjdk-1.7.0.html
>>>
>>>
>>>
>>> Jacques
>>>
>>>
>>> Le 03/05/2015 10:52, Taher Alkhateeb a écrit :
>>>
>>>> Hi everyone,
>>>>
>>>> I would like to work on a few JIRAs and at the same refactor some
>>>> existing
>>>> code to utilize Lambdas and Streams utilizing Java 8 features.
>>>>
>>>>
>>>> Is it acceptable to develop with JDK 8 features into trunk?
>>>>
>>>> Taher Alkhateeb
>>>>
>>>>
Re: Java 8 and functional programming in trunk
Posted by Scott Gray <sc...@hotwaxsystems.com>.
I'm not sure if a vote is necessary, particularly if no one has any
objections.
Regards
Scott
On 7 May 2015 07:44, "Nicolas Malin" <ni...@nereide.fr> wrote:
> I'm favorable to use java 8.
> I think it's will be pretty fin if you can support oracle jdk8 and
> openjdk8 also.
>
> I propose to organize a vote to validate or not this proposition
>
> Nicolas
>
> Le 03/05/2015 11:52, Jacques Le Roux a écrit :
>
>> Hi Taher,
>>
>> Yes I think so. For now well known (I hope ;)) security reasons, if
>> people want to use Oracle JDK they need to use Java 8.
>> So implementing with new Java 8 features now in trunk sounds good to me.
>> BTW this is only my opinion...
>>
>> Note that our demos are still using OpenJDK 1.7 I'm not quite sure of the
>> policy
>> http://www.cvedetails.com/vulnerability-list/vendor_id-93/product_id-23642/version_id-138218/Oracle-Openjdk-1.7.0.html
>>
>>
>>
>> Jacques
>>
>>
>> Le 03/05/2015 10:52, Taher Alkhateeb a écrit :
>>
>>> Hi everyone,
>>>
>>> I would like to work on a few JIRAs and at the same refactor some
>>> existing
>>> code to utilize Lambdas and Streams utilizing Java 8 features.
>>>
>>>
>>> Is it acceptable to develop with JDK 8 features into trunk?
>>>
>>> Taher Alkhateeb
>>>
>>>
Re: Java 8 and functional programming in trunk
Posted by Nicolas Malin <ni...@nereide.fr>.
I'm favorable to use java 8.
I think it's will be pretty fin if you can support oracle jdk8 and
openjdk8 also.
I propose to organize a vote to validate or not this proposition
Nicolas
Le 03/05/2015 11:52, Jacques Le Roux a écrit :
> Hi Taher,
>
> Yes I think so. For now well known (I hope ;)) security reasons, if
> people want to use Oracle JDK they need to use Java 8.
> So implementing with new Java 8 features now in trunk sounds good to
> me. BTW this is only my opinion...
>
> Note that our demos are still using OpenJDK 1.7 I'm not quite sure of
> the policy
> http://www.cvedetails.com/vulnerability-list/vendor_id-93/product_id-23642/version_id-138218/Oracle-Openjdk-1.7.0.html
>
>
>
> Jacques
>
>
> Le 03/05/2015 10:52, Taher Alkhateeb a écrit :
>> Hi everyone,
>>
>> I would like to work on a few JIRAs and at the same refactor some
>> existing
>> code to utilize Lambdas and Streams utilizing Java 8 features.
>>
>>
>> Is it acceptable to develop with JDK 8 features into trunk?
>>
>> Taher Alkhateeb
>>
Re: Java 8 and functional programming in trunk
Posted by Jacques Le Roux <ja...@les7arts.com>.
Hi Taher,
Yes I think so. For now well known (I hope ;)) security reasons, if people want to use Oracle JDK they need to use Java 8.
So implementing with new Java 8 features now in trunk sounds good to me. BTW this is only my opinion...
Note that our demos are still using OpenJDK 1.7 I'm not quite sure of the policy
http://www.cvedetails.com/vulnerability-list/vendor_id-93/product_id-23642/version_id-138218/Oracle-Openjdk-1.7.0.html
Jacques
Le 03/05/2015 10:52, Taher Alkhateeb a écrit :
> Hi everyone,
>
> I would like to work on a few JIRAs and at the same refactor some existing
> code to utilize Lambdas and Streams utilizing Java 8 features.
>
>
> Is it acceptable to develop with JDK 8 features into trunk?
>
> Taher Alkhateeb
>