You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "jadami10 (via GitHub)" <gi...@apache.org> on 2023/07/26 15:45:52 UTC
[GitHub] [pinot] jadami10 opened a new pull request, #11184: Update the pinot tenants tables api to support returning broker tagged tables
jadami10 opened a new pull request, #11184:
URL: https://github.com/apache/pinot/pull/11184
This is authored by @priyen and is a small `feature` addition.
This updates the `tenants/{tenantName}/tables` API to support also specifying type to return tagged tables by the broker tenant. Tables can have separate broker and server tenants, so this allows us to actually get both.
Previously:
`/tenants/{tenantName}/tables` -> returns tables with that server tag
Now:
`/tenants/{tenantName}/tables` -> returns tables with that server tag
`/tenants/{tenantName}/tables?type=server` -> returns tables with that server tag
`/tenants/{tenantName}/tables?type=broker` -> returns tables with that broker tag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #11184: Update the pinot tenants tables api to support returning broker tagged tables
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #11184:
URL: https://github.com/apache/pinot/pull/11184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11184: Update the pinot tenants tables api to support returning broker tagged tables
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #11184:
URL: https://github.com/apache/pinot/pull/11184#discussion_r1277938379
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/ControllerRequestURLBuilder.java:
##########
@@ -84,6 +84,9 @@ public String forInstanceList() {
public String forTablesFromTenant(String tenantName) {
return StringUtil.join("/", _baseUrl, "tenants", tenantName, "tables");
}
+ public String forTablesFromTenant(String tenantName, String componentType) {
Review Comment:
(minor) add a new line before
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTenantRestletResource.java:
##########
@@ -246,17 +246,27 @@ public SuccessResponse enableOrDisableTenant(
@GET
@Path("/tenants/{tenantName}/tables")
@Produces(MediaType.APPLICATION_JSON)
- @ApiOperation(value = "List tables on a a server tenant")
+ @ApiOperation(value = "List tables on a server or broker tenant")
Review Comment:
Let's also update the javadoc above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #11184: Update the pinot tenants tables api to support returning broker tagged tables
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11184:
URL: https://github.com/apache/pinot/pull/11184#issuecomment-1652176998
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11184?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#11184](https://app.codecov.io/gh/apache/pinot/pull/11184?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (018c283) into [master](https://app.codecov.io/gh/apache/pinot/commit/9e079b1da94e9b3b980a3a4df4807e8091bc681f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (9e079b1) will **decrease** coverage by `0.12%`.
> Report is 3 commits behind head on master.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #11184 +/- ##
==========================================
- Coverage 0.11% 0.00% -0.12%
==========================================
Files 2214 2198 -16
Lines 118822 118407 -415
Branches 17978 17927 -51
==========================================
- Hits 137 0 -137
+ Misses 118665 118407 -258
+ Partials 20 0 -20
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1temurin11 | `0.00% <0.00%> (ø)` | |
| integration1temurin17 | `0.00% <0.00%> (ø)` | |
| integration1temurin20 | `0.00% <0.00%> (ø)` | |
| integration2temurin11 | `?` | |
| integration2temurin17 | `?` | |
| integration2temurin20 | `0.00% <0.00%> (ø)` | |
| unittests1temurin11 | `?` | |
| unittests1temurin17 | `0.00% <0.00%> (ø)` | |
| unittests1temurin20 | `0.00% <0.00%> (ø)` | |
| unittests2temurin11 | `?` | |
| unittests2temurin17 | `?` | |
| unittests2temurin20 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files Changed](https://app.codecov.io/gh/apache/pinot/pull/11184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ller/api/resources/PinotTenantRestletResource.java](https://app.codecov.io/gh/apache/pinot/pull/11184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1Bpbm90VGVuYW50UmVzdGxldFJlc291cmNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...spi/utils/builder/ControllerRequestURLBuilder.java](https://app.codecov.io/gh/apache/pinot/pull/11184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvYnVpbGRlci9Db250cm9sbGVyUmVxdWVzdFVSTEJ1aWxkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
... and [16 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/11184/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org