You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "vidakovic (via GitHub)" <gi...@apache.org> on 2023/08/17 08:53:26 UTC
[GitHub] [fineract] vidakovic commented on a diff in pull request #3374: Add custom AutoConfiguration class for tax service (FINERACT-1932)
vidakovic commented on code in PR #3374:
URL: https://github.com/apache/fineract/pull/3374#discussion_r1296892094
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/tax/service/TaxReadPlatformServiceImpl.java:
##########
@@ -49,7 +48,7 @@ public class TaxReadPlatformServiceImpl implements TaxReadPlatformService {
private final JdbcTemplate jdbcTemplate;
private final AccountingDropdownReadPlatformService accountingDropdownReadPlatformService;
- @Autowired
+
public TaxReadPlatformServiceImpl(final JdbcTemplate jdbcTemplate,
Review Comment:
Please use Lombok annotations to get rid of the constructor. Let's clean up when we have the opportunity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org