[GitHub] [helix] i3wangyi commented on a change in pull request #662: Mitigate controller leadership switch latency - improve leader -> standby

[GitBox <gi...@apache.org>]

i3wangyi commented on a change in pull request #662: Mitigate controller leadership switch latency - improve leader -> standby
URL: https://github.com/apache/helix/pull/662#discussion_r373747575
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java
 ##########
 @@ -697,8 +693,7 @@ public void reset() {
   }
 
   void reset(boolean isShutdown) {
-    logger.info("Resetting CallbackHandler: {}. Is resetting for shutdown: {}.", this.toString(),
-        isShutdown);
+    logger.info("Reset CallbackHandler. isShutdown: {}. Content: {}", isShutdown, getContent());
 
 Review comment:
   The callback type is not passed in from the caller in the beginning. Do you want to pass that information? And getContent gives you all the information

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org