You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@subversion.apache.org by Mattias Engdegård <ma...@bredband.net> on 2013/04/13 20:43:47 UTC

[PATCH] Avoid warning when char is unsigned

This trivial non-essential patch avoids a warning when building with - 
Wall.

[[[
Avoid a "condition always true" warning on platforms where char
is unsigned by default, such as PowerPC and ARM.

* subversion/libsvn_subr/utf_validate.c
   (first_non_fsm_start_char, first_non_fsm_start_char_cstring):
    Add explicit cast to avoid warning when plain char is unsigned.
]]]

Re: [PATCH] Avoid warning when char is unsigned

Posted by Mattias Engdegård <ma...@bredband.net>.

15 apr 2013 kl. 14.45 skrev Philip Martin:

>> Avoid a "condition always true" warning on platforms where char
>> is unsigned by default, such as PowerPC and ARM.
>
> Looks correct, +1

Thanks - committed as r1468255.

Re: [PATCH] Avoid warning when char is unsigned

Posted by Philip Martin <ph...@wandisco.com>.

Mattias Engdegård <ma...@bredband.net> writes:

> Avoid a "condition always true" warning on platforms where char
> is unsigned by default, such as PowerPC and ARM.
>
> * subversion/libsvn_subr/utf_validate.c
>   (first_non_fsm_start_char, first_non_fsm_start_char_cstring):
>    Add explicit cast to avoid warning when plain char is unsigned.

Looks correct, +1

-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download