You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Alexander Traeder (JIRA)" <de...@myfaces.apache.org> on 2005/11/21 16:36:42 UTC
[jira] Created: (MYFACES-853) commandLink not working inside dataList
commandLink not working inside dataList
---------------------------------------
Key: MYFACES-853
URL: http://issues.apache.org/jira/browse/MYFACES-853
Project: MyFaces
Type: Bug
Versions: 1.1.1
Environment: WinXP,tomcat 5.5.9,myfaces-1.1.1,JDK 1.5
Reporter: Alexander Traeder
in following code fragement the action-method "testService.listenOnSelect" is never called:
<%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
<%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
<%@ taglib uri="http://myfaces.apache.org/tomahawk" prefix="t"%>
<f:subview id="test">
<h:form id="testform">
<h:panelGrid columns="1">
<t:dataList id="datalist" style="standardList"
var="test"
value="#{testService.entries}"
rowCountVar="rowCount"
rowIndexVar="rowIndex"
layout="unorderedList">
<h:commandLink id="test_ref" value="#{rowIndex + 1}" action="#{testService.listenOnSelect}" />
</t:dataList>
</h:panelGrid>
</h:form>
</f:subview>
after some testing i also tried the nightly build but with the same result
also tried the following (working in other scenarios):
<h:commandLink id="testref" immediate="true" value="#{rowIndex + 1}" action="">
<t:updateActionListener property="#{rowCount}" value="#{testService.searchRow}" />
</h:commandLink>
any ideas?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (MYFACES-853) commandLink not working inside
dataList
Posted by "Dennis Byrne (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-853?page=all ]
Dennis Byrne resolved MYFACES-853:
----------------------------------
Resolution: Fixed
Yeah, this one is fixed. I have reproduced the 1009 behavior w/out the RI. Didn't try to fix it. It looked like 853 and 1009 were the same problem, same component, different lifecycle phase. I'm pretty sure datalist does not currently call processUpdates or processValidations on it's children.
> commandLink not working inside dataList
> ---------------------------------------
>
> Key: MYFACES-853
> URL: http://issues.apache.org/jira/browse/MYFACES-853
> Project: MyFaces
> Type: Bug
> Versions: 1.1.1
> Environment: WinXP,tomcat 5.5.9,myfaces-1.1.1,JDK 1.5
> Reporter: Alexander Traeder
> Assignee: Dennis Byrne
> Fix For: Nightly
> Attachments: api.txt, tomahawk.txt, tomahawk2.txt
>
> in following code fragement the action-method "testService.listenOnSelect" is never called:
> <%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
> <%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
> <%@ taglib uri="http://myfaces.apache.org/tomahawk" prefix="t"%>
> <f:subview id="test">
> <h:form id="testform">
> <h:panelGrid columns="1">
> <t:dataList id="datalist" style="standardList"
> var="test"
> value="#{testService.entries}"
> rowCountVar="rowCount"
> rowIndexVar="rowIndex"
> layout="unorderedList">
> <h:commandLink id="test_ref" value="#{rowIndex + 1}" action="#{testService.listenOnSelect}" />
> </t:dataList>
> </h:panelGrid>
> </h:form>
> </f:subview>
> after some testing i also tried the nightly build but with the same result
> also tried the following (working in other scenarios):
> <h:commandLink id="testref" immediate="true" value="#{rowIndex + 1}" action="">
> <t:updateActionListener property="#{rowCount}" value="#{testService.searchRow}" />
> </h:commandLink>
> any ideas?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-853) commandLink not working inside dataList
Posted by "Jesper Pedersen (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-853?page=comments#action_12360765 ]
Jesper Pedersen commented on MYFACES-853:
-----------------------------------------
I'm using SVN HEAD currently - the MyFaces-1.1.1 release worked ok with the <t:saveState> tag.
Best regards,
Jesper
> commandLink not working inside dataList
> ---------------------------------------
>
> Key: MYFACES-853
> URL: http://issues.apache.org/jira/browse/MYFACES-853
> Project: MyFaces
> Type: Bug
> Versions: 1.1.1
> Environment: WinXP,tomcat 5.5.9,myfaces-1.1.1,JDK 1.5
> Reporter: Alexander Traeder
>
> in following code fragement the action-method "testService.listenOnSelect" is never called:
> <%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
> <%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
> <%@ taglib uri="http://myfaces.apache.org/tomahawk" prefix="t"%>
> <f:subview id="test">
> <h:form id="testform">
> <h:panelGrid columns="1">
> <t:dataList id="datalist" style="standardList"
> var="test"
> value="#{testService.entries}"
> rowCountVar="rowCount"
> rowIndexVar="rowIndex"
> layout="unorderedList">
> <h:commandLink id="test_ref" value="#{rowIndex + 1}" action="#{testService.listenOnSelect}" />
> </t:dataList>
> </h:panelGrid>
> </h:form>
> </f:subview>
> after some testing i also tried the nightly build but with the same result
> also tried the following (working in other scenarios):
> <h:commandLink id="testref" immediate="true" value="#{rowIndex + 1}" action="">
> <t:updateActionListener property="#{rowCount}" value="#{testService.searchRow}" />
> </h:commandLink>
> any ideas?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-853) commandLink not working inside
dataList
Posted by "Dennis Byrne (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-853?page=comments#action_12362086 ]
Dennis Byrne commented on MYFACES-853:
--------------------------------------
Hello Martin,
I have approached it from a couple of different angles and it always seems to break something else though. I'm playing aroung with Shale's test framework ... http://struts.apache.org/struts-shale/features-test-framework.html . Maybe I can convince MyFaces to add yet another jar file to SVN .
> commandLink not working inside dataList
> ---------------------------------------
>
> Key: MYFACES-853
> URL: http://issues.apache.org/jira/browse/MYFACES-853
> Project: MyFaces
> Type: Bug
> Versions: 1.1.1
> Environment: WinXP,tomcat 5.5.9,myfaces-1.1.1,JDK 1.5
> Reporter: Alexander Traeder
>
> in following code fragement the action-method "testService.listenOnSelect" is never called:
> <%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
> <%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
> <%@ taglib uri="http://myfaces.apache.org/tomahawk" prefix="t"%>
> <f:subview id="test">
> <h:form id="testform">
> <h:panelGrid columns="1">
> <t:dataList id="datalist" style="standardList"
> var="test"
> value="#{testService.entries}"
> rowCountVar="rowCount"
> rowIndexVar="rowIndex"
> layout="unorderedList">
> <h:commandLink id="test_ref" value="#{rowIndex + 1}" action="#{testService.listenOnSelect}" />
> </t:dataList>
> </h:panelGrid>
> </h:form>
> </f:subview>
> after some testing i also tried the nightly build but with the same result
> also tried the following (working in other scenarios):
> <h:commandLink id="testref" immediate="true" value="#{rowIndex + 1}" action="">
> <t:updateActionListener property="#{rowCount}" value="#{testService.searchRow}" />
> </h:commandLink>
> any ideas?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-853) commandLink not working inside dataList
Posted by "Jesper Pedersen (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-853?page=comments#action_12360804 ]
Jesper Pedersen commented on MYFACES-853:
-----------------------------------------
Its on testServices <t:saveState value="#{testServices}"/>
Hope this helps.
> commandLink not working inside dataList
> ---------------------------------------
>
> Key: MYFACES-853
> URL: http://issues.apache.org/jira/browse/MYFACES-853
> Project: MyFaces
> Type: Bug
> Versions: 1.1.1
> Environment: WinXP,tomcat 5.5.9,myfaces-1.1.1,JDK 1.5
> Reporter: Alexander Traeder
>
> in following code fragement the action-method "testService.listenOnSelect" is never called:
> <%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
> <%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
> <%@ taglib uri="http://myfaces.apache.org/tomahawk" prefix="t"%>
> <f:subview id="test">
> <h:form id="testform">
> <h:panelGrid columns="1">
> <t:dataList id="datalist" style="standardList"
> var="test"
> value="#{testService.entries}"
> rowCountVar="rowCount"
> rowIndexVar="rowIndex"
> layout="unorderedList">
> <h:commandLink id="test_ref" value="#{rowIndex + 1}" action="#{testService.listenOnSelect}" />
> </t:dataList>
> </h:panelGrid>
> </h:form>
> </f:subview>
> after some testing i also tried the nightly build but with the same result
> also tried the following (working in other scenarios):
> <h:commandLink id="testref" immediate="true" value="#{rowIndex + 1}" action="">
> <t:updateActionListener property="#{rowCount}" value="#{testService.searchRow}" />
> </h:commandLink>
> any ideas?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-853) commandLink not working inside
dataList
Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-853?page=comments#action_12364744 ]
Martin Marinschek commented on MYFACES-853:
-------------------------------------------
Should we open 1009 again then?
regards,
Martin
> commandLink not working inside dataList
> ---------------------------------------
>
> Key: MYFACES-853
> URL: http://issues.apache.org/jira/browse/MYFACES-853
> Project: MyFaces
> Type: Bug
> Versions: 1.1.1
> Environment: WinXP,tomcat 5.5.9,myfaces-1.1.1,JDK 1.5
> Reporter: Alexander Traeder
> Assignee: Dennis Byrne
> Fix For: Nightly
> Attachments: api.txt, tomahawk.txt, tomahawk2.txt
>
> in following code fragement the action-method "testService.listenOnSelect" is never called:
> <%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
> <%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
> <%@ taglib uri="http://myfaces.apache.org/tomahawk" prefix="t"%>
> <f:subview id="test">
> <h:form id="testform">
> <h:panelGrid columns="1">
> <t:dataList id="datalist" style="standardList"
> var="test"
> value="#{testService.entries}"
> rowCountVar="rowCount"
> rowIndexVar="rowIndex"
> layout="unorderedList">
> <h:commandLink id="test_ref" value="#{rowIndex + 1}" action="#{testService.listenOnSelect}" />
> </t:dataList>
> </h:panelGrid>
> </h:form>
> </f:subview>
> after some testing i also tried the nightly build but with the same result
> also tried the following (working in other scenarios):
> <h:commandLink id="testref" immediate="true" value="#{rowIndex + 1}" action="">
> <t:updateActionListener property="#{rowCount}" value="#{testService.searchRow}" />
> </h:commandLink>
> any ideas?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-853) commandLink not working inside
dataList
Posted by "Dennis Byrne (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-853?page=comments#action_12364761 ]
Dennis Byrne commented on MYFACES-853:
--------------------------------------
Yes, they are seperate and MYFACES-1009 is still present . Not sure why this one was cloned.
> commandLink not working inside dataList
> ---------------------------------------
>
> Key: MYFACES-853
> URL: http://issues.apache.org/jira/browse/MYFACES-853
> Project: MyFaces
> Type: Bug
> Versions: 1.1.1
> Environment: WinXP,tomcat 5.5.9,myfaces-1.1.1,JDK 1.5
> Reporter: Alexander Traeder
> Assignee: Dennis Byrne
> Fix For: Nightly
> Attachments: api.txt, tomahawk.txt, tomahawk2.txt
>
> in following code fragement the action-method "testService.listenOnSelect" is never called:
> <%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
> <%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
> <%@ taglib uri="http://myfaces.apache.org/tomahawk" prefix="t"%>
> <f:subview id="test">
> <h:form id="testform">
> <h:panelGrid columns="1">
> <t:dataList id="datalist" style="standardList"
> var="test"
> value="#{testService.entries}"
> rowCountVar="rowCount"
> rowIndexVar="rowIndex"
> layout="unorderedList">
> <h:commandLink id="test_ref" value="#{rowIndex + 1}" action="#{testService.listenOnSelect}" />
> </t:dataList>
> </h:panelGrid>
> </h:form>
> </f:subview>
> after some testing i also tried the nightly build but with the same result
> also tried the following (working in other scenarios):
> <h:commandLink id="testref" immediate="true" value="#{rowIndex + 1}" action="">
> <t:updateActionListener property="#{rowCount}" value="#{testService.searchRow}" />
> </h:commandLink>
> any ideas?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-853) commandLink not working inside
dataList
Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-853?page=comments#action_12364645 ]
Martin Marinschek commented on MYFACES-853:
-------------------------------------------
I wonder why I reopened that?
If there was a mail; I should have appended it right away...
Is that fixed - what do you say, Dennis, you prepared the fix? You know about MYFACES-1009, too, right? I suppose the reason for MYFACES-1009 might have been using the RI as well...
I think we can call this fixed, it would of course not work with the RI though, due to MYFACES-1010.
regards,
Martin
> commandLink not working inside dataList
> ---------------------------------------
>
> Key: MYFACES-853
> URL: http://issues.apache.org/jira/browse/MYFACES-853
> Project: MyFaces
> Type: Bug
> Versions: 1.1.1
> Environment: WinXP,tomcat 5.5.9,myfaces-1.1.1,JDK 1.5
> Reporter: Alexander Traeder
> Assignee: Martin Marinschek
> Fix For: Nightly
> Attachments: api.txt, tomahawk.txt, tomahawk2.txt
>
> in following code fragement the action-method "testService.listenOnSelect" is never called:
> <%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
> <%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
> <%@ taglib uri="http://myfaces.apache.org/tomahawk" prefix="t"%>
> <f:subview id="test">
> <h:form id="testform">
> <h:panelGrid columns="1">
> <t:dataList id="datalist" style="standardList"
> var="test"
> value="#{testService.entries}"
> rowCountVar="rowCount"
> rowIndexVar="rowIndex"
> layout="unorderedList">
> <h:commandLink id="test_ref" value="#{rowIndex + 1}" action="#{testService.listenOnSelect}" />
> </t:dataList>
> </h:panelGrid>
> </h:form>
> </f:subview>
> after some testing i also tried the nightly build but with the same result
> also tried the following (working in other scenarios):
> <h:commandLink id="testref" immediate="true" value="#{rowIndex + 1}" action="">
> <t:updateActionListener property="#{rowCount}" value="#{testService.searchRow}" />
> </h:commandLink>
> any ideas?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-853) commandLink not working inside
dataList
Posted by "Dave (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-853?page=comments#action_12362887 ]
Dave commented on MYFACES-853:
------------------------------
dataList can be thought as dataTable with one column. It might be better to add an abstraction layer. Just a thought.
> commandLink not working inside dataList
> ---------------------------------------
>
> Key: MYFACES-853
> URL: http://issues.apache.org/jira/browse/MYFACES-853
> Project: MyFaces
> Type: Bug
> Versions: 1.1.1
> Environment: WinXP,tomcat 5.5.9,myfaces-1.1.1,JDK 1.5
> Reporter: Alexander Traeder
> Assignee: Martin Marinschek
> Fix For: Nightly
> Attachments: api.txt, tomahawk.txt, tomahawk2.txt
>
> in following code fragement the action-method "testService.listenOnSelect" is never called:
> <%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
> <%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
> <%@ taglib uri="http://myfaces.apache.org/tomahawk" prefix="t"%>
> <f:subview id="test">
> <h:form id="testform">
> <h:panelGrid columns="1">
> <t:dataList id="datalist" style="standardList"
> var="test"
> value="#{testService.entries}"
> rowCountVar="rowCount"
> rowIndexVar="rowIndex"
> layout="unorderedList">
> <h:commandLink id="test_ref" value="#{rowIndex + 1}" action="#{testService.listenOnSelect}" />
> </t:dataList>
> </h:panelGrid>
> </h:form>
> </f:subview>
> after some testing i also tried the nightly build but with the same result
> also tried the following (working in other scenarios):
> <h:commandLink id="testref" immediate="true" value="#{rowIndex + 1}" action="">
> <t:updateActionListener property="#{rowCount}" value="#{testService.searchRow}" />
> </h:commandLink>
> any ideas?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-853) commandLink not working inside
dataList
Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-853?page=comments#action_12362083 ]
Martin Marinschek commented on MYFACES-853:
-------------------------------------------
Dennis,
you're absolutely right with your evaluation of the first problem. This should be fixed asap... Hope we'll find someone to do the actual work ;)
I believe that the second problem corresponds to the first one, though (without spending too much time on deeper reflection). As the iteration doesn't happen, the client-id isn't properly synch'ed, either. So maybe by fixing #1, you'll also fix #2!
regards,
Martin
> commandLink not working inside dataList
> ---------------------------------------
>
> Key: MYFACES-853
> URL: http://issues.apache.org/jira/browse/MYFACES-853
> Project: MyFaces
> Type: Bug
> Versions: 1.1.1
> Environment: WinXP,tomcat 5.5.9,myfaces-1.1.1,JDK 1.5
> Reporter: Alexander Traeder
>
> in following code fragement the action-method "testService.listenOnSelect" is never called:
> <%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
> <%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
> <%@ taglib uri="http://myfaces.apache.org/tomahawk" prefix="t"%>
> <f:subview id="test">
> <h:form id="testform">
> <h:panelGrid columns="1">
> <t:dataList id="datalist" style="standardList"
> var="test"
> value="#{testService.entries}"
> rowCountVar="rowCount"
> rowIndexVar="rowIndex"
> layout="unorderedList">
> <h:commandLink id="test_ref" value="#{rowIndex + 1}" action="#{testService.listenOnSelect}" />
> </t:dataList>
> </h:panelGrid>
> </h:form>
> </f:subview>
> after some testing i also tried the nightly build but with the same result
> also tried the following (working in other scenarios):
> <h:commandLink id="testref" immediate="true" value="#{rowIndex + 1}" action="">
> <t:updateActionListener property="#{rowCount}" value="#{testService.searchRow}" />
> </h:commandLink>
> any ideas?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-853) commandLink not working inside
dataList
Posted by "Dennis Byrne (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-853?page=all ]
Dennis Byrne updated MYFACES-853:
---------------------------------
Attachment: tomahawk.txt
api.txt
This works for commandLinks and commandButtons. Martin, you were correct - fixing the first problem solved the second one as well.
> commandLink not working inside dataList
> ---------------------------------------
>
> Key: MYFACES-853
> URL: http://issues.apache.org/jira/browse/MYFACES-853
> Project: MyFaces
> Type: Bug
> Versions: 1.1.1
> Environment: WinXP,tomcat 5.5.9,myfaces-1.1.1,JDK 1.5
> Reporter: Alexander Traeder
> Attachments: api.txt, tomahawk.txt
>
> in following code fragement the action-method "testService.listenOnSelect" is never called:
> <%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
> <%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
> <%@ taglib uri="http://myfaces.apache.org/tomahawk" prefix="t"%>
> <f:subview id="test">
> <h:form id="testform">
> <h:panelGrid columns="1">
> <t:dataList id="datalist" style="standardList"
> var="test"
> value="#{testService.entries}"
> rowCountVar="rowCount"
> rowIndexVar="rowIndex"
> layout="unorderedList">
> <h:commandLink id="test_ref" value="#{rowIndex + 1}" action="#{testService.listenOnSelect}" />
> </t:dataList>
> </h:panelGrid>
> </h:form>
> </f:subview>
> after some testing i also tried the nightly build but with the same result
> also tried the following (working in other scenarios):
> <h:commandLink id="testref" immediate="true" value="#{rowIndex + 1}" action="">
> <t:updateActionListener property="#{rowCount}" value="#{testService.searchRow}" />
> </h:commandLink>
> any ideas?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (MYFACES-853) commandLink not working inside
dataList
Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-853?page=all ]
Martin Marinschek closed MYFACES-853:
-------------------------------------
Fix Version: Nightly
Resolution: Fixed
patch by Dennis Byrne. Thanks a lot!
> commandLink not working inside dataList
> ---------------------------------------
>
> Key: MYFACES-853
> URL: http://issues.apache.org/jira/browse/MYFACES-853
> Project: MyFaces
> Type: Bug
> Versions: 1.1.1
> Environment: WinXP,tomcat 5.5.9,myfaces-1.1.1,JDK 1.5
> Reporter: Alexander Traeder
> Assignee: Martin Marinschek
> Fix For: Nightly
> Attachments: api.txt, tomahawk.txt, tomahawk2.txt
>
> in following code fragement the action-method "testService.listenOnSelect" is never called:
> <%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
> <%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
> <%@ taglib uri="http://myfaces.apache.org/tomahawk" prefix="t"%>
> <f:subview id="test">
> <h:form id="testform">
> <h:panelGrid columns="1">
> <t:dataList id="datalist" style="standardList"
> var="test"
> value="#{testService.entries}"
> rowCountVar="rowCount"
> rowIndexVar="rowIndex"
> layout="unorderedList">
> <h:commandLink id="test_ref" value="#{rowIndex + 1}" action="#{testService.listenOnSelect}" />
> </t:dataList>
> </h:panelGrid>
> </h:form>
> </f:subview>
> after some testing i also tried the nightly build but with the same result
> also tried the following (working in other scenarios):
> <h:commandLink id="testref" immediate="true" value="#{rowIndex + 1}" action="">
> <t:updateActionListener property="#{rowCount}" value="#{testService.searchRow}" />
> </h:commandLink>
> any ideas?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-853) commandLink not working inside dataList
Posted by "Dennis Byrne (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-853?page=comments#action_12361570 ]
Dennis Byrne commented on MYFACES-853:
--------------------------------------
This is the same thing over in http://issues.apache.org/jira/browse/MYFACES-954 .
The children of dataList are not decoded, and any browser event (at least, for commandLinks), cannot be registered even if children were decoded :(
HtmlDataList inherits processDecodes from UIData. UIData.processDecodes calls methods like processFacets(), processColumnFacets() and processColumnChildren() . All three of these methods fail to decode children such as plain commandLinks and commandButtons (which are often found below t:dataList w/out facets and columns). Consequently, command children of dataList elements are not properly decoded during the apply request values phase. Events for these commands are of course not registered, which is why neither action listeners nor actions are invoked in later phases.
This can be fixed by making HtmlDataList implment it's own processDecodes() w/ a simple call to getChildren() and for loop. Decoding would be delegated to the Renderer for each child. Normally, HtmlLinkRendererBase does this, and it queus an event whenever the clientId matches the value of the HTTP parameter _link_hidden_ . This event would result in a method firing during the invoke application phase, provided the action source is not immediate. However this does not happen because the UIComponent, in this case an action source, does not give the proper clientId to the renderer. In other words, the _link_hidden_ HTTP request parameter does not match the value returned by HtmlCommandLink.getClientId() . For example, say we have the following in a JSP ...
<t:dataList id="dataList" var="item" value="#{UserLister.dataModel.wrappedData}" >
<h:commandLink value="#{item}" action="#{UserCrud.retrieve}" >
<t:updateActionListener property="#{UserCrud.id}" value="#{item.myUserId}" />
</h:commandLink>
</t:dataList>
After clicking in the first link, the resulting HTTP parameter value for _link_hidden_ ends up being dataList_0:_idJsp3. This is correct, but the link renderer is looking for dataList:_idJsp3 ( see HtmlLinkRendererBase.decode() ). This means HtmlDataList.getClientId() ( I am not in favor of changing clientId implementation for action sources) may also have to be changed.
I have not stepped through this w/ commandButton.
Can anyone point me to info on HtmlDataTableHack ?
> commandLink not working inside dataList
> ---------------------------------------
>
> Key: MYFACES-853
> URL: http://issues.apache.org/jira/browse/MYFACES-853
> Project: MyFaces
> Type: Bug
> Versions: 1.1.1
> Environment: WinXP,tomcat 5.5.9,myfaces-1.1.1,JDK 1.5
> Reporter: Alexander Traeder
>
> in following code fragement the action-method "testService.listenOnSelect" is never called:
> <%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
> <%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
> <%@ taglib uri="http://myfaces.apache.org/tomahawk" prefix="t"%>
> <f:subview id="test">
> <h:form id="testform">
> <h:panelGrid columns="1">
> <t:dataList id="datalist" style="standardList"
> var="test"
> value="#{testService.entries}"
> rowCountVar="rowCount"
> rowIndexVar="rowIndex"
> layout="unorderedList">
> <h:commandLink id="test_ref" value="#{rowIndex + 1}" action="#{testService.listenOnSelect}" />
> </t:dataList>
> </h:panelGrid>
> </h:form>
> </f:subview>
> after some testing i also tried the nightly build but with the same result
> also tried the following (working in other scenarios):
> <h:commandLink id="testref" immediate="true" value="#{rowIndex + 1}" action="">
> <t:updateActionListener property="#{rowCount}" value="#{testService.searchRow}" />
> </h:commandLink>
> any ideas?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-853) commandLink not working inside
dataList
Posted by "Dave (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-853?page=comments#action_12362808 ]
Dave commented on MYFACES-853:
------------------------------
Is there any logical difference between dataList and dataTable? The only difference is the rendering to HTML, right? dataTable is working well.
> commandLink not working inside dataList
> ---------------------------------------
>
> Key: MYFACES-853
> URL: http://issues.apache.org/jira/browse/MYFACES-853
> Project: MyFaces
> Type: Bug
> Versions: 1.1.1
> Environment: WinXP,tomcat 5.5.9,myfaces-1.1.1,JDK 1.5
> Reporter: Alexander Traeder
> Assignee: Martin Marinschek
> Fix For: Nightly
> Attachments: api.txt, tomahawk.txt, tomahawk2.txt
>
> in following code fragement the action-method "testService.listenOnSelect" is never called:
> <%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
> <%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
> <%@ taglib uri="http://myfaces.apache.org/tomahawk" prefix="t"%>
> <f:subview id="test">
> <h:form id="testform">
> <h:panelGrid columns="1">
> <t:dataList id="datalist" style="standardList"
> var="test"
> value="#{testService.entries}"
> rowCountVar="rowCount"
> rowIndexVar="rowIndex"
> layout="unorderedList">
> <h:commandLink id="test_ref" value="#{rowIndex + 1}" action="#{testService.listenOnSelect}" />
> </t:dataList>
> </h:panelGrid>
> </h:form>
> </f:subview>
> after some testing i also tried the nightly build but with the same result
> also tried the following (working in other scenarios):
> <h:commandLink id="testref" immediate="true" value="#{rowIndex + 1}" action="">
> <t:updateActionListener property="#{rowCount}" value="#{testService.searchRow}" />
> </h:commandLink>
> any ideas?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Reopened: (MYFACES-853) commandLink not working inside
dataList
Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-853?page=all ]
Martin Marinschek reopened MYFACES-853:
---------------------------------------
> commandLink not working inside dataList
> ---------------------------------------
>
> Key: MYFACES-853
> URL: http://issues.apache.org/jira/browse/MYFACES-853
> Project: MyFaces
> Type: Bug
> Versions: 1.1.1
> Environment: WinXP,tomcat 5.5.9,myfaces-1.1.1,JDK 1.5
> Reporter: Alexander Traeder
> Assignee: Martin Marinschek
> Fix For: Nightly
> Attachments: api.txt, tomahawk.txt, tomahawk2.txt
>
> in following code fragement the action-method "testService.listenOnSelect" is never called:
> <%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
> <%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
> <%@ taglib uri="http://myfaces.apache.org/tomahawk" prefix="t"%>
> <f:subview id="test">
> <h:form id="testform">
> <h:panelGrid columns="1">
> <t:dataList id="datalist" style="standardList"
> var="test"
> value="#{testService.entries}"
> rowCountVar="rowCount"
> rowIndexVar="rowIndex"
> layout="unorderedList">
> <h:commandLink id="test_ref" value="#{rowIndex + 1}" action="#{testService.listenOnSelect}" />
> </t:dataList>
> </h:panelGrid>
> </h:form>
> </f:subview>
> after some testing i also tried the nightly build but with the same result
> also tried the following (working in other scenarios):
> <h:commandLink id="testref" immediate="true" value="#{rowIndex + 1}" action="">
> <t:updateActionListener property="#{rowCount}" value="#{testService.searchRow}" />
> </h:commandLink>
> any ideas?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-853) commandLink not working inside
dataList
Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-853?page=comments#action_12362308 ]
Martin Marinschek commented on MYFACES-853:
-------------------------------------------
Thanks Dennis, as far as I can see, perfect now!
Muchos gracias,
regards,
Martin
> commandLink not working inside dataList
> ---------------------------------------
>
> Key: MYFACES-853
> URL: http://issues.apache.org/jira/browse/MYFACES-853
> Project: MyFaces
> Type: Bug
> Versions: 1.1.1
> Environment: WinXP,tomcat 5.5.9,myfaces-1.1.1,JDK 1.5
> Reporter: Alexander Traeder
> Attachments: api.txt, tomahawk.txt, tomahawk2.txt
>
> in following code fragement the action-method "testService.listenOnSelect" is never called:
> <%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
> <%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
> <%@ taglib uri="http://myfaces.apache.org/tomahawk" prefix="t"%>
> <f:subview id="test">
> <h:form id="testform">
> <h:panelGrid columns="1">
> <t:dataList id="datalist" style="standardList"
> var="test"
> value="#{testService.entries}"
> rowCountVar="rowCount"
> rowIndexVar="rowIndex"
> layout="unorderedList">
> <h:commandLink id="test_ref" value="#{rowIndex + 1}" action="#{testService.listenOnSelect}" />
> </t:dataList>
> </h:panelGrid>
> </h:form>
> </f:subview>
> after some testing i also tried the nightly build but with the same result
> also tried the following (working in other scenarios):
> <h:commandLink id="testref" immediate="true" value="#{rowIndex + 1}" action="">
> <t:updateActionListener property="#{rowCount}" value="#{testService.searchRow}" />
> </h:commandLink>
> any ideas?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-853) commandLink not working inside dataList
Posted by "Jesper Pedersen (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-853?page=comments#action_12360712 ]
Jesper Pedersen commented on MYFACES-853:
-----------------------------------------
Any known workarounds ?
I'm using a <t:saveState> tag inside the <h:form>, but that doesn't either.
> commandLink not working inside dataList
> ---------------------------------------
>
> Key: MYFACES-853
> URL: http://issues.apache.org/jira/browse/MYFACES-853
> Project: MyFaces
> Type: Bug
> Versions: 1.1.1
> Environment: WinXP,tomcat 5.5.9,myfaces-1.1.1,JDK 1.5
> Reporter: Alexander Traeder
>
> in following code fragement the action-method "testService.listenOnSelect" is never called:
> <%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
> <%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
> <%@ taglib uri="http://myfaces.apache.org/tomahawk" prefix="t"%>
> <f:subview id="test">
> <h:form id="testform">
> <h:panelGrid columns="1">
> <t:dataList id="datalist" style="standardList"
> var="test"
> value="#{testService.entries}"
> rowCountVar="rowCount"
> rowIndexVar="rowIndex"
> layout="unorderedList">
> <h:commandLink id="test_ref" value="#{rowIndex + 1}" action="#{testService.listenOnSelect}" />
> </t:dataList>
> </h:panelGrid>
> </h:form>
> </f:subview>
> after some testing i also tried the nightly build but with the same result
> also tried the following (working in other scenarios):
> <h:commandLink id="testref" immediate="true" value="#{rowIndex + 1}" action="">
> <t:updateActionListener property="#{rowCount}" value="#{testService.searchRow}" />
> </h:commandLink>
> any ideas?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-853) commandLink not working inside
dataList
Posted by "Dennis Byrne (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-853?page=comments#action_12362226 ]
Dennis Byrne commented on MYFACES-853:
--------------------------------------
Ouch ... my mistake. Are you comfortable moving process() to a static method in one of util classes of the api packages?
There are already at least three copies of process() in the codebase and I didn't want to put another in HtmlDataList.
Shale unit test discussion will come in a week or so. MyFaces and Shale/unit test framework don't play too nice together sometimes :(
> commandLink not working inside dataList
> ---------------------------------------
>
> Key: MYFACES-853
> URL: http://issues.apache.org/jira/browse/MYFACES-853
> Project: MyFaces
> Type: Bug
> Versions: 1.1.1
> Environment: WinXP,tomcat 5.5.9,myfaces-1.1.1,JDK 1.5
> Reporter: Alexander Traeder
> Attachments: api.txt, tomahawk.txt
>
> in following code fragement the action-method "testService.listenOnSelect" is never called:
> <%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
> <%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
> <%@ taglib uri="http://myfaces.apache.org/tomahawk" prefix="t"%>
> <f:subview id="test">
> <h:form id="testform">
> <h:panelGrid columns="1">
> <t:dataList id="datalist" style="standardList"
> var="test"
> value="#{testService.entries}"
> rowCountVar="rowCount"
> rowIndexVar="rowIndex"
> layout="unorderedList">
> <h:commandLink id="test_ref" value="#{rowIndex + 1}" action="#{testService.listenOnSelect}" />
> </t:dataList>
> </h:panelGrid>
> </h:form>
> </f:subview>
> after some testing i also tried the nightly build but with the same result
> also tried the following (working in other scenarios):
> <h:commandLink id="testref" immediate="true" value="#{rowIndex + 1}" action="">
> <t:updateActionListener property="#{rowCount}" value="#{testService.searchRow}" />
> </h:commandLink>
> any ideas?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-853) commandLink not working inside
dataList
Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-853?page=comments#action_12362241 ]
Martin Marinschek commented on MYFACES-853:
-------------------------------------------
Thanks Dennis. We'll commit when this is fixed.
You'll need to replicate - you'll always have to think about users not using MyFaces and still using dataList - they won't gain anything if you change the process method to use a static-util function in the API, cause they don't have the MyFaces API implementation in their classpath. So duplicate code is our only option here, as much as I hate to copy code myself. Best would be to document the duplication, though, so if someone changes one implementation of the function, he knows that he needs to change the other one as well.
Please, also take care to send in the patch according to the MyFaces code-style (e.g. { in new lines).
regards,
Martin
> commandLink not working inside dataList
> ---------------------------------------
>
> Key: MYFACES-853
> URL: http://issues.apache.org/jira/browse/MYFACES-853
> Project: MyFaces
> Type: Bug
> Versions: 1.1.1
> Environment: WinXP,tomcat 5.5.9,myfaces-1.1.1,JDK 1.5
> Reporter: Alexander Traeder
> Attachments: api.txt, tomahawk.txt
>
> in following code fragement the action-method "testService.listenOnSelect" is never called:
> <%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
> <%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
> <%@ taglib uri="http://myfaces.apache.org/tomahawk" prefix="t"%>
> <f:subview id="test">
> <h:form id="testform">
> <h:panelGrid columns="1">
> <t:dataList id="datalist" style="standardList"
> var="test"
> value="#{testService.entries}"
> rowCountVar="rowCount"
> rowIndexVar="rowIndex"
> layout="unorderedList">
> <h:commandLink id="test_ref" value="#{rowIndex + 1}" action="#{testService.listenOnSelect}" />
> </t:dataList>
> </h:panelGrid>
> </h:form>
> </f:subview>
> after some testing i also tried the nightly build but with the same result
> also tried the following (working in other scenarios):
> <h:commandLink id="testref" immediate="true" value="#{rowIndex + 1}" action="">
> <t:updateActionListener property="#{rowCount}" value="#{testService.searchRow}" />
> </h:commandLink>
> any ideas?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-853) commandLink not working inside
dataList
Posted by "Dennis Byrne (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-853?page=comments#action_12362258 ]
Dennis Byrne commented on MYFACES-853:
--------------------------------------
... OK guys :) Anyone else want to take a shot? ;)
> commandLink not working inside dataList
> ---------------------------------------
>
> Key: MYFACES-853
> URL: http://issues.apache.org/jira/browse/MYFACES-853
> Project: MyFaces
> Type: Bug
> Versions: 1.1.1
> Environment: WinXP,tomcat 5.5.9,myfaces-1.1.1,JDK 1.5
> Reporter: Alexander Traeder
> Attachments: api.txt, tomahawk.txt
>
> in following code fragement the action-method "testService.listenOnSelect" is never called:
> <%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
> <%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
> <%@ taglib uri="http://myfaces.apache.org/tomahawk" prefix="t"%>
> <f:subview id="test">
> <h:form id="testform">
> <h:panelGrid columns="1">
> <t:dataList id="datalist" style="standardList"
> var="test"
> value="#{testService.entries}"
> rowCountVar="rowCount"
> rowIndexVar="rowIndex"
> layout="unorderedList">
> <h:commandLink id="test_ref" value="#{rowIndex + 1}" action="#{testService.listenOnSelect}" />
> </t:dataList>
> </h:panelGrid>
> </h:form>
> </f:subview>
> after some testing i also tried the nightly build but with the same result
> also tried the following (working in other scenarios):
> <h:commandLink id="testref" immediate="true" value="#{rowIndex + 1}" action="">
> <t:updateActionListener property="#{rowCount}" value="#{testService.searchRow}" />
> </h:commandLink>
> any ideas?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (MYFACES-853) commandLink not working inside
dataList
Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-853?page=all ]
Martin Marinschek closed MYFACES-853:
-------------------------------------
> commandLink not working inside dataList
> ---------------------------------------
>
> Key: MYFACES-853
> URL: http://issues.apache.org/jira/browse/MYFACES-853
> Project: MyFaces
> Type: Bug
> Versions: 1.1.1
> Environment: WinXP,tomcat 5.5.9,myfaces-1.1.1,JDK 1.5
> Reporter: Alexander Traeder
> Assignee: Dennis Byrne
> Fix For: Nightly
> Attachments: api.txt, tomahawk.txt, tomahawk2.txt
>
> in following code fragement the action-method "testService.listenOnSelect" is never called:
> <%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
> <%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
> <%@ taglib uri="http://myfaces.apache.org/tomahawk" prefix="t"%>
> <f:subview id="test">
> <h:form id="testform">
> <h:panelGrid columns="1">
> <t:dataList id="datalist" style="standardList"
> var="test"
> value="#{testService.entries}"
> rowCountVar="rowCount"
> rowIndexVar="rowIndex"
> layout="unorderedList">
> <h:commandLink id="test_ref" value="#{rowIndex + 1}" action="#{testService.listenOnSelect}" />
> </t:dataList>
> </h:panelGrid>
> </h:form>
> </f:subview>
> after some testing i also tried the nightly build but with the same result
> also tried the following (working in other scenarios):
> <h:commandLink id="testref" immediate="true" value="#{rowIndex + 1}" action="">
> <t:updateActionListener property="#{rowCount}" value="#{testService.searchRow}" />
> </h:commandLink>
> any ideas?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-853) commandLink not working inside
dataList
Posted by "Dennis Byrne (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-853?page=comments#action_12362807 ]
Dennis Byrne commented on MYFACES-853:
--------------------------------------
Martin,
There is another one on dataList for update model http://issues.apache.org/jira/browse/MYFACES-1009 .
> commandLink not working inside dataList
> ---------------------------------------
>
> Key: MYFACES-853
> URL: http://issues.apache.org/jira/browse/MYFACES-853
> Project: MyFaces
> Type: Bug
> Versions: 1.1.1
> Environment: WinXP,tomcat 5.5.9,myfaces-1.1.1,JDK 1.5
> Reporter: Alexander Traeder
> Assignee: Martin Marinschek
> Fix For: Nightly
> Attachments: api.txt, tomahawk.txt, tomahawk2.txt
>
> in following code fragement the action-method "testService.listenOnSelect" is never called:
> <%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
> <%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
> <%@ taglib uri="http://myfaces.apache.org/tomahawk" prefix="t"%>
> <f:subview id="test">
> <h:form id="testform">
> <h:panelGrid columns="1">
> <t:dataList id="datalist" style="standardList"
> var="test"
> value="#{testService.entries}"
> rowCountVar="rowCount"
> rowIndexVar="rowIndex"
> layout="unorderedList">
> <h:commandLink id="test_ref" value="#{rowIndex + 1}" action="#{testService.listenOnSelect}" />
> </t:dataList>
> </h:panelGrid>
> </h:form>
> </f:subview>
> after some testing i also tried the nightly build but with the same result
> also tried the following (working in other scenarios):
> <h:commandLink id="testref" immediate="true" value="#{rowIndex + 1}" action="">
> <t:updateActionListener property="#{rowCount}" value="#{testService.searchRow}" />
> </h:commandLink>
> any ideas?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-853) commandLink not working inside
dataList
Posted by "Dennis Byrne (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-853?page=all ]
Dennis Byrne updated MYFACES-853:
---------------------------------
Attachment: tomahawk2.txt
> commandLink not working inside dataList
> ---------------------------------------
>
> Key: MYFACES-853
> URL: http://issues.apache.org/jira/browse/MYFACES-853
> Project: MyFaces
> Type: Bug
> Versions: 1.1.1
> Environment: WinXP,tomcat 5.5.9,myfaces-1.1.1,JDK 1.5
> Reporter: Alexander Traeder
> Attachments: api.txt, tomahawk.txt, tomahawk2.txt
>
> in following code fragement the action-method "testService.listenOnSelect" is never called:
> <%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
> <%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
> <%@ taglib uri="http://myfaces.apache.org/tomahawk" prefix="t"%>
> <f:subview id="test">
> <h:form id="testform">
> <h:panelGrid columns="1">
> <t:dataList id="datalist" style="standardList"
> var="test"
> value="#{testService.entries}"
> rowCountVar="rowCount"
> rowIndexVar="rowIndex"
> layout="unorderedList">
> <h:commandLink id="test_ref" value="#{rowIndex + 1}" action="#{testService.listenOnSelect}" />
> </t:dataList>
> </h:panelGrid>
> </h:form>
> </f:subview>
> after some testing i also tried the nightly build but with the same result
> also tried the following (working in other scenarios):
> <h:commandLink id="testref" immediate="true" value="#{rowIndex + 1}" action="">
> <t:updateActionListener property="#{rowCount}" value="#{testService.searchRow}" />
> </h:commandLink>
> any ideas?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-853) commandLink not working inside dataList
Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-853?page=comments#action_12360739 ]
Martin Marinschek commented on MYFACES-853:
-------------------------------------------
I wonder if you are using the Reference Implementation with the tomahawk-jar?
regards,
Martin
> commandLink not working inside dataList
> ---------------------------------------
>
> Key: MYFACES-853
> URL: http://issues.apache.org/jira/browse/MYFACES-853
> Project: MyFaces
> Type: Bug
> Versions: 1.1.1
> Environment: WinXP,tomcat 5.5.9,myfaces-1.1.1,JDK 1.5
> Reporter: Alexander Traeder
>
> in following code fragement the action-method "testService.listenOnSelect" is never called:
> <%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
> <%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
> <%@ taglib uri="http://myfaces.apache.org/tomahawk" prefix="t"%>
> <f:subview id="test">
> <h:form id="testform">
> <h:panelGrid columns="1">
> <t:dataList id="datalist" style="standardList"
> var="test"
> value="#{testService.entries}"
> rowCountVar="rowCount"
> rowIndexVar="rowIndex"
> layout="unorderedList">
> <h:commandLink id="test_ref" value="#{rowIndex + 1}" action="#{testService.listenOnSelect}" />
> </t:dataList>
> </h:panelGrid>
> </h:form>
> </f:subview>
> after some testing i also tried the nightly build but with the same result
> also tried the following (working in other scenarios):
> <h:commandLink id="testref" immediate="true" value="#{rowIndex + 1}" action="">
> <t:updateActionListener property="#{rowCount}" value="#{testService.searchRow}" />
> </h:commandLink>
> any ideas?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-853) commandLink not working inside
dataList
Posted by "Bruno Aranda (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-853?page=comments#action_12362194 ]
Bruno Aranda commented on MYFACES-853:
--------------------------------------
Dennis, about the test framework can you make a proposal in the dev mailing list? Thanks!
> commandLink not working inside dataList
> ---------------------------------------
>
> Key: MYFACES-853
> URL: http://issues.apache.org/jira/browse/MYFACES-853
> Project: MyFaces
> Type: Bug
> Versions: 1.1.1
> Environment: WinXP,tomcat 5.5.9,myfaces-1.1.1,JDK 1.5
> Reporter: Alexander Traeder
> Attachments: api.txt, tomahawk.txt
>
> in following code fragement the action-method "testService.listenOnSelect" is never called:
> <%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
> <%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
> <%@ taglib uri="http://myfaces.apache.org/tomahawk" prefix="t"%>
> <f:subview id="test">
> <h:form id="testform">
> <h:panelGrid columns="1">
> <t:dataList id="datalist" style="standardList"
> var="test"
> value="#{testService.entries}"
> rowCountVar="rowCount"
> rowIndexVar="rowIndex"
> layout="unorderedList">
> <h:commandLink id="test_ref" value="#{rowIndex + 1}" action="#{testService.listenOnSelect}" />
> </t:dataList>
> </h:panelGrid>
> </h:form>
> </f:subview>
> after some testing i also tried the nightly build but with the same result
> also tried the following (working in other scenarios):
> <h:commandLink id="testref" immediate="true" value="#{rowIndex + 1}" action="">
> <t:updateActionListener property="#{rowCount}" value="#{testService.searchRow}" />
> </h:commandLink>
> any ideas?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-853) commandLink not working inside
dataList
Posted by "Dennis Byrne (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-853?page=comments#action_12362809 ]
Dennis Byrne commented on MYFACES-853:
--------------------------------------
dataList inherits (from the dataTable component) the methods used to update the model. however these methods are looking for column components, which are not found under dataList.
> commandLink not working inside dataList
> ---------------------------------------
>
> Key: MYFACES-853
> URL: http://issues.apache.org/jira/browse/MYFACES-853
> Project: MyFaces
> Type: Bug
> Versions: 1.1.1
> Environment: WinXP,tomcat 5.5.9,myfaces-1.1.1,JDK 1.5
> Reporter: Alexander Traeder
> Assignee: Martin Marinschek
> Fix For: Nightly
> Attachments: api.txt, tomahawk.txt, tomahawk2.txt
>
> in following code fragement the action-method "testService.listenOnSelect" is never called:
> <%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
> <%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
> <%@ taglib uri="http://myfaces.apache.org/tomahawk" prefix="t"%>
> <f:subview id="test">
> <h:form id="testform">
> <h:panelGrid columns="1">
> <t:dataList id="datalist" style="standardList"
> var="test"
> value="#{testService.entries}"
> rowCountVar="rowCount"
> rowIndexVar="rowIndex"
> layout="unorderedList">
> <h:commandLink id="test_ref" value="#{rowIndex + 1}" action="#{testService.listenOnSelect}" />
> </t:dataList>
> </h:panelGrid>
> </h:form>
> </f:subview>
> after some testing i also tried the nightly build but with the same result
> also tried the following (working in other scenarios):
> <h:commandLink id="testref" immediate="true" value="#{rowIndex + 1}" action="">
> <t:updateActionListener property="#{rowCount}" value="#{testService.searchRow}" />
> </h:commandLink>
> any ideas?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-853) commandLink not working inside
dataList
Posted by "Bruno Aranda (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-853?page=comments#action_12362179 ]
Bruno Aranda commented on MYFACES-853:
--------------------------------------
Thanks Dennis, but I am afraid that this patch is not ok. We cannot change the visibility of API methods as they are defined by the spec. Otherwise myfaces would not be compatible with the RI. Maybe you could make a patch without modifying UIData (or at least without changing the visibility of its methods)?
> commandLink not working inside dataList
> ---------------------------------------
>
> Key: MYFACES-853
> URL: http://issues.apache.org/jira/browse/MYFACES-853
> Project: MyFaces
> Type: Bug
> Versions: 1.1.1
> Environment: WinXP,tomcat 5.5.9,myfaces-1.1.1,JDK 1.5
> Reporter: Alexander Traeder
> Attachments: api.txt, tomahawk.txt
>
> in following code fragement the action-method "testService.listenOnSelect" is never called:
> <%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
> <%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
> <%@ taglib uri="http://myfaces.apache.org/tomahawk" prefix="t"%>
> <f:subview id="test">
> <h:form id="testform">
> <h:panelGrid columns="1">
> <t:dataList id="datalist" style="standardList"
> var="test"
> value="#{testService.entries}"
> rowCountVar="rowCount"
> rowIndexVar="rowIndex"
> layout="unorderedList">
> <h:commandLink id="test_ref" value="#{rowIndex + 1}" action="#{testService.listenOnSelect}" />
> </t:dataList>
> </h:panelGrid>
> </h:form>
> </f:subview>
> after some testing i also tried the nightly build but with the same result
> also tried the following (working in other scenarios):
> <h:commandLink id="testref" immediate="true" value="#{rowIndex + 1}" action="">
> <t:updateActionListener property="#{rowCount}" value="#{testService.searchRow}" />
> </h:commandLink>
> any ideas?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-853) commandLink not working inside dataList
Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-853?page=comments#action_12360767 ]
Mike Kienenberger commented on MYFACES-853:
-------------------------------------------
It'd help if you'd post your t:saveState tag.
Hopefully, you're using it on testService.entries or testService. You cannot use it on test.
-Mike
> commandLink not working inside dataList
> ---------------------------------------
>
> Key: MYFACES-853
> URL: http://issues.apache.org/jira/browse/MYFACES-853
> Project: MyFaces
> Type: Bug
> Versions: 1.1.1
> Environment: WinXP,tomcat 5.5.9,myfaces-1.1.1,JDK 1.5
> Reporter: Alexander Traeder
>
> in following code fragement the action-method "testService.listenOnSelect" is never called:
> <%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
> <%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
> <%@ taglib uri="http://myfaces.apache.org/tomahawk" prefix="t"%>
> <f:subview id="test">
> <h:form id="testform">
> <h:panelGrid columns="1">
> <t:dataList id="datalist" style="standardList"
> var="test"
> value="#{testService.entries}"
> rowCountVar="rowCount"
> rowIndexVar="rowIndex"
> layout="unorderedList">
> <h:commandLink id="test_ref" value="#{rowIndex + 1}" action="#{testService.listenOnSelect}" />
> </t:dataList>
> </h:panelGrid>
> </h:form>
> </f:subview>
> after some testing i also tried the nightly build but with the same result
> also tried the following (working in other scenarios):
> <h:commandLink id="testref" immediate="true" value="#{rowIndex + 1}" action="">
> <t:updateActionListener property="#{rowCount}" value="#{testService.searchRow}" />
> </h:commandLink>
> any ideas?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-853) commandLink not working inside
dataList
Posted by "Simon Kitching (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-853?page=comments#action_12362254 ]
Simon Kitching commented on MYFACES-853:
----------------------------------------
Dennis: note that it's also forbidden to add any public class or interface to the javax.faces packages.
The existing utility classes in the API module are only package-scope, ie are not accessable from
anywhere except the same package.
Of course this problem does not occur for the Impl module, where utility classes are fine. However
api classes can't depend on anything in impl or commons.
> commandLink not working inside dataList
> ---------------------------------------
>
> Key: MYFACES-853
> URL: http://issues.apache.org/jira/browse/MYFACES-853
> Project: MyFaces
> Type: Bug
> Versions: 1.1.1
> Environment: WinXP,tomcat 5.5.9,myfaces-1.1.1,JDK 1.5
> Reporter: Alexander Traeder
> Attachments: api.txt, tomahawk.txt
>
> in following code fragement the action-method "testService.listenOnSelect" is never called:
> <%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
> <%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
> <%@ taglib uri="http://myfaces.apache.org/tomahawk" prefix="t"%>
> <f:subview id="test">
> <h:form id="testform">
> <h:panelGrid columns="1">
> <t:dataList id="datalist" style="standardList"
> var="test"
> value="#{testService.entries}"
> rowCountVar="rowCount"
> rowIndexVar="rowIndex"
> layout="unorderedList">
> <h:commandLink id="test_ref" value="#{rowIndex + 1}" action="#{testService.listenOnSelect}" />
> </t:dataList>
> </h:panelGrid>
> </h:form>
> </f:subview>
> after some testing i also tried the nightly build but with the same result
> also tried the following (working in other scenarios):
> <h:commandLink id="testref" immediate="true" value="#{rowIndex + 1}" action="">
> <t:updateActionListener property="#{rowCount}" value="#{testService.searchRow}" />
> </h:commandLink>
> any ideas?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-853) commandLink not working inside
dataList
Posted by "Dave (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-853?page=comments#action_12362805 ]
Dave commented on MYFACES-853:
------------------------------
I tested the latest build today for dataList.
<commandLink> works.
but <inputText> did not work. the setter method (setTitle) was never called during model update.
-------------TestBean.java --------------
import java.util.ArrayList;
import java.util.List;
public class TestBean {
private String name;
private List<Book> books;
public TestBean() {
books = new ArrayList<Book>();
for (int i=0; i<10; i++) {
books.add(new Book("Title" + i, "Author" + i));
}
}
public List<Book> getBooks() {
return books;
}
public void setBooks(List<Book> books) {
this.books = books;
}
public String getName() {
return name;
}
public void setName(String name) {
this.name = name;
}
public String clickLink() {
System.out.println("Clicked" );
return null;
}
}
-----------------Book.java -----------------
public class Book {
private String title;
private String author;
public Book() {
}
public Book(String title, String author) {
this.title = title;
this.author = author;
}
public String getAuthor() {
return author;
}
public void setAuthor(String author) {
this.author = author;
}
public String getTitle() {
return title;
}
public void setTitle(String title) {
this.title = title;
}
public String clickLink() {
System.out.println("Click: " + getTitle());
return null;
}
}
---------------------test.jsp --------------------------
<%@ page contentType="text/html; charset=UTF-8"%>
<%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
<%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
<%@ taglib uri="http://myfaces.apache.org/tomahawk" prefix="t"%>
<HTML>
<head>
</head>
<f:view>
<%-- test dataList --%>
<h:form>
<t:dataList id="books"
var="book"
value="#{testBean.books}"
layout="simple"
rowCountVar="rowCount"
rowIndexVar="rowIndex">
<h:commandLink value="#{book.title}"
action="#{book.clickLink}"/>
<f:verbatim> </f:verbatim>
<h:inputText value="#{book.title}"/>
<f:verbatim> </f:verbatim>
</t:dataList>
<h:commandButton value="Submit" />
</h:form>
</f:view>
</HTML>
> commandLink not working inside dataList
> ---------------------------------------
>
> Key: MYFACES-853
> URL: http://issues.apache.org/jira/browse/MYFACES-853
> Project: MyFaces
> Type: Bug
> Versions: 1.1.1
> Environment: WinXP,tomcat 5.5.9,myfaces-1.1.1,JDK 1.5
> Reporter: Alexander Traeder
> Assignee: Martin Marinschek
> Fix For: Nightly
> Attachments: api.txt, tomahawk.txt, tomahawk2.txt
>
> in following code fragement the action-method "testService.listenOnSelect" is never called:
> <%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
> <%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
> <%@ taglib uri="http://myfaces.apache.org/tomahawk" prefix="t"%>
> <f:subview id="test">
> <h:form id="testform">
> <h:panelGrid columns="1">
> <t:dataList id="datalist" style="standardList"
> var="test"
> value="#{testService.entries}"
> rowCountVar="rowCount"
> rowIndexVar="rowIndex"
> layout="unorderedList">
> <h:commandLink id="test_ref" value="#{rowIndex + 1}" action="#{testService.listenOnSelect}" />
> </t:dataList>
> </h:panelGrid>
> </h:form>
> </f:subview>
> after some testing i also tried the nightly build but with the same result
> also tried the following (working in other scenarios):
> <h:commandLink id="testref" immediate="true" value="#{rowIndex + 1}" action="">
> <t:updateActionListener property="#{rowCount}" value="#{testService.searchRow}" />
> </h:commandLink>
> any ideas?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira