[jira] Commented: (SHINDIG-795) Allow easier customization of LinkRewriter with Guice bindings

["Henning Schmiedehausen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHINDIG-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662843#action_12662843 ] 

Henning Schmiedehausen commented on SHINDIG-795:
------------------------------------------------

I might also comment here, that in many places, Shindig will be integrated with other pieces of code and container technologies. Guice 1.0 and Spring seem to have the widest adoption so immediately requiring Guice 2.0 only features would force integrators to either switch their code fully to Guice 2.0 (often very hard / impossible) or rewrite / rip out such parts.

I still believe that we should be as container agnostic as possible. So finding a solution that does not force a certain container upon the users is IMHO a good thing. 

(That is, if you consider Shindig a component library. If it is an opaque product that gets extended by adopters, this approach is probably fine. Still not really nice on integrators).

> Allow easier customization of LinkRewriter with Guice bindings
> --------------------------------------------------------------
>
>                 Key: SHINDIG-795
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-795
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Gadget Rendering Server (Java)
>            Reporter: chirag shah
>
> The default implementation of LinkRewriter is ProxyingLinkRewriter and it will rewrite a link to the form "http://www.host.com/proxy/url=<url encoded link>&gadget=<gadget spec url>&fp=<fingeprint of rewriting rule>" however, containers may want a custom implementation of LinkRewriter. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.