You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "rkdfx (via GitHub)" <gi...@apache.org> on 2026/06/13 18:04:30 UTC
[PR] CAMEL-23733: camel-jbang - Add properties syntax highlighting in TUI [camel]
rkdfx opened a new pull request, #24001:
URL: https://github.com/apache/camel/pull/24001
# Description
The `camel jbang` TUI source viewer (`SyntaxHighlighter`) highlighted Java, YAML and XML, but `.properties` files fell through to the plain-text path and were rendered with no color. This adds a `PROPERTIES` language so they are highlighted like the other formats.
- `detectLanguage` maps the `.properties` extension to a new `Language.PROPERTIES`.
- `highlightProperties` colors **key → yellow, value → blue, separator (`=`/`:`) → white-bold, comment (`#`/`!`) → light-blue** — the comment color reuses the convention already shared by the Java/YAML highlighters.
- Parsing follows `java.util.Properties` semantics: `=`/`:`/whitespace separators, escaped separators (`\=`), key-only lines, and leading indentation left unstyled.
- Adds `SyntaxHighlighterTest` (6 cases: color assignment + a round-trip invariant that highlighting never alters the line text). The module had no tests, so this pulls in the standard `camel-test-junit6` test dependency.
# Target
- [ ] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch)
# Tracking
- [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [ ] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [ ] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes.
<!--
You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23733: camel-jbang - Add properties syntax highlighting in TUI [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #24001:
URL: https://github.com/apache/camel/pull/24001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23733: camel-jbang - Add properties syntax highlighting in TUI [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24001:
URL: https://github.com/apache/camel/pull/24001#issuecomment-4701211634
<!-- ci-tested-modules -->
:test_tube: **CI tested the following changed modules:**
- `dsl/camel-jbang/camel-jbang-plugin-tui`
:white_check_mark: **POM dependency changes: targeted tests included**
<details><summary>Modules affected by dependency changes (1)</summary>
- `:camel-jbang-plugin-tui`
</details>
<details><summary>All tested modules (2 modules)</summary>
- Camel :: JBang :: Plugin :: TUI
- Camel :: Launcher :: Container
</details>
---
:gear: [View full build and test results](https://github.com/apache/camel/actions/runs/27474743428)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23733: camel-jbang - Add properties syntax highlighting in TUI [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24001:
URL: https://github.com/apache/camel/pull/24001#issuecomment-4701152596
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org