[jira] [Commented] (SLING-10571) Hardcoded application paths in VaultPackageUtils.detectPackageType

["Konrad Windszus (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17371263#comment-17371263 ] 

Konrad Windszus commented on SLING-10571:
-----------------------------------------

Well, JCRVLT-170 explicitly states: 
bq. The application packages have the characteristic that:... they only provide content to /apps, /libs (thus are instance private)

Also the logic is used in other places. If we really want to allow more paths in application type package we should start with a FileVault ticket over at Jackrabbit.

> Hardcoded application paths in VaultPackageUtils.detectPackageType
> ------------------------------------------------------------------
>
>                 Key: SLING-10571
>                 URL: https://issues.apache.org/jira/browse/SLING-10571
>             Project: Sling
>          Issue Type: Bug
>          Components: Content-Package to Feature Model Converter
>            Reporter: Angela Schreiber
>            Priority: Major
>
> while investigating SLING-10467 i noticed hardcoded paths for what should be considered application content in {{VaultPackageUtils.detectPackageType}}.
> the method looks as follows:
> {code}
> public static @NotNull PackageType detectPackageType(String path) {
>         if ("/apps".equals(path)
>                 || path.startsWith("/apps/")
>                 || "/libs".equals(path)
>                 || path.startsWith("/libs/")) {
>             return PackageType.APPLICATION;
>         } else {
>             return PackageType.CONTENT;
>         }
>     }
> {code}
> instead of hardcoding /apps and /libs which are details of Adobe AEM, these paths should be configured with the converter-launcher. in particular since the list looks a bit arbitrary as there are other paths that IMHO should be considered application content like nodetype registry, namespace registry, privilege registry, service users etc.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)