You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@uniffle.apache.org by xi...@apache.org on 2025/07/28 02:37:38 UTC

(uniffle) branch master updated: [MINOR] improvement(client): Simplify logging of heartbeat failures (#2559)

This is an automated email from the ASF dual-hosted git repository.

xianjingfeng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/uniffle.git


The following commit(s) were added to refs/heads/master by this push:
     new 850db71f1 [MINOR] improvement(client): Simplify logging of heartbeat failures (#2559)
850db71f1 is described below

commit 850db71f18ab2945fe2c2c392f1a9f9b56a65c6b
Author: xianjingfeng <xi...@gmail.com>
AuthorDate: Mon Jul 28 10:37:34 2025 +0800

    [MINOR] improvement(client): Simplify logging of heartbeat failures (#2559)
    
    ### What changes were proposed in this pull request?
    Simplify logging of heartbeat failures
    
    ### Why are the changes needed?
    The stack trace of abnormal heartbeats is not only useless, but interfere with troubleshooting.
    
    ### Does this PR introduce any user-facing change?
    No.
    
    ### How was this patch tested?
    CI
---
 .../java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java b/client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java
index 98fe30b98..b846dbb82 100644
--- a/client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java
+++ b/client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java
@@ -979,7 +979,11 @@ public class ShuffleWriteClientImpl implements ShuffleWriteClient {
               LOG.warn("Failed to send heartbeat to " + shuffleServerInfo);
             }
           } catch (Exception e) {
-            LOG.warn("Error happened when send heartbeat to " + shuffleServerInfo, e);
+            if (LOG.isDebugEnabled()) {
+              LOG.debug("Error happened when send heartbeat to " + shuffleServerInfo, e);
+            } else {
+              LOG.warn("Error happened when send heartbeat to " + shuffleServerInfo);
+            }
           }
           return null;
         },