You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Laszlo Gaal (Code Review)" <ge...@cloudera.org> on 2021/03/30 20:45:24 UTC

[Impala-ASF-CR] IMPALA-9331: Add symptom for dataload failing on schema mismatch 

Laszlo Gaal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17242


Change subject: IMPALA-9331: Add symptom for dataload failing on schema mismatch
......................................................................

IMPALA-9331: Add symptom for dataload failing on schema mismatch

Streamline triaging a bit. When this fails, it does so in a specific
location, and until now you had to scan the build log to find the
problem. This JUnitXML symptom should make this failure mode obvious.

Change-Id: I2fa193740a2764fdda799d6a9cc64f89cab64aba
---
M testdata/bin/create-load-data.sh
1 file changed, 7 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/17242/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2fa193740a2764fdda799d6a9cc64f89cab64aba
Gerrit-Change-Number: 17242
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>

[Impala-ASF-CR] IMPALA-9331: Add symptom for dataload failing on schema mismatch

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17242 )

Change subject: IMPALA-9331: Add symptom for dataload failing on schema mismatch
......................................................................


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7028/


-- 
To view, visit http://gerrit.cloudera.org:8080/17242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fa193740a2764fdda799d6a9cc64f89cab64aba
Gerrit-Change-Number: 17242
Gerrit-PatchSet: 3
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Mar 2021 15:56:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9331: Add symptom for dataload failing on schema mismatch

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17242

to look at the new patch set (#2).

Change subject: IMPALA-9331: Add symptom for dataload failing on schema mismatch
......................................................................

IMPALA-9331: Add symptom for dataload failing on schema mismatch

Streamline triaging a bit. When this fails, it does so in a specific
location, and until now you had to scan the build log to find the
problem. This JUnitXML symptom should make this failure mode obvious.

Tested by running an S3 build on private infrastructure with a knowingly
mismatched data snapshot.

Change-Id: I2fa193740a2764fdda799d6a9cc64f89cab64aba
---
M testdata/bin/create-load-data.sh
1 file changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/17242/2
-- 
To view, visit http://gerrit.cloudera.org:8080/17242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2fa193740a2764fdda799d6a9cc64f89cab64aba
Gerrit-Change-Number: 17242
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-9331: Add symptom for dataload failing on schema mismatch

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17242 )

Change subject: IMPALA-9331: Add symptom for dataload failing on schema mismatch
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7038/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/17242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fa193740a2764fdda799d6a9cc64f89cab64aba
Gerrit-Change-Number: 17242
Gerrit-PatchSet: 4
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Apr 2021 09:15:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9331: Add symptom for dataload failing on schema mismatch

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17242 )

Change subject: IMPALA-9331: Add symptom for dataload failing on schema mismatch
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fa193740a2764fdda799d6a9cc64f89cab64aba
Gerrit-Change-Number: 17242
Gerrit-PatchSet: 4
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Apr 2021 15:09:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9331: Add symptom for dataload failing on schema mismatch

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17242 )

Change subject: IMPALA-9331: Add symptom for dataload failing on schema mismatch
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/8466/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fa193740a2764fdda799d6a9cc64f89cab64aba
Gerrit-Change-Number: 17242
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Mar 2021 21:05:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9331: Add symptom for dataload failing on schema mismatch

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17242 )

Change subject: IMPALA-9331: Add symptom for dataload failing on schema mismatch
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7028/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/17242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fa193740a2764fdda799d6a9cc64f89cab64aba
Gerrit-Change-Number: 17242
Gerrit-PatchSet: 3
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Mar 2021 10:14:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9331: Add symptom for dataload failing on schema mismatch

Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17242 )

Change subject: IMPALA-9331: Add symptom for dataload failing on schema mismatch
......................................................................


Patch Set 2: Code-Review+2

LGTM, plus also useful


-- 
To view, visit http://gerrit.cloudera.org:8080/17242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fa193740a2764fdda799d6a9cc64f89cab64aba
Gerrit-Change-Number: 17242
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Mar 2021 21:05:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9331: Add symptom for dataload failing on schema mismatch

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/17242 )

Change subject: IMPALA-9331: Add symptom for dataload failing on schema mismatch
......................................................................


Patch Set 4: Code-Review+2

Rebased on current master, carry +2 from Andrew


-- 
To view, visit http://gerrit.cloudera.org:8080/17242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fa193740a2764fdda799d6a9cc64f89cab64aba
Gerrit-Change-Number: 17242
Gerrit-PatchSet: 4
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Apr 2021 09:15:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9331: Add symptom for dataload failing on schema mismatch

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17242 )

Change subject: IMPALA-9331: Add symptom for dataload failing on schema mismatch
......................................................................

IMPALA-9331: Add symptom for dataload failing on schema mismatch

Streamline triaging a bit. When this fails, it does so in a specific
location, and until now you had to scan the build log to find the
problem. This JUnitXML symptom should make this failure mode obvious.

Tested by running an S3 build on private infrastructure with a knowingly
mismatched data snapshot.

Change-Id: I2fa193740a2764fdda799d6a9cc64f89cab64aba
Reviewed-on: http://gerrit.cloudera.org:8080/17242
Reviewed-by: Laszlo Gaal <la...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/bin/create-load-data.sh
1 file changed, 7 insertions(+), 0 deletions(-)

Approvals:
  Laszlo Gaal: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/17242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2fa193740a2764fdda799d6a9cc64f89cab64aba
Gerrit-Change-Number: 17242
Gerrit-PatchSet: 5
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>

[Impala-ASF-CR] IMPALA-9331: Add symptom for dataload failing on schema mismatch

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17242 )

Change subject: IMPALA-9331: Add symptom for dataload failing on schema mismatch
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fa193740a2764fdda799d6a9cc64f89cab64aba
Gerrit-Change-Number: 17242
Gerrit-PatchSet: 3
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Mar 2021 10:14:00 +0000
Gerrit-HasComments: No