You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/12/02 12:22:43 UTC
[GitHub] [incubator-yunikorn-core] sunilgovind commented on a change in pull request #223: YUNIKORN-415: Add "queues" REST API to fetch list of queues
sunilgovind commented on a change in pull request #223:
URL: https://github.com/apache/incubator-yunikorn-core/pull/223#discussion_r534125650
##########
File path: pkg/scheduler/objects/queue.go
##########
@@ -401,6 +401,28 @@ func (sq *Queue) GetQueueInfos() dao.QueueDAOInfo {
return queueInfo
}
+func (sq *Queue) GetPartitionQueues() dao.PartitionQueueDAOInfo {
+ queueInfo := dao.PartitionQueueDAOInfo{}
+ if len(sq.children) > 0 {
+ for _, child := range sq.GetCopyOfChildren() {
+ queueInfo.Children = append(queueInfo.Children, child.GetPartitionQueues())
+ }
+ }
+ queueInfo.QueueName = sq.GetQueuePath()
+ queueInfo.Status = sq.stateMachine.Current()
Review comment:
Looks good
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org