You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/26 07:40:39 UTC
[GitHub] [arrow-datafusion] metesynnada opened a new pull request, #3965: Bug fix on DFField to Field conversion
metesynnada opened a new pull request, #3965:
URL: https://github.com/apache/arrow-datafusion/pull/3965
# Which issue does this PR close?
Closes #3964.
# Rationale for this change
While converting `DFSchema` to `Schema`, field metadata is not preserved. It may cause future bugs on methods like `alias`.
# What changes are included in this PR?
Changing `From<DFSchema> for Schema` method.
# Are there any user-facing changes?
NA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove merged pull request #3965: Bug fix on DFField to Field conversion: preserve metadata
Posted by GitBox <gi...@apache.org>.
andygrove merged PR #3965:
URL: https://github.com/apache/arrow-datafusion/pull/3965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #3965: Bug fix on DFField to Field conversion: preserve metadata
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3965:
URL: https://github.com/apache/arrow-datafusion/pull/3965#issuecomment-1293861346
Benchmark runs are scheduled for baseline = 8792a0145e6da4e2c013a1c640c5d5fdfbfcf18a and contender = e73a43cd6ef1d33feb9214d29843a768477a62b0. e73a43cd6ef1d33feb9214d29843a768477a62b0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/3fa60ef8f8214335ad14902df09a4a9e...8e0998d0dcfa418c914040474a8c7bab/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/1f6bea4308244a42864c56ada58500eb...d5d6219f24ee453680e922a01ea82b2f/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/0dccbf9787514e5da9f007abb63012e3...116e84e2f18f450eab614219346c1825/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/6196e2c1753a46f7863c202141c74efc...a7363848a88942458d7413102f3f4d08/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #3965: Bug fix on DFField to Field conversion: preserve metadata
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #3965:
URL: https://github.com/apache/arrow-datafusion/pull/3965#discussion_r1006990108
##########
datafusion/common/src/dfschema.rs:
##########
@@ -367,21 +367,7 @@ impl From<DFSchema> for Schema {
/// Convert DFSchema into a Schema
fn from(df_schema: DFSchema) -> Self {
Schema::new_with_metadata(
- df_schema
- .fields
- .into_iter()
- .map(|f| {
- if f.qualifier().is_some() {
- Field::new(
- f.name().as_str(),
- f.data_type().to_owned(),
- f.is_nullable(),
- )
- } else {
- f.field
- }
- })
- .collect(),
+ df_schema.fields.into_iter().map(|f| f.field).collect(),
Review Comment:
💯 for fixing a bug by deleting code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org