You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "David Jencks (JIRA)" <ji...@apache.org> on 2011/06/14 02:22:47 UTC

[jira] [Created] (OPENEJB-1578) cdi introduces constructor injection

cdi introduces constructor injection
------------------------------------

                 Key: OPENEJB-1578
                 URL: https://issues.apache.org/jira/browse/OPENEJB-1578
             Project: OpenEJB
          Issue Type: Bug
          Components: container system
    Affects Versions: 4.0
            Reporter: David Jencks
            Assignee: David Jencks
             Fix For: 4.0


ejbs can get constructor injection in cdi.  The test is org.jboss.jsr299.tck.tests.implementation.enterprise.definition.EnterpriseBeanDefinitionTest.testConstructorAnnotatedInjectCalled

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (OPENEJB-1578) EJB Constructor Injection via CDI

Posted by "David Jencks (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENEJB-1578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Jencks updated OPENEJB-1578:
----------------------------------

    Attachment: OPENEJB-1578.patch

The patch fixes the OWB issue and seems OK to me, however web beans constructor injection conflicts with pre-existing openejb constructor injection.  You can only inject beans that actually exist, not environment entries or beans that don't exist.  I've modified the StatelessConstructorInjectionTest to pass with the new code: the corresponding StatefulConstructorInjectionTest would presumably need a similar change.  I need advice on how to proceed.

> EJB Constructor Injection via CDI
> ---------------------------------
>
>                 Key: OPENEJB-1578
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-1578
>             Project: OpenEJB
>          Issue Type: Sub-task
>          Components: container system
>    Affects Versions: 4.0-beta-1
>            Reporter: David Jencks
>            Assignee: David Jencks
>             Fix For: 4.0-beta-1
>
>         Attachments: OPENEJB-1578.patch
>
>
> ejbs can get constructor injection in cdi.  The test is org.jboss.jsr299.tck.tests.implementation.enterprise.definition.EnterpriseBeanDefinitionTest.testConstructorAnnotatedInjectCalled

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OPENEJB-1578) EJB Constructor Injection via CDI

Posted by "David Jencks (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OPENEJB-1578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049037#comment-13049037 ] 

David Jencks commented on OPENEJB-1578:
---------------------------------------

After some discussion with dblevins, committed in rev 1135397.

Limitations:

1. mdbs do not have cdi constructor injection yet.
2. the old constructor injection tests have injection of a env-entry and datasource disabled.  We can probably use a producer field or method to supply them.

> EJB Constructor Injection via CDI
> ---------------------------------
>
>                 Key: OPENEJB-1578
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-1578
>             Project: OpenEJB
>          Issue Type: Sub-task
>          Components: container system
>    Affects Versions: 4.0-beta-1
>            Reporter: David Jencks
>            Assignee: David Jencks
>             Fix For: 4.0-beta-1
>
>         Attachments: OPENEJB-1578.patch
>
>
> ejbs can get constructor injection in cdi.  The test is org.jboss.jsr299.tck.tests.implementation.enterprise.definition.EnterpriseBeanDefinitionTest.testConstructorAnnotatedInjectCalled

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (OPENEJB-1578) cdi introduces constructor injection

Posted by "David Blevins (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENEJB-1578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Blevins updated OPENEJB-1578:
-----------------------------------

    Issue Type: Sub-task  (was: Bug)
        Parent: OPENEJB-1197

> cdi introduces constructor injection
> ------------------------------------
>
>                 Key: OPENEJB-1578
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-1578
>             Project: OpenEJB
>          Issue Type: Sub-task
>          Components: container system
>    Affects Versions: 4.0
>            Reporter: David Jencks
>            Assignee: David Jencks
>             Fix For: 4.0
>
>
> ejbs can get constructor injection in cdi.  The test is org.jboss.jsr299.tck.tests.implementation.enterprise.definition.EnterpriseBeanDefinitionTest.testConstructorAnnotatedInjectCalled

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (OPENEJB-1578) EJB Constructor Injection via CDI

Posted by "David Blevins (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENEJB-1578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Blevins resolved OPENEJB-1578.
------------------------------------

    Resolution: Fixed

> EJB Constructor Injection via CDI
> ---------------------------------
>
>                 Key: OPENEJB-1578
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-1578
>             Project: OpenEJB
>          Issue Type: Sub-task
>          Components: container system
>    Affects Versions: 4.0-beta-1
>            Reporter: David Jencks
>            Assignee: David Jencks
>             Fix For: 4.0-beta-1
>
>         Attachments: OPENEJB-1578.patch
>
>
> ejbs can get constructor injection in cdi.  The test is org.jboss.jsr299.tck.tests.implementation.enterprise.definition.EnterpriseBeanDefinitionTest.testConstructorAnnotatedInjectCalled

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (OPENEJB-1578) EJB Constructor Injection via CDI

Posted by "David Blevins (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENEJB-1578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Blevins updated OPENEJB-1578:
-----------------------------------

    Affects Version/s:     (was: 4.0)
                       4.0-beta-1
        Fix Version/s:     (was: 4.0)
                       4.0-beta-1
              Summary: EJB Constructor Injection via CDI  (was: cdi introduces constructor injection)

> EJB Constructor Injection via CDI
> ---------------------------------
>
>                 Key: OPENEJB-1578
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-1578
>             Project: OpenEJB
>          Issue Type: Sub-task
>          Components: container system
>    Affects Versions: 4.0-beta-1
>            Reporter: David Jencks
>            Assignee: David Jencks
>             Fix For: 4.0-beta-1
>
>
> ejbs can get constructor injection in cdi.  The test is org.jboss.jsr299.tck.tests.implementation.enterprise.definition.EnterpriseBeanDefinitionTest.testConstructorAnnotatedInjectCalled

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira