You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Xi Wang <xw...@hortonworks.com> on 2014/11/19 21:55:12 UTC
Review Request 28259: Remove legacy Nagios alerts code from Ambari Web
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28259/
-----------------------------------------------------------
Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
Bugs: AMBARI-8388
https://issues.apache.org/jira/browse/AMBARI-8388
Repository: ambari
Description
-------
Nagios is no longer available as a service in trunk.
Ambari Web needs to remove calls to get legacy_alerts, as this will no longer work once the server code removes the provider for Nagios alerts.
As part of this ticket, remove legacy_alerts from being requested and make sure that the general UI does not break.
Diffs
-----
ambari-web/app/controllers.js 7c6db41
ambari-web/app/controllers/global/update_controller.js a220e01
ambari-web/app/controllers/main/alerts_controller.js b28f711
ambari-web/app/controllers/main/host.js dc966db
ambari-web/app/messages.js 33a36bd
ambari-web/app/routes/main.js 058533c
ambari-web/app/templates/main/dashboard/alert_notification_popup.hbs 8a37e23
ambari-web/app/templates/main/host/alerts_popup.hbs 247753a
ambari-web/app/templates/main/service/info/summary.hbs 8ccc64e
ambari-web/app/utils/ajax/ajax.js b271a10
ambari-web/app/views/main/dashboard/widgets.js 29b7063
ambari-web/app/views/main/service/info/summary.js 99c049b
Diff: https://reviews.apache.org/r/28259/diff/
Testing
-------
tested
Thanks,
Xi Wang
Re: Review Request 28259: Remove legacy Nagios alerts code from
Ambari Web
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28259/#review62671
-----------------------------------------------------------
Ship it!
Ship It!
- Jaimin Jetly
On Nov. 21, 2014, 10:35 p.m., Xi Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28259/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2014, 10:35 p.m.)
>
>
> Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
>
>
> Bugs: AMBARI-8388
> https://issues.apache.org/jira/browse/AMBARI-8388
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Nagios is no longer available as a service in trunk.
> Ambari Web needs to remove calls to get legacy_alerts, as this will no longer work once the server code removes the provider for Nagios alerts.
> As part of this ticket, remove legacy_alerts from being requested and make sure that the general UI does not break.
>
>
> Diffs
> -----
>
> ambari-web/app/assets/test/tests.js c831716
> ambari-web/app/controllers.js c4385ce
> ambari-web/app/controllers/global/update_controller.js bfb625c
> ambari-web/app/controllers/main/alerts_controller.js b28f711
> ambari-web/app/controllers/main/host.js dc966db
> ambari-web/app/messages.js 9943582
> ambari-web/app/routes/main.js 361312b
> ambari-web/app/templates/main/dashboard/alert_notification_popup.hbs 8a37e23
> ambari-web/app/templates/main/host/alerts_popup.hbs 247753a
> ambari-web/app/templates/main/service/info/summary.hbs 8ccc64e
> ambari-web/app/utils/ajax/ajax.js d4a8402
> ambari-web/app/views/main/dashboard/widgets.js 29b7063
> ambari-web/app/views/main/service/info/summary.js 99c049b
> ambari-web/test/controllers/main/alerts_controller_test.js aee782a
> ambari-web/test/views/main/service/info/summary_test.js f64ee18
>
> Diff: https://reviews.apache.org/r/28259/diff/
>
>
> Testing
> -------
>
> tested
>
>
> Thanks,
>
> Xi Wang
>
>
Re: Review Request 28259: Remove legacy Nagios alerts code from
Ambari Web
Posted by Xi Wang <xw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28259/
-----------------------------------------------------------
(Updated Nov. 21, 2014, 2:35 p.m.)
Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
Changes
-------
In this patch, legacy_alerts will be completedly removed from UI.
Including legacy_alerts calls, controller, and related view and unit tests.
Bugs: AMBARI-8388
https://issues.apache.org/jira/browse/AMBARI-8388
Repository: ambari
Description
-------
Nagios is no longer available as a service in trunk.
Ambari Web needs to remove calls to get legacy_alerts, as this will no longer work once the server code removes the provider for Nagios alerts.
As part of this ticket, remove legacy_alerts from being requested and make sure that the general UI does not break.
Diffs (updated)
-----
ambari-web/app/assets/test/tests.js c831716
ambari-web/app/controllers.js c4385ce
ambari-web/app/controllers/global/update_controller.js bfb625c
ambari-web/app/controllers/main/alerts_controller.js b28f711
ambari-web/app/controllers/main/host.js dc966db
ambari-web/app/messages.js 9943582
ambari-web/app/routes/main.js 361312b
ambari-web/app/templates/main/dashboard/alert_notification_popup.hbs 8a37e23
ambari-web/app/templates/main/host/alerts_popup.hbs 247753a
ambari-web/app/templates/main/service/info/summary.hbs 8ccc64e
ambari-web/app/utils/ajax/ajax.js d4a8402
ambari-web/app/views/main/dashboard/widgets.js 29b7063
ambari-web/app/views/main/service/info/summary.js 99c049b
ambari-web/test/controllers/main/alerts_controller_test.js aee782a
ambari-web/test/views/main/service/info/summary_test.js f64ee18
Diff: https://reviews.apache.org/r/28259/diff/
Testing
-------
tested
Thanks,
Xi Wang
Re: Review Request 28259: Remove legacy Nagios alerts code from
Ambari Web
Posted by Xi Wang <xw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28259/
-----------------------------------------------------------
(Updated Nov. 20, 2014, 12:22 p.m.)
Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
Bugs: AMBARI-8388
https://issues.apache.org/jira/browse/AMBARI-8388
Repository: ambari
Description
-------
Nagios is no longer available as a service in trunk.
Ambari Web needs to remove calls to get legacy_alerts, as this will no longer work once the server code removes the provider for Nagios alerts.
As part of this ticket, remove legacy_alerts from being requested and make sure that the general UI does not break.
Diffs (updated)
-----
ambari-web/app/assets/test/tests.js c831716
ambari-web/app/controllers.js c4385ce
ambari-web/app/controllers/global/update_controller.js bfb625c
ambari-web/app/controllers/main/alerts_controller.js b28f711
ambari-web/app/controllers/main/host.js dc966db
ambari-web/app/messages.js 9943582
ambari-web/app/routes/main.js 361312b
ambari-web/app/templates/main/dashboard/alert_notification_popup.hbs 8a37e23
ambari-web/app/templates/main/host/alerts_popup.hbs 247753a
ambari-web/app/templates/main/service/info/summary.hbs 8ccc64e
ambari-web/app/utils/ajax/ajax.js d4a8402
ambari-web/app/views/main/dashboard/widgets.js 29b7063
ambari-web/app/views/main/service/info/summary.js 99c049b
ambari-web/test/controllers/main/alerts_controller_test.js aee782a
ambari-web/test/views/main/service/info/summary_test.js f64ee18
Diff: https://reviews.apache.org/r/28259/diff/
Testing
-------
tested
Thanks,
Xi Wang