[GitHub] [hadoop] ZanderXu commented on a diff in pull request #4821: HDFS-16750. NameNode should use NameNode.getRemoteUser() to log audit event to avoid possible NPE

[GitBox <gi...@apache.org>]

ZanderXu commented on code in PR #4821:
URL: https://github.com/apache/hadoop/pull/4821#discussion_r957930476


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java:
##########
@@ -1439,7 +1440,7 @@ private void checkSuperuserPrivilege() throws IOException, AccessControlExceptio
       return;
     }
     // Try to get the ugi in the RPC call.
-    UserGroupInformation callerUgi = ipcServer.getRemoteUser();
+    UserGroupInformation callerUgi = Server.getRemoteUser();

Review Comment:
   @tomscut Sir, thanks for you review. I'm sorry to get your idea. Can you explain it detailed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org