You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/04 06:11:47 UTC

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #7406: add event http receiver

kezhenxu94 commented on a change in pull request #7406:
URL: https://github.com/apache/skywalking/pull/7406#discussion_r682315496



##########
File path: docs/en/concepts-and-designs/event.md
##########
@@ -13,6 +13,7 @@ Currently, the officially supported clients to report events are:
 - [ ] Java Agent Toolkit: Using the Java agent toolkit to report events within the applications.
 - [x] SkyWalking CLI: Using the CLI to report events from the command line interface.
 - [x] [Kubernetes Event Exporter](http://github.com/apache/skywalking-kubernetes-event-exporter): Deploying an event exporter to refine and report Kubernetes events.
+- [x] HTTP Client: Using the HTTP Client to report events within the applications. 

Review comment:
       This is kind of misleading, this list is "clients" but we don't provide "HTTP client" for event reporter. This PR only accepts event data from HTTP protocol, itself doesn't provide an HTTP client to report events.
   
   I think line 10 has already covered the http protocol.
   
   > The SkyWalking backend supports three protocols to collect events: gRPC, HTTP, and Kafka. Any agent or CLI that implements one of these protocols can report events to SkyWalking.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org