You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/10/13 17:41:00 UTC
[jira] [Commented] (MAPREDUCE-7411) Use secure XML parser utils in MapReduce
[ https://issues.apache.org/jira/browse/MAPREDUCE-7411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617217#comment-17617217 ]
ASF GitHub Bot commented on MAPREDUCE-7411:
-------------------------------------------
steveloughran commented on code in PR #4980:
URL: https://github.com/apache/hadoop/pull/4980#discussion_r994940937
##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestQueueConfigurationParser.java:
##########
@@ -28,12 +28,13 @@
import javax.xml.transform.dom.DOMSource;
import javax.xml.transform.stream.StreamResult;
-import org.w3c.dom.Document;
Review Comment:
just leave these imports alone; it makes backporting harder than it needs to be
##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/QueueConfigurationParser.java:
##########
@@ -88,7 +91,7 @@ class QueueConfigurationParser {
static final String VALUE_TAG = "value";
/**
- * Default constructor for DeperacatedQueueConfigurationParser
+ * Default constructor for QueueConfigurationParser
Review Comment:
can you add a . at the end if you are going near this line
> Use secure XML parser utils in MapReduce
> ----------------------------------------
>
> Key: MAPREDUCE-7411
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7411
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: PJ Fanning
> Priority: Major
> Labels: pull-request-available
>
> Uptake of HADOOP-18469
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-help@hadoop.apache.org