[GitHub] villebro commented on a change in pull request #6187: add new db engine specs for sap hana database

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #6187: add new db engine specs for sap hana database
URL: https://github.com/apache/incubator-superset/pull/6187#discussion_r251189543
 
 

 ##########
 File path: superset/db_engine_specs.py
 ##########
 @@ -525,6 +525,10 @@ def convert_dttm(cls, target_type, dttm):
             """TO_TIMESTAMP('{}', 'YYYY-MM-DD"T"HH24:MI:SS.ff6')"""
         ).format(dttm.isoformat())
 
+class HanaEngineSpec(BaseEngineSpec):
+    engine = 'hana'
+    utils.DTTM_ALIAS = '"_timestamp"'
 
 Review comment:
   There was a bug in the forced quoting logic of the `_timestamp` label back when this PR was done. @shijizhi if you rebase the PR the above line should not be necessary anymore.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org