You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "shuan1026 (via GitHub)" <gi...@apache.org> on 2026/08/24 15:56:58 UTC

[PR] HDDS-11355. Remove Flaky tag from testMultiBlockWritesWithIntermittentDnFailures [ozone]

shuan1026 opened a new pull request, #11101:
URL: https://github.com/apache/ozone/pull/11101

   ### What changes were proposed in this pull request?
   
   This removes the `@Flaky("HDDS-11355")` annotation from
   `TestMultiBlockWritesWithDnFailures#testMultiBlockWritesWithIntermittentDnFailures`.
   
   The test was marked flaky after a single intermittent failure (`StorageContainerException: Unable to find the block with bcsID ...`. To check whether the underlying race is still present, the test was re-run 700 times against current master:
   
   | Run | Iterations × Splits | Failures |
   |---|---|---|
   | [[32617217787](https://github.com/shuan1026/ozone/actions/runs/32617217787)] | 10×10 = 100 | 0 |
   | [[32618658358](https://github.com/shuan1026/ozone/actions/runs/32618658358)] | 10×20 = 200 | 0 |
   | [[32629728164](https://github.com/shuan1026/ozone/actions/runs/32629728164)] | 20×20 = 400 | 0 |
   | **Total** | **700** | **0** |
   
   No failures were reproduced, and a review of the commits touching this test since it was flagged found only cosmetic changes (renames, license-header fixes, a mechanical switch to a global JUnit5 timeout) no real fix for a race condition. Given the zero-failure rate over 700 runs and no further failure reports since, this proposes removing the flaky tag rather than leaving the test permanently skipped.
   
   ### What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-11355
   
   ### How was this patch tested?
   
   Via `workflow_dispatch` on a fork, running the test 700 times on current master with zero failures.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-11355. Remove Flaky tag from testMultiBlockWritesWithIntermittentDnFailures [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #11101:
URL: https://github.com/apache/ozone/pull/11101


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-11355. Remove Flaky tag from testMultiBlockWritesWithIntermittentDnFailures [ozone]

Posted by "shuan1026 (via GitHub)" <gi...@apache.org>.
shuan1026 commented on PR #11101:
URL: https://github.com/apache/ozone/pull/11101#issuecomment-5410082106

   > Thanks @shuan1026 for the patch. Can you please also run `TestMultiBlockWritesWithDnFailures#ALL` in flaky test check to confirm there is no interaction between the test cases?
   
   thanks @adoroszlai 
   
   I ran `TestMultiBlockWritesWithDnFailures#ALL` in the flaky test check, and all tests passed:
   https://github.com/shuan1026/ozone/actions/runs/32841817994
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-11355. Remove Flaky tag from testMultiBlockWritesWithIntermittentDnFailures [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #11101:
URL: https://github.com/apache/ozone/pull/11101#issuecomment-5409420021

   Thanks @shuan1026 for the patch.  Can you please also run `TestMultiBlockWritesWithDnFailures#ALL` in flaky test check to confirm there is no interaction between the test cases?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org