[GitHub] [incubator-druid] leventov commented on issue #7073: Remove unnecessary check for contains() in LoadRule

[GitBox <gi...@apache.org>]

leventov commented on issue #7073: Remove unnecessary check for contains() in LoadRule
URL: https://github.com/apache/incubator-druid/pull/7073#issuecomment-469296307
 
 
   Note that a similar check can *not* be removed (currently) in `DruidCoordinatorBalancer`, here:
   https://github.com/apache/incubator-druid/blob/050728b11591865991591f5ae571be009cf9bbf8/server/src/main/java/org/apache/druid/server/coordinator/helper/DruidCoordinatorBalancer.java#L182-L184
   
   Because ServerHolder's data in `toMoveFrom` and "availableSegments" originate from two different sources: `ServerInventoryView` (see [`CoordinatorHistoricalManagerRunnable `](https://github.com/apache/incubator-druid/blob/050728b11591865991591f5ae571be009cf9bbf8/server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinator.java#L677)) and `MetadataSegmentManager` (see `DruidCoordinatorSegmentInfoLoader`) respectively.
   
   (Perhaps it could be optimized somehow, I didn't think about that.)
   
   So I think the check in `LoadRule` was added by analogy.
   
   @samarthjain could you please add a comment to the check in `DruidCoordinatorBalancer` explaining this matter?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org