[jira] [Commented] (MESOS-7618) CMake files incompatible with multi-configuration generators

["Andrew Schwartzmeyer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-7618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036055#comment-16036055 ] 

Andrew Schwartzmeyer commented on MESOS-7618:
---------------------------------------------

Sometimes `CMAKE_BUILD_TYPE` can be replaced with the generator expression `$<CONFIG>`, but that is dependent on the location being able to accept a generator expression https://cmake.org/cmake/help/latest/manual/cmake-generator-expressions.7.html.

Other times the use wasn't necessary at all, such as with library directories, where on Windows CMake intelligently appends the configuration for you.

> CMake files incompatible with multi-configuration generators
> ------------------------------------------------------------
>
>                 Key: MESOS-7618
>                 URL: https://issues.apache.org/jira/browse/MESOS-7618
>             Project: Mesos
>          Issue Type: Bug
>          Components: cmake
>         Environment: Windows
>            Reporter: Andrew Schwartzmeyer
>            Assignee: Andrew Schwartzmeyer
>              Labels: cmake, windows
>
> This is a large issue covering the invalid conditional logic based on `CMAKE_BUILD_TYPE` that breaks compatibility with multi-configuration generators (e.g. Visual Studio) where the configuration can be chosen at build time. Put another way, this bug also covers all the work necessary to enable a Release configuration on Windows.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)