You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by calavera <gi...@git.apache.org> on 2016/10/26 21:45:36 UTC

[GitHub] trafficserver pull request #1147: [TS-4855] Make `const char` consistent acc...

GitHub user calavera opened a pull request:

    https://github.com/apache/trafficserver/pull/1147

    [TS-4855] Make `const char` consistent accross the project.

    This change makes `const char` the default format before `char const`.
    Searching through the code, it looks like there are more usages of `const char`, so it looks normal and easier to adopt that terminology:
    
    ```
    \u279c  trafficserver git:(fix_const_char_inconsistency) ag 'char const' -o --nogroup | wc -l
    577
    \u279c  trafficserver git:(fix_const_char_inconsistency) ag 'const char' -o --nogroup | wc -l                                                                           
    6897
    \u279c  trafficserver git:(fix_const_char_inconsistency)
    ```
    
    Signed-off-by: David Calavera <da...@gmail.com>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/calavera/trafficserver fix_const_char_inconsistency

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/1147.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1147
    
----
commit 471d9ec72e2ae5f1994ce3afae58fd2fbe5e16af
Author: David Calavera <da...@gmail.com>
Date:   2016-10-26T21:41:59Z

    [TS-4855] Make `const char` consistent accross the project.
    
    Signed-off-by: David Calavera <da...@gmail.com>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1147: TS-4855: Make `const char` consistent acro...

Posted by jpeach <gi...@git.apache.org>.
Github user jpeach closed the pull request at:

    https://github.com/apache/trafficserver/pull/1147


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1147: TS-4855: Make `const char` consistent across the ...

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/1147
  
    Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/988/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1147: TS-4855: Make `const char` consistent across the ...

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/1147
  
    FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1096/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1147: [TS-4855] Make `const char` consistent accross th...

Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:

    https://github.com/apache/trafficserver/pull/1147
  
    [approve ci]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---