[jira] [Commented] (HADOOP-9844) NPE when trying to create an error message response of RPC

["Steve Loughran (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-9844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15089533#comment-15089533 ] 

Steve Loughran commented on HADOOP-9844:
----------------------------------------

Reviewing the stack traces and causes, {{setupResponse()}} assumes that on an RPC failure it has a non-null message. {{ doSaslReply(Message message)}} doesn't always do this .. it should set things up. There's also another place calling IOE.getMessage() for the message, something that should fall back to IOE.toString().

I'll do that and add a final sanity check in {{setupResponse()}} which sets the error to "error" if nothing else. 

> NPE when trying to create an error message response of RPC
> ----------------------------------------------------------
>
>                 Key: HADOOP-9844
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9844
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc
>    Affects Versions: 2.7.1, 3.0.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>              Labels: BB2015-05-TBR
>         Attachments: HADOOP-9844-001.patch
>
>
> I'm seeing an NPE which is raised when the server is trying to create an error response to send back to the caller and there is no error text.
> The root cause is probably somewhere in SASL, but sending something back to the caller would seem preferable to NPE-ing server-side.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)