You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "maytasm (via GitHub)" <gi...@apache.org> on 2023/05/05 07:00:46 UTC

[GitHub] [spark] maytasm opened a new pull request, #41061: [SPARK-43337][UI][3.4] Asc/desc arrow icons for sorting column does n…

maytasm opened a new pull request, #41061:
URL: https://github.com/apache/spark/pull/41061

   ### What changes were proposed in this pull request? Remove css `!important` tag for asc/desc arrow icons in jquery.dataTables.1.10.25.min.css
   
   ### Why are the changes needed?
   Upgrading to DataTables 1.10.25 broke asc/desc arrow icons for sorting column. The sorting icon is not displayed when the column is clicked to sort by asc/desc. This is because the new DataTables 1.10.25's jquery.dataTables.1.10.25.min.css file added `!important` rule preventing the override set in webui-dataTables.css
   
   ### Does this PR introduce _any_ user-facing change? No.
   
   ### How was this patch tested?
   Manual test.
   
   ![image](https://user-images.githubusercontent.com/52679095/236394863-e0004e7b-5173-495a-af23-32c1343e0ee6.png)
   ![image](https://user-images.githubusercontent.com/52679095/236394879-db0e5e0e-f6b3-48c3-9c79-694dd9abcb76.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen closed pull request #41061: [SPARK-43337][UI][3.4] Asc/desc arrow icons for sorting column does not get displayed in the table column

Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen closed pull request #41061: [SPARK-43337][UI][3.4] Asc/desc arrow icons for sorting column does not get displayed in the table column
URL: https://github.com/apache/spark/pull/41061


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen commented on pull request #41061: [SPARK-43337][UI][3.4] Asc/desc arrow icons for sorting column does not get displayed in the table column

Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #41061:
URL: https://github.com/apache/spark/pull/41061#issuecomment-1536423360

   Merged to 3.4


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org