You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by gr...@apache.org on 2006/04/10 21:33:14 UTC
svn commit: r393032 - /httpd/httpd/branches/2.0.x/STATUS
Author: gregames
Date: Mon Apr 10 12:33:12 2006
New Revision: 393032
URL: http://svn.apache.org/viewcvs?rev=393032&view=rev
Log:
vote for a backport
Modified:
httpd/httpd/branches/2.0.x/STATUS
Modified: httpd/httpd/branches/2.0.x/STATUS
URL: http://svn.apache.org/viewcvs/httpd/httpd/branches/2.0.x/STATUS?rev=393032&r1=393031&r2=393032&view=diff
==============================================================================
--- httpd/httpd/branches/2.0.x/STATUS (original)
+++ httpd/httpd/branches/2.0.x/STATUS Mon Apr 10 12:33:12 2006
@@ -159,7 +159,7 @@
to 2.0)
2.0 patch is at
http://people.apache.org/~trawick/20_ldap_pool.patch
- +1: trawick
+ +1: trawick, gregames (pls expand on apr_pool_create comment)
*) mod_proxy: Fix PR 11971 (HTTP proxy header "Via" with wrong hostname
if ServerName not set or UseCanonicalName Off) by
Re: svn commit: r393032 - /httpd/httpd/branches/2.0.x/STATUS
Posted by Jeff Trawick <tr...@gmail.com>.
On 4/11/06, William A. Rowe, Jr. <wr...@rowe-clan.net> wrote:
> Jeff Trawick wrote:
> > On 4/10/06, William A. Rowe, Jr. <wr...@rowe-clan.net> wrote:
> >
> >>This pool is or is not created in the parent? If its the parent it's
> >>gotta be proc mutexed even if using prefork.
> >
> > It is created in the parent and used only during request processing.
> > Why does it need to be proc mutexed? Each process has its own copy.
> > There is no shared memory involved.
>
> Ah... of course. The pages are copy-on-write.
>
> So there is no proc mutexing issue :)
>
> >>If it's process-local, then please don't depend on APR_THREADED, please
> >>please please poll the MPM to determine if the mpm has_threads? It's a
> >>huge waste for prefork users with a shared (threaded) apr :(
> >
> > That minor performance improvement for some (lots of?) prefork users
> > should first be addressed in trunk, and implementation/backport of
> > that should not hold up this critical bug fix.
>
> But the code is there, and what we are using in mod_ssl and others. Please
> don't inject a regression where we already cleaned these up once before :(
Nobody ever "cleaned up" ldap. Now there are perhaps 9 occurrences of
a pattern to replace instead of 8. (didn't count exactly) It is a
HUGE stretch to call that a regression, since anybody that wants to
"fix" it has to search for the pattern anyway. People have had
several years to get around to that performance improvement and nobody
cared so far.
Re: svn commit: r393032 - /httpd/httpd/branches/2.0.x/STATUS
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Jeff Trawick wrote:
> On 4/10/06, William A. Rowe, Jr. <wr...@rowe-clan.net> wrote:
>
>>This pool is or is not created in the parent? If its the parent it's
>>gotta be proc mutexed even if using prefork.
>
> It is created in the parent and used only during request processing.
> Why does it need to be proc mutexed? Each process has its own copy.
> There is no shared memory involved.
Ah... of course. The pages are copy-on-write.
So there is no proc mutexing issue :)
>>If it's process-local, then please don't depend on APR_THREADED, please
>>please please poll the MPM to determine if the mpm has_threads? It's a
>>huge waste for prefork users with a shared (threaded) apr :(
>
> That minor performance improvement for some (lots of?) prefork users
> should first be addressed in trunk, and implementation/backport of
> that should not hold up this critical bug fix.
But the code is there, and what we are using in mod_ssl and others. Please
don't inject a regression where we already cleaned these up once before :(
Re: svn commit: r393032 - /httpd/httpd/branches/2.0.x/STATUS
Posted by Jeff Trawick <tr...@gmail.com>.
On 4/10/06, William A. Rowe, Jr. <wr...@rowe-clan.net> wrote:
> This pool is or is not created in the parent? If its the parent it's
> gotta be proc mutexed even if using prefork.
It is created in the parent and used only during request processing.
Why does it need to be proc mutexed? Each process has its own copy.
There is no shared memory involved.
(Windows: each child creates a copy when the config gets processed in the child)
> If it's process-local, then please don't depend on APR_THREADED, please
> please please poll the MPM to determine if the mpm has_threads? It's a
> huge waste for prefork users with a shared (threaded) apr :(
That minor performance improvement for some (lots of?) prefork users
should first be addressed in trunk, and implementation/backport of
that should not hold up this critical bug fix.
Re: svn commit: r393032 - /httpd/httpd/branches/2.0.x/STATUS
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
This pool is or is not created in the parent? If its the parent it's
gotta be proc mutexed even if using prefork.
If it's process-local, then please don't depend on APR_THREADED, please
please please poll the MPM to determine if the mpm has_threads? It's a
huge waste for prefork users with a shared (threaded) apr :(
Bill
gregames@apache.org wrote:
> Author: gregames
> Date: Mon Apr 10 12:33:12 2006
> New Revision: 393032
>
> URL: http://svn.apache.org/viewcvs?rev=393032&view=rev
> Log:
> vote for a backport
>
> Modified:
> httpd/httpd/branches/2.0.x/STATUS
>
> Modified: httpd/httpd/branches/2.0.x/STATUS
> URL: http://svn.apache.org/viewcvs/httpd/httpd/branches/2.0.x/STATUS?rev=393032&r1=393031&r2=393032&view=diff
> ==============================================================================
> --- httpd/httpd/branches/2.0.x/STATUS (original)
> +++ httpd/httpd/branches/2.0.x/STATUS Mon Apr 10 12:33:12 2006
> @@ -159,7 +159,7 @@
> to 2.0)
> 2.0 patch is at
> http://people.apache.org/~trawick/20_ldap_pool.patch
> - +1: trawick
> + +1: trawick, gregames (pls expand on apr_pool_create comment)
>
> *) mod_proxy: Fix PR 11971 (HTTP proxy header "Via" with wrong hostname
> if ServerName not set or UseCanonicalName Off) by
Re: svn commit: r393032 - /httpd/httpd/branches/2.0.x/STATUS
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
This pool is or is not created in the parent? If its the parent it's
gotta be proc mutexed even if using prefork.
If it's process-local, then please don't depend on APR_THREADED, please
please please poll the MPM to determine if the mpm has_threads? It's a
huge waste for prefork users with a shared (threaded) apr :(
Bill
gregames@apache.org wrote:
> Author: gregames
> Date: Mon Apr 10 12:33:12 2006
> New Revision: 393032
>
> URL: http://svn.apache.org/viewcvs?rev=393032&view=rev
> Log:
> vote for a backport
>
> Modified:
> httpd/httpd/branches/2.0.x/STATUS
>
> Modified: httpd/httpd/branches/2.0.x/STATUS
> URL: http://svn.apache.org/viewcvs/httpd/httpd/branches/2.0.x/STATUS?rev=393032&r1=393031&r2=393032&view=diff
> ==============================================================================
> --- httpd/httpd/branches/2.0.x/STATUS (original)
> +++ httpd/httpd/branches/2.0.x/STATUS Mon Apr 10 12:33:12 2006
> @@ -159,7 +159,7 @@
> to 2.0)
> 2.0 patch is at
> http://people.apache.org/~trawick/20_ldap_pool.patch
> - +1: trawick
> + +1: trawick, gregames (pls expand on apr_pool_create comment)
>
> *) mod_proxy: Fix PR 11971 (HTTP proxy header "Via" with wrong hostname
> if ServerName not set or UseCanonicalName Off) by