You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/08 14:31:46 UTC
[GitHub] [pulsar] zzzming opened a new pull request #11971: [Issue-11966][pulsar-proxy]set default proxy http client connect timeout
zzzming opened a new pull request #11971:
URL: https://github.com/apache/pulsar/pull/11971
Fixes #11966
### Motivation
Set HTTP Client connect timeout in pulsar-proxy
### Modifications
Set default HTTP Client connect timeout in pulsar-proxy as 30 seconds
### Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: introduced a new default of proxy HTTP connect timeout
- The wire protocol: no
- The rest endpoints: no
- The admin cli options: no
- Anything that affects deployment: no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli merged pull request #11971: [Issue-11966][pulsar-proxy] set default http proxy request timeout
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #11971:
URL: https://github.com/apache/pulsar/pull/11971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on pull request #11971: [Issue-11966][pulsar-proxy] set default http proxy request timeout
Posted by GitBox <gi...@apache.org>.
merlimat commented on pull request #11971:
URL: https://github.com/apache/pulsar/pull/11971#issuecomment-936279938
@zzzming @lhotari @eolivelli this change does not take into consideration that upload and download of very large functions jars can easily take more than 30 sec.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #11971: [Issue-11966][pulsar-proxy] set default http proxy request timeout
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #11971:
URL: https://github.com/apache/pulsar/pull/11971#issuecomment-936770294
@merlimat you are right.
We should change the default
@zzzming would you mind sending a new PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on pull request #11971: [Issue-11966][pulsar-proxy] set default http proxy request timeout
Posted by GitBox <gi...@apache.org>.
merlimat commented on pull request #11971:
URL: https://github.com/apache/pulsar/pull/11971#issuecomment-936715338
Maybe we could try with something like 5min?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #11971: [Issue-11966][pulsar-proxy] set default http proxy request timeout
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #11971:
URL: https://github.com/apache/pulsar/pull/11971#issuecomment-922887694
@codelipenghui @rdhabalia @merlimat
it would be good to see this in 2.9.0 as it is a critical issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #11971: [Issue-11966][pulsar-proxy] set default http proxy request timeout
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #11971:
URL: https://github.com/apache/pulsar/pull/11971#issuecomment-936586905
> @zzzming @lhotari @eolivelli this change does not take into consideration that upload and download of very large functions jars can easily take more than 30 sec.
@merlimat ok, what would be a sufficient timeout value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #11971: [Issue-11966][pulsar-proxy]set default proxy http client connect timeout
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #11971:
URL: https://github.com/apache/pulsar/pull/11971#issuecomment-915651405
@zzzming Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org