You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@royale.apache.org by GitBox <gi...@apache.org> on 2020/11/23 17:24:12 UTC

[GitHub] [royale-asjs] estanglerbm commented on issue #941: Recent fix for issue #811 breaks VirtualDataContainerView.removeAllItemRenderers in SparkRoyale

estanglerbm commented on issue #941:
URL: https://github.com/apache/royale-asjs/issues/941#issuecomment-732306632


   Well, I can certainly patch removeAllItemRenderers().  But I'm really trying to point out that the relatively-recent change by @aharui to UIComponent.numElements (checking the royale_wrapper) may break more things.
   
   Should numElements really return less than the number of elements, as expected by other code?  If so, that's fine;  can patch functions as needed.  Just want to confirm.  [Both sets of code are doing something unusual:  removeAllItemRenderers() is deleting all-but-two, and numElements is returning less than the number of elements.  So not sure who should win.]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org