You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/07/14 05:00:15 UTC

[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #6340: make subquery in SubqueryRouteTest work well

strongduanmu commented on a change in pull request #6340:
URL: https://github.com/apache/shardingsphere/pull/6340#discussion_r454101225



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dml/SelectStatement.java
##########
@@ -108,15 +106,6 @@
      * @return subquery where segment collection.
      */
     public Collection<WhereSegment> getSubqueryWhereSegments() {
-        Collection<WhereSegment> subqueryWhereSegments = new ArrayList<>();

Review comment:
       @tristaZero Thank you for your suggestions, I will check and optimize this function. 😊




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org