You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/05/10 09:13:00 UTC
[GitHub] [calcite] kgyrtkirk opened a new pull request #1969: [CALCITE-3979] Simplifica might have removed CAST expressi…
kgyrtkirk opened a new pull request #1969:
URL: https://github.com/apache/calcite/pull/1969
…ncorrectly
ReduceExpressionsRule might have removed cast expressions and inadvertly changed the type of some subexpressions.
In case the rewriting have at some point arrived at: CAST(CAST(X,T),T) AND <(CAST(X,T),N)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] kgyrtkirk merged pull request #1969: [CALCITE-3979] Simplification might have removed CAST expressi…
Posted by GitBox <gi...@apache.org>.
kgyrtkirk merged pull request #1969:
URL: https://github.com/apache/calcite/pull/1969
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] julianhyde commented on pull request #1969: [CALCITE-3979] Simplification might have removed CAST expressi…
Posted by GitBox <gi...@apache.org>.
julianhyde commented on pull request #1969:
URL: https://github.com/apache/calcite/pull/1969#issuecomment-626498734
@kgyrtkirk As I said in the JIRA case, I really don't know what's safe to remove. It seems that there is a bunch of code to remove casts and there may not be a sound basis for that code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] kgyrtkirk commented on pull request #1969: [CALCITE-3979] Simplifica might have removed CAST expressi…
Posted by GitBox <gi...@apache.org>.
kgyrtkirk commented on pull request #1969:
URL: https://github.com/apache/calcite/pull/1969#issuecomment-626326640
@chunweilei , @julianhyde : any objections against removing this logic from ReduceExpressionsRule?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org