[GitHub] [hudi] JerryYue-M commented on a diff in pull request #6100: [HUDI-4392]Flink MOR table compaction plan execution sequence should …

[GitBox <gi...@apache.org>]

JerryYue-M commented on code in PR #6100:
URL: https://github.com/apache/hudi/pull/6100#discussion_r920713665


##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/utils/TestCompactionUtil.java:
##########
@@ -149,6 +150,36 @@ void testScheduleCompaction() throws Exception {
     assertThat("Two compaction plan expects to be scheduled", numCompactionCommits, is(2));
   }
 
+  @Test
+  void testGetScheduleCompactionInstant() throws Exception {
+    Map<String, String> options = new HashMap<>();

Review Comment:
   schedule LIFO or FIFO ut test all covered by   testGetScheduleCompactionInstant()
   ```
       CompactionUtil.scheduleCompaction(metaClient, writeClient, true, false);
       Option<HoodieInstant> lastPendingCompactionInstant = CompactionUtil.getScheduleCompactionInstant(table, conf);
       assertEquals(table.getMetaClient().reloadActiveTimeline().filterPendingCompactionTimeline().lastInstant(), lastPendingCompactionInstant);
       conf.set(FlinkOptions.COMPACTION_SCHEDULE_SEQ, "FIFO");
       Option<HoodieInstant> firstPendingCompactionInstant = CompactionUtil.getScheduleCompactionInstant(table, conf);
       assertEquals(table.getMetaClient().reloadActiveTimeline().filterPendingCompactionTimeline().firstInstant(), firstPendingCompactionInstant);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org