You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "clebert suconic (JIRA)" <ji...@apache.org> on 2015/08/28 16:06:45 UTC
[jira] [Comment Edited] (ARTEMIS-216) fix redelivery semantics
[ https://issues.apache.org/jira/browse/ARTEMIS-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14718604#comment-14718604 ]
clebert suconic edited comment on ARTEMIS-216 at 8/28/15 2:05 PM:
------------------------------------------------------------------
I was actually by coincidence looking at this yesterday...
There is an AMQConsumer and an AMQServerConsumer. the AMQConsumer will hold the list of messages belonging to him. Why not to leverage what the server already has? it seems that this is creating a broker within a broker to me. The state should be maintained at the ServerConsumer and redeliveries be handled through QueueImpl as in any other protocol.
I propose we refactor the AMQ Consumers to a simpler model on the next release. This JIRA is a good candidate to perform such refactoring.
was (Author: clebertsuconic):
I was actually by coincidence looking at this yesterday...
There is an AMQConsumer and an AMQServerConsumer. the AMQConsumer will hold the list of messages belonging to him. Why not to leverage what the server already has? it seems that this is creating a broker within a broker to me. The state should be maintained at the ServerConsumer and redeliveries be handled through QueueImpl as in any other protocol.
I propose we refactor the AMQ Consumers to a simpler model on the 1.3.0 release. This JIRA is a good candidate to perform such refactoring.
> fix redelivery semantics
> ------------------------
>
> Key: ARTEMIS-216
> URL: https://issues.apache.org/jira/browse/ARTEMIS-216
> Project: ActiveMQ Artemis
> Issue Type: Sub-task
> Components: OpenWire
> Reporter: Andy Taylor
> Assignee: Andy Taylor
> Fix For: 1.3.0
>
>
> There are some missing features with redelivery such as setting the delivery count when redelivered client side and moving to the DLQ. tests to cover this are:
> https://github.com/apache/activemq/blob/master/activemq-unit-test/src/test/java/org/apache/activemq/test/rollback/CloseRollbackRedeliveryQueueTest.java
> https://github.com/apache/activemq/blob/master/activemq-unit-tests/src/test/java/org/apache/activemq/usecases/NonBlockingConsumerRedeliveryTest.java
> https://github.com/apache/activemq/blob/master/activemq-unit-tests/src/test/java/org/apache/activemq/usecases/TopicRedeliverTest.java
> https://github.com/apache/activemq/blob/master/activemq-unit-tests/src/test/java/org/apache/activemq/usecases/QueueRedeliverTest.java
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)