You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/21 06:57:03 UTC
[GitHub] [airflow] Greetlist opened a new issue #21005: Triggerer Process Do Not create new trigger instance to run
Greetlist opened a new issue #21005:
URL: https://github.com/apache/airflow/issues/21005
### Apache Airflow version
2.2.1
### What happened
When a Deferrable Task which is cleared or generated. This Trigger's TriggererId is NULL,and never change, which cause this trigger is never init and run by triggerer process.
### What you expected to happen
When a Deferrable Task is generated, It will init and run correctly.
### How to reproduce
Clear a Deferrable Task.
I add some log to source code and find out the reason of this problem:
First Query:
``` is None ``` has a strange behavior, It does not work.
Second Query:
when the trigerer_id has a NULL value in database, it can not query correctly.
I fix both problem by:
### Operating System
Ubuntu 16.04
### Versions of Apache Airflow Providers
_No response_
### Deployment
Other
### Deployment details
1.One Triggerer Process
2. Three Scheduler
3. Pecona Mysql 8.0
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Greetlist commented on issue #21005: Triggerer Process Do Not create new trigger instance to run
Posted by GitBox <gi...@apache.org>.
Greetlist commented on issue #21005:
URL: https://github.com/apache/airflow/issues/21005#issuecomment-1019657265
I'm willing to make a PR for it, but I don't know how to add a test case. By the way, there is a ```test_trigger.py``` file in tests, Can I just use the file to test this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Greetlist commented on issue #21005: Triggerer Process Do Not create new trigger instance to run
Posted by GitBox <gi...@apache.org>.
Greetlist commented on issue #21005:
URL: https://github.com/apache/airflow/issues/21005#issuecomment-1020717977
I have another PR [#19640](https://github.com/apache/airflow/pull/19640) which has not been Merged yet.I should wait until it is finished so I can start a new PR for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Greetlist commented on issue #21005: Triggerer Process Do Not create new trigger instance to run
Posted by GitBox <gi...@apache.org>.
Greetlist commented on issue #21005:
URL: https://github.com/apache/airflow/issues/21005#issuecomment-1020717977
I have another PR [#19640](https://github.com/apache/airflow/pull/19640) which has not been Merged yet.I should wait until it is finished so I can start a new PR for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #21005: Triggerer Process Do Not create new trigger instance to run
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #21005:
URL: https://github.com/apache/airflow/issues/21005#issuecomment-1020097256
I believe so - but do not know too much about it - I think you can start with PR even without tests and the right people will comment there on how to add tests!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #21005: Triggerer Process Do Not create new trigger instance to run
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #21005:
URL: https://github.com/apache/airflow/issues/21005#issuecomment-1019593968
Assigned you to it @Greetlist - can you please make a PR for that one with "Fixes: #21005" in the message (and cc: @andrewgodwin best to review it ), I thin you wil have to add a test case for that one but we can guide you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org