You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2013/04/19 04:40:25 UTC

Review Request: SQOOP-992 Allow to set target java version during compilation

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10617/
-----------------------------------------------------------

Review request for Sqoop.


Description
-------

I've added property targetJavaVersion that can be used to set the target java version with default value 6, which is the version Hadoop currently uses.


This addresses bug SQOOP-992.
    https://issues.apache.org/jira/browse/SQOOP-992


Diffs
-----

  build.xml e356ba6a08bd4649555534b2a191ffc060e3a45d 

Diff: https://reviews.apache.org/r/10617/diff/


Testing
-------


Thanks,

Jarek Cecho


Re: Review Request: SQOOP-992 Allow to set target java version during compilation

Posted by Venkat Ranganathan <n....@live.com>.

> On April 19, 2013, 3:03 a.m., Venkat Ranganathan wrote:
> > Ship It!

Looks good to me

Thanks


- Venkat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10617/#review19433
-----------------------------------------------------------


On April 19, 2013, 2:40 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10617/
> -----------------------------------------------------------
> 
> (Updated April 19, 2013, 2:40 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've added property targetJavaVersion that can be used to set the target java version with default value 6, which is the version Hadoop currently uses.
> 
> 
> This addresses bug SQOOP-992.
>     https://issues.apache.org/jira/browse/SQOOP-992
> 
> 
> Diffs
> -----
> 
>   build.xml e356ba6a08bd4649555534b2a191ffc060e3a45d 
> 
> Diff: https://reviews.apache.org/r/10617/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Re: Review Request: SQOOP-992 Allow to set target java version during compilation

Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10617/#review19433
-----------------------------------------------------------

Ship it!


Ship It!

- Venkat Ranganathan


On April 19, 2013, 2:40 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10617/
> -----------------------------------------------------------
> 
> (Updated April 19, 2013, 2:40 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've added property targetJavaVersion that can be used to set the target java version with default value 6, which is the version Hadoop currently uses.
> 
> 
> This addresses bug SQOOP-992.
>     https://issues.apache.org/jira/browse/SQOOP-992
> 
> 
> Diffs
> -----
> 
>   build.xml e356ba6a08bd4649555534b2a191ffc060e3a45d 
> 
> Diff: https://reviews.apache.org/r/10617/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Re: Review Request: SQOOP-992 Allow to set target java version during compilation

Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10617/#review19435
-----------------------------------------------------------

Ship it!


Ship It!

- Hari Shreedharan


On April 19, 2013, 2:40 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10617/
> -----------------------------------------------------------
> 
> (Updated April 19, 2013, 2:40 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've added property targetJavaVersion that can be used to set the target java version with default value 6, which is the version Hadoop currently uses.
> 
> 
> This addresses bug SQOOP-992.
>     https://issues.apache.org/jira/browse/SQOOP-992
> 
> 
> Diffs
> -----
> 
>   build.xml e356ba6a08bd4649555534b2a191ffc060e3a45d 
> 
> Diff: https://reviews.apache.org/r/10617/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Re: Review Request: SQOOP-992 Allow to set target java version during compilation

Posted by Kathleen Ting <ka...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10617/#review19475
-----------------------------------------------------------

Ship it!


Ship It!

- Kathleen Ting


On April 19, 2013, 2:40 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10617/
> -----------------------------------------------------------
> 
> (Updated April 19, 2013, 2:40 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've added property targetJavaVersion that can be used to set the target java version with default value 6, which is the version Hadoop currently uses.
> 
> 
> This addresses bug SQOOP-992.
>     https://issues.apache.org/jira/browse/SQOOP-992
> 
> 
> Diffs
> -----
> 
>   build.xml e356ba6a08bd4649555534b2a191ffc060e3a45d 
> 
> Diff: https://reviews.apache.org/r/10617/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>