[GitHub] metron pull request #1040: METRON-1589: '/api/v1/search/search' fails when '...

[cestella <gi...@git.apache.org>]

Github user cestella commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1040#discussion_r192870707
  
    --- Diff: metron-platform/metron-solr/src/main/java/org/apache/metron/solr/writer/SolrWriter.java ---
    @@ -17,47 +17,46 @@
      */
     package org.apache.metron.solr.writer;
     
    +import static org.apache.metron.solr.SolrConstants.SOLR_WRITER_NAME;
    +
     import com.google.common.base.Joiner;
    +import java.io.IOException;
    +import java.io.Serializable;
    +import java.lang.invoke.MethodHandles;
    +import java.util.ArrayList;
    +import java.util.Collection;
    +import java.util.HashMap;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.Optional;
    +import java.util.UUID;
    +import java.util.function.Supplier;
     import org.apache.commons.lang3.StringUtils;
     import org.apache.metron.common.Constants;
    +import org.apache.metron.common.configuration.writer.WriterConfiguration;
    +import org.apache.metron.common.writer.BulkMessageWriter;
    +import org.apache.metron.common.writer.BulkWriterResponse;
    +import org.apache.metron.solr.SolrConstants;
     import org.apache.metron.stellar.common.utils.ConversionUtils;
    +import org.apache.solr.client.solrj.SolrServerException;
     import org.apache.solr.client.solrj.impl.HttpClientUtil;
     import org.apache.solr.client.solrj.impl.HttpSolrClient;
     import org.apache.solr.client.solrj.impl.Krb5HttpClientConfigurer;
    +import org.apache.solr.client.solrj.response.UpdateResponse;
     import org.apache.solr.common.SolrException;
    +import org.apache.solr.common.SolrInputDocument;
     import org.apache.storm.task.TopologyContext;
     import org.apache.storm.tuple.Tuple;
    -import org.apache.metron.common.configuration.writer.WriterConfiguration;
    -import org.apache.metron.common.writer.BulkMessageWriter;
    -import org.apache.metron.common.writer.BulkWriterResponse;
    -import org.apache.solr.client.solrj.SolrServerException;
    -import org.apache.solr.client.solrj.response.UpdateResponse;
    -import org.apache.solr.common.SolrInputDocument;
     import org.json.simple.JSONObject;
     import org.slf4j.Logger;
     import org.slf4j.LoggerFactory;
     
    -import java.io.IOException;
    -import java.io.Serializable;
    -import java.lang.invoke.MethodHandles;
    -import java.util.HashMap;
    -import java.util.Map;
    -import java.util.Collection;
    -import java.util.Optional;
    -import java.util.List;
    -import java.util.ArrayList;
    -import java.util.Set;
    -import java.util.UUID;
    -import java.util.function.Supplier;
    -
    -import static org.apache.metron.solr.SolrConstants.SOLR_WRITER_NAME;
    -
     public class SolrWriter implements BulkMessageWriter<JSONObject>, Serializable {
     
       public static final String JAVA_SECURITY_CONFIG_PROPERTY = "java.security.auth.login.config";
     
       public enum SolrProperties {
    -    ZOOKEEPER_QUORUM("solr.zookeeper"),
    +    ZOOKEEPER_QUORUM(SolrConstants.SOLR_ZOOKEEPER),
    --- End diff --
    
    Yep, this is fine.  +1 by inspection.


---