[jira] [Commented] (MNG-6829) Remove commons-lang3 dependency

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MNG-6829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17728308#comment-17728308 ] 

ASF GitHub Bot commented on MNG-6829:
-------------------------------------

timtebeek commented on code in PR #58:
URL: https://github.com/apache/maven-install-plugin/pull/58#discussion_r1212983344


##########
src/main/java/org/apache/maven/plugins/install/InstallFileMojo.java:
##########
@@ -218,7 +218,7 @@ public void execute() throws MojoExecutionException, MojoFailureException {
             ArtifactType artifactType =
                     repositorySystemSession.getArtifactTypeRegistry().get(packaging);
             if (artifactType != null
-                    && StringUtils.isEmpty(classifier)
+                    && (classifier == null || classifier.isEmpty())
                     && !StringUtils.isEmpty(artifactType.getClassifier())) {

Review Comment:
   Looking at this again: the line was not missed, but intentionally left out in the recipe, as we can't be certain that the argument method invocation is safe to call twice; once for the null check, and again for the isEmpty call. Hence why I don't convert those automatically yet, even though in this case it's probably safe to do.





> Remove commons-lang3 dependency
> -------------------------------
>
>                 Key: MNG-6829
>                 URL: https://issues.apache.org/jira/browse/MNG-6829
>             Project: Maven
>          Issue Type: Sub-task
>          Components: Bootstrap & Build
>    Affects Versions: 3.6.3
>            Reporter: Karl Heinz Marbaise
>            Assignee: Karl Heinz Marbaise
>            Priority: Minor
>              Labels: close-pending
>             Fix For: 4.0.x-candidate
>
>         Attachments: dtPKn.xlsx
>
>
> Currently we use {{commons-lang3}} for the following classes
> * {{StringUtils}} can be replaced by usage of either {{plexus-utils}} or {{maven-shared-utils}} or as I tested with self implementation
> * {{SystemUtils}} is only used in some tests which can simply replaced by using JUnit Jupiter with all the support it has.
> * {{Validate}} is a precondition class which checks for parameters etc. can be implemented very easily (done already to see how it works). Later this could be made part of {{maven-shared-utils}}.
> * Currently the {{StringUtils.substringAfterLast( resourceName,  "/" )}} is used in {{ConsoleMavenTransferListener}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)