[jira] [Commented] (HIVE-18705) Improve HiveMetaStoreClient.dropDatabase

["Vihang Karajgaonkar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-18705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362914#comment-16362914 ] 

Vihang Karajgaonkar commented on HIVE-18705:
--------------------------------------------

This is an interesting find. I noticed that the drop_database call takes in a cascade flag and possibly is doing the same work on the server side. This would make the work done on Client side unnecessary. Do you know why we have two places in the code to get the tables and then drop them individually?

> Improve HiveMetaStoreClient.dropDatabase
> ----------------------------------------
>
>                 Key: HIVE-18705
>                 URL: https://issues.apache.org/jira/browse/HIVE-18705
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Adam Szita
>            Assignee: Adam Szita
>            Priority: Major
>
> {{HiveMetaStoreClient.dropDatabase}} has a strange implementation to ensure dealing with client side hooks (for non-native tables e.g. HBase). Currently it starts by retrieving all the tables from HMS, and then sends {{dropTable}} calls to HMS table-by-table. At the end a {{dropDatabase}} just to be sure :) 
> I believe this could be refactored so that it speeds up the dropDB in situations where the average table count per DB is very high.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)