You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "redlsz (via GitHub)" <gi...@apache.org> on 2024/08/02 06:18:29 UTC
[PR] [ISSUE #8479] Fix pop revive infinite retry caused by deleting one topic then re-create it in a short time [rocketmq]
redlsz opened a new pull request, #8482:
URL: https://github.com/apache/rocketmq/pull/8482
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #8479
### Brief Description
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
Skip reviving if get message result is OFFSET_OVERFLOW_ONE or OFFSET_OVERFLOW_BADLY
### How Did You Test This Change?
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8479] Fix pop revive infinite retry caused by deleting one topic then re-create it in a short time [rocketmq]
Posted by "imzs (via GitHub)" <gi...@apache.org>.
imzs commented on PR #8482:
URL: https://github.com/apache/rocketmq/pull/8482#issuecomment-2267485041
HI, I've posted a PR #8475 mainly for improving reading messages from a remote broker, just skip retry when it refers to a local store. Could you help to check if we skip retry incorrectly under certain conditions, both for local store and tiered store.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8479] Fix pop revive infinite retry caused by deleting one topic then re-create it in a short time [rocketmq]
Posted by "redlsz (via GitHub)" <gi...@apache.org>.
redlsz commented on PR #8482:
URL: https://github.com/apache/rocketmq/pull/8482#issuecomment-2295930058
> HI, I've posted a PR #8475 mainly for improving reading messages from a remote broker, just skip retry when it refers to a local store. Could you help to check if we skip retry incorrectly under certain conditions, both for local store and tiered store.
LGTM, then I will close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8479] Fix pop revive infinite retry caused by deleting one topic then re-create it in a short time [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8482:
URL: https://github.com/apache/rocketmq/pull/8482#issuecomment-2264678712
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8482?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 45.98%. Comparing base [(`2ed4ba2`)](https://app.codecov.io/gh/apache/rocketmq/commit/2ed4ba23e0448d5a7a4f68c29d0f9bb7a6d30ee3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`066a3c5`)](https://app.codecov.io/gh/apache/rocketmq/commit/066a3c5cb03b7b6184d44cbb34f62074b7dad869?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 1 commits behind head on develop.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #8482 +/- ##
=============================================
- Coverage 46.01% 45.98% -0.04%
+ Complexity 11144 11143 -1
=============================================
Files 1274 1274
Lines 89008 89008
Branches 11444 11444
=============================================
- Hits 40958 40927 -31
- Misses 42925 42954 +29
- Partials 5125 5127 +2
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/8482?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8479] Fix pop revive infinite retry caused by deleting one topic then re-create it in a short time [rocketmq]
Posted by "redlsz (via GitHub)" <gi...@apache.org>.
redlsz closed pull request #8482: [ISSUE #8479] Fix pop revive infinite retry caused by deleting one topic then re-create it in a short time
URL: https://github.com/apache/rocketmq/pull/8482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8479] Fix pop revive infinite retry caused by deleting one topic then re-create it in a short time [rocketmq]
Posted by "redlsz (via GitHub)" <gi...@apache.org>.
redlsz commented on PR #8482:
URL: https://github.com/apache/rocketmq/pull/8482#issuecomment-2295936407
Already fixed by #8475
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org