You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Uwe Schindler (Created) (JIRA)" <ji...@apache.org> on 2012/03/04 00:11:56 UTC

[jira] [Created] (LUCENE-3844) Deprecate Token class and remove in trunk

Deprecate Token class and remove in trunk
-----------------------------------------

                 Key: LUCENE-3844
                 URL: https://issues.apache.org/jira/browse/LUCENE-3844
             Project: Lucene - Java
          Issue Type: Task
            Reporter: Uwe Schindler


After issues like LUCENE-3843, introducing new attributes, we should remove Token class in trunk, as it leads to code that ignores those new attributes (like PositionLengthAttribute, ScriptAttribute, KeywordAttribute,...). If you want a holder for all Attributes a TokenStream, use TS.cloneAttributes().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Issue Comment Edited] (LUCENE-3844) Deprecate Token class and remove in trunk

Posted by "Uwe Schindler (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221728#comment-13221728 ] 

Uwe Schindler edited comment on LUCENE-3844 at 3/3/12 11:15 PM:
----------------------------------------------------------------

And finally: die, Token, die :-), see @UweSays: [https://twitter.com/#!/UweSays/status/176082735792787456]
                
      was (Author: thetaphi):
    And finally: die, Token, die :-) (© @UweSays)
                  
> Deprecate Token class and remove in trunk
> -----------------------------------------
>
>                 Key: LUCENE-3844
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3844
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: core/other, modules/analysis
>    Affects Versions: 3.5
>            Reporter: Uwe Schindler
>             Fix For: 3.6, 4.0
>
>
> After issues like LUCENE-3843, introducing new attributes, we should remove Token class in trunk, as it leads to code that ignores those new attributes (like PositionLengthAttribute, ScriptAttribute, KeywordAttribute,...). If you want a holder for all Attributes a TokenStream, use TS.cloneAttributes().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-3844) Deprecate Token class and remove in trunk

Posted by "Uwe Schindler (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler updated LUCENE-3844:
----------------------------------

          Component/s: modules/analysis
                       core/other
    Affects Version/s: 3.5
        Fix Version/s: 4.0
                       3.6
    
> Deprecate Token class and remove in trunk
> -----------------------------------------
>
>                 Key: LUCENE-3844
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3844
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: core/other, modules/analysis
>    Affects Versions: 3.5
>            Reporter: Uwe Schindler
>             Fix For: 3.6, 4.0
>
>
> After issues like LUCENE-3843, introducing new attributes, we should remove Token class in trunk, as it leads to code that ignores those new attributes (like PositionLengthAttribute, ScriptAttribute, KeywordAttribute,...). If you want a holder for all Attributes a TokenStream, use TS.cloneAttributes().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3844) Deprecate Token class and remove in trunk

Posted by "Uwe Schindler (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221728#comment-13221728 ] 

Uwe Schindler commented on LUCENE-3844:
---------------------------------------

And finally: die, Token, die :-) (© @UweSays)
                
> Deprecate Token class and remove in trunk
> -----------------------------------------
>
>                 Key: LUCENE-3844
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3844
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: core/other, modules/analysis
>    Affects Versions: 3.5
>            Reporter: Uwe Schindler
>             Fix For: 3.6, 4.0
>
>
> After issues like LUCENE-3843, introducing new attributes, we should remove Token class in trunk, as it leads to code that ignores those new attributes (like PositionLengthAttribute, ScriptAttribute, KeywordAttribute,...). If you want a holder for all Attributes a TokenStream, use TS.cloneAttributes().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3844) Deprecate Token class and remove in trunk

Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222938#comment-13222938 ] 

Robert Muir commented on LUCENE-3844:
-------------------------------------

How much work is this? I think even removing would be difficult.

Maybe we should push deprecating this out to 4.0, giving us a lot of time to clean things up
before its totally removed.
                
> Deprecate Token class and remove in trunk
> -----------------------------------------
>
>                 Key: LUCENE-3844
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3844
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: core/other, modules/analysis
>    Affects Versions: 3.5
>            Reporter: Uwe Schindler
>             Fix For: 3.6, 4.0
>
>
> After issues like LUCENE-3843, introducing new attributes, we should remove Token class in trunk, as it leads to code that ignores those new attributes (like PositionLengthAttribute, ScriptAttribute, KeywordAttribute,...). If you want a holder for all Attributes a TokenStream, use TS.cloneAttributes().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org