You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org> on 2011/03/07 22:56:59 UTC
[jira] Created: (HADOOP-7166) DaemonFactory should be moved from
HDFS to common
DaemonFactory should be moved from HDFS to common
-------------------------------------------------
Key: HADOOP-7166
URL: https://issues.apache.org/jira/browse/HADOOP-7166
Project: Hadoop Common
Issue Type: Improvement
Reporter: Jitendra Nath Pandey
Assignee: Jitendra Nath Pandey
DaemonFactory class is defined in hdfs util. common would be a better place for this class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HADOOP-7166) DaemonFactory should be moved from
HDFS to common
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005748#comment-13005748 ]
Tom White commented on HADOOP-7166:
-----------------------------------
I missed that DaemonFactory was only in the federation branch. I agree that putting it with Daemon (marked @LimitedPrivate) in common makes sense.
> DaemonFactory should be moved from HDFS to common
> -------------------------------------------------
>
> Key: HADOOP-7166
> URL: https://issues.apache.org/jira/browse/HADOOP-7166
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-7166.1.patch
>
>
> DaemonFactory class is defined in hdfs util. common would be a better place for this class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HADOOP-7166) DaemonFactory should be moved from
HDFS to common
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005442#comment-13005442 ]
Jitendra Nath Pandey commented on HADOOP-7166:
----------------------------------------------
> you mean HDFS federation branch right?
That is correct. Currently DaemonFactory is committed to the federation branch only. This patch adds it to the common branch and federation branch code will be changed to use the DaemonFactory from common (HDFS-1730).
> DaemonFactory should be moved from HDFS to common
> -------------------------------------------------
>
> Key: HADOOP-7166
> URL: https://issues.apache.org/jira/browse/HADOOP-7166
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-7166.1.patch
>
>
> DaemonFactory class is defined in hdfs util. common would be a better place for this class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-7166) DaemonFactory should be moved from
HDFS to common
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-7166:
-----------------------------------------
Status: Open (was: Patch Available)
> DaemonFactory should be moved from HDFS to common
> -------------------------------------------------
>
> Key: HADOOP-7166
> URL: https://issues.apache.org/jira/browse/HADOOP-7166
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-7166.1.patch, HADOOP-7166.2.patch
>
>
> DaemonFactory class is defined in hdfs util. common would be a better place for this class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HADOOP-7166) DaemonFactory should be moved from
HDFS to common
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005423#comment-13005423 ]
Suresh Srinivas commented on HADOOP-7166:
-----------------------------------------
Jitendra, when you say DaemonFactory should be moved from HDFS to common, you mean HDFS federation branch right?
> DaemonFactory should be moved from HDFS to common
> -------------------------------------------------
>
> Key: HADOOP-7166
> URL: https://issues.apache.org/jira/browse/HADOOP-7166
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-7166.1.patch
>
>
> DaemonFactory class is defined in hdfs util. common would be a better place for this class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-7166) DaemonFactory should be moved from
HDFS to common
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-7166:
-----------------------------------------
Status: Patch Available (was: Open)
> DaemonFactory should be moved from HDFS to common
> -------------------------------------------------
>
> Key: HADOOP-7166
> URL: https://issues.apache.org/jira/browse/HADOOP-7166
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-7166.1.patch, HADOOP-7166.2.patch
>
>
> DaemonFactory class is defined in hdfs util. common would be a better place for this class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-7166) DaemonFactory should be moved from
HDFS to common
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-7166:
-----------------------------------------
Status: Open (was: Patch Available)
> DaemonFactory should be moved from HDFS to common
> -------------------------------------------------
>
> Key: HADOOP-7166
> URL: https://issues.apache.org/jira/browse/HADOOP-7166
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-7166.1.patch
>
>
> DaemonFactory class is defined in hdfs util. common would be a better place for this class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HADOOP-7166) DaemonFactory should be moved from
HDFS to common
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005421#comment-13005421 ]
Suresh Srinivas commented on HADOOP-7166:
-----------------------------------------
+1 for the change.
> DaemonFactory should be moved from HDFS to common
> -------------------------------------------------
>
> Key: HADOOP-7166
> URL: https://issues.apache.org/jira/browse/HADOOP-7166
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-7166.1.patch
>
>
> DaemonFactory class is defined in hdfs util. common would be a better place for this class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HADOOP-7166) DaemonFactory should be moved from
HDFS to common
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003656#comment-13003656 ]
Tom White commented on HADOOP-7166:
-----------------------------------
Is the motivation for this for MapReduce to use DaemonFactory?
> DaemonFactory should be moved from HDFS to common
> -------------------------------------------------
>
> Key: HADOOP-7166
> URL: https://issues.apache.org/jira/browse/HADOOP-7166
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-7166.1.patch
>
>
> DaemonFactory class is defined in hdfs util. common would be a better place for this class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-7166) DaemonFactory should be moved from
HDFS to common
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-7166:
-----------------------------------------
Status: Patch Available (was: Open)
Patch submitted for hudson tests.
> DaemonFactory should be moved from HDFS to common
> -------------------------------------------------
>
> Key: HADOOP-7166
> URL: https://issues.apache.org/jira/browse/HADOOP-7166
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-7166.1.patch
>
>
> DaemonFactory class is defined in hdfs util. common would be a better place for this class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HADOOP-7166) DaemonFactory should be moved from
HDFS to common
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006026#comment-13006026 ]
Hudson commented on HADOOP-7166:
--------------------------------
Integrated in Hadoop-Common-trunk #628 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/628/])
HADOOP-7166. Add DaemonFactory to common. Contributed by Erik Steffl and jitendra.
> DaemonFactory should be moved from HDFS to common
> -------------------------------------------------
>
> Key: HADOOP-7166
> URL: https://issues.apache.org/jira/browse/HADOOP-7166
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-7166.1.patch, HADOOP-7166.2.patch
>
>
> DaemonFactory class is defined in hdfs util. common would be a better place for this class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HADOOP-7166) DaemonFactory should be moved from
HDFS to common
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005873#comment-13005873 ]
Hudson commented on HADOOP-7166:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #525 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/525/])
HADOOP-7166. Add DaemonFactory to common. Contributed by Erik Steffl and jitendra.
> DaemonFactory should be moved from HDFS to common
> -------------------------------------------------
>
> Key: HADOOP-7166
> URL: https://issues.apache.org/jira/browse/HADOOP-7166
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-7166.1.patch, HADOOP-7166.2.patch
>
>
> DaemonFactory class is defined in hdfs util. common would be a better place for this class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HADOOP-7166) DaemonFactory should be moved from
HDFS to common
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005395#comment-13005395 ]
Jitendra Nath Pandey commented on HADOOP-7166:
----------------------------------------------
>Is the motivation for this for MapReduce to use DaemonFactory?
The motivation is that it is not specific to hdfs and could be used outside hdfs as well, and Daemon.java in common seems to be a logical place to put DaemonFactory.
> DaemonFactory should be moved from HDFS to common
> -------------------------------------------------
>
> Key: HADOOP-7166
> URL: https://issues.apache.org/jira/browse/HADOOP-7166
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-7166.1.patch
>
>
> DaemonFactory class is defined in hdfs util. common would be a better place for this class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-7166) DaemonFactory should be moved from
HDFS to common
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-7166:
-----------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
> DaemonFactory should be moved from HDFS to common
> -------------------------------------------------
>
> Key: HADOOP-7166
> URL: https://issues.apache.org/jira/browse/HADOOP-7166
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-7166.1.patch, HADOOP-7166.2.patch
>
>
> DaemonFactory class is defined in hdfs util. common would be a better place for this class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HADOOP-7166) DaemonFactory should be moved from
HDFS to common
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005864#comment-13005864 ]
Suresh Srinivas commented on HADOOP-7166:
-----------------------------------------
Thanks Tom for suggesting the addition of @LimitedPrivate. Patch looks good to me. +1.
> DaemonFactory should be moved from HDFS to common
> -------------------------------------------------
>
> Key: HADOOP-7166
> URL: https://issues.apache.org/jira/browse/HADOOP-7166
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-7166.1.patch, HADOOP-7166.2.patch
>
>
> DaemonFactory class is defined in hdfs util. common would be a better place for this class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HADOOP-7166) DaemonFactory should be moved from
HDFS to common
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005800#comment-13005800 ]
Jitendra Nath Pandey commented on HADOOP-7166:
----------------------------------------------
ant test was run manually.
test patch results
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no new tests are needed for this patch.
[exec] Also please list what manual steps were performed to verify this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
[exec]
[exec] +1 system test framework. The patch passed system test framework compile.
No new tests added, because DaemonFactory is a new class with a single method to construct a new Daemon, and it is not used in common. It is used in HDFS and it should be sufficient to test it there.
> DaemonFactory should be moved from HDFS to common
> -------------------------------------------------
>
> Key: HADOOP-7166
> URL: https://issues.apache.org/jira/browse/HADOOP-7166
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-7166.1.patch, HADOOP-7166.2.patch
>
>
> DaemonFactory class is defined in hdfs util. common would be a better place for this class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-7166) DaemonFactory should be moved from
HDFS to common
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-7166:
-----------------------------------------
Attachment: HADOOP-7166.2.patch
Updated patch marking DaemonFactory as LimitedPrivate.
> DaemonFactory should be moved from HDFS to common
> -------------------------------------------------
>
> Key: HADOOP-7166
> URL: https://issues.apache.org/jira/browse/HADOOP-7166
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-7166.1.patch, HADOOP-7166.2.patch
>
>
> DaemonFactory class is defined in hdfs util. common would be a better place for this class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-7166) DaemonFactory should be moved from
HDFS to common
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-7166:
-----------------------------------------
Attachment: HADOOP-7166.1.patch
> DaemonFactory should be moved from HDFS to common
> -------------------------------------------------
>
> Key: HADOOP-7166
> URL: https://issues.apache.org/jira/browse/HADOOP-7166
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-7166.1.patch
>
>
> DaemonFactory class is defined in hdfs util. common would be a better place for this class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-7166) DaemonFactory should be moved from
HDFS to common
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-7166:
-----------------------------------------
Hadoop Flags: [Reviewed]
Status: Patch Available (was: Open)
> DaemonFactory should be moved from HDFS to common
> -------------------------------------------------
>
> Key: HADOOP-7166
> URL: https://issues.apache.org/jira/browse/HADOOP-7166
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-7166.1.patch
>
>
> DaemonFactory class is defined in hdfs util. common would be a better place for this class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira