You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2019/02/13 02:15:35 UTC
Review Request 69962: Added cleanup logic for orphaned operations.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69962/
-----------------------------------------------------------
Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.
Bugs: MESOS-9542
https://issues.apache.org/jira/browse/MESOS-9542
Repository: mesos
Description
-------
The resources used by orphaned operations are not accounted for
in the Slave struct's `usedResources`, and must be treated differently
when cleaning up the operation. Removal of non-terminal orphan
operations will instead augment the `totalResources`.
NOTE: The only codepath that can remove non-terminal operations is
when removing the agent. In this case, there is no need to update
the allocator with the augmented `totalResources`.
Diffs
-----
src/master/master.cpp 014e0e053cdf5c53a5ef8d63300205a121bed319
Diff: https://reviews.apache.org/r/69962/diff/1/
Testing
-------
See last patch in chain.
Thanks,
Joseph Wu
Re: Review Request 69962: Added cleanup logic for orphaned operations.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69962/#review212995
-----------------------------------------------------------
Fix it, then Ship it!
src/master/master.cpp
Lines 12765-12768 (patched)
<https://reviews.apache.org/r/69962/#comment298853>
Suggestion: instead of "This means the modification...", I would recommend
"Since the allocator is updated when operations are transitioned to a terminal state, we do not need to do so here."
- Greg Mann
On Feb. 13, 2019, 2:15 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69962/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2019, 2:15 a.m.)
>
>
> Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.
>
>
> Bugs: MESOS-9542
> https://issues.apache.org/jira/browse/MESOS-9542
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The resources used by orphaned operations are not accounted for
> in the Slave struct's `usedResources`, and must be treated differently
> when cleaning up the operation. Removal of non-terminal orphan
> operations will instead augment the `totalResources`.
>
> NOTE: The only codepath that can remove non-terminal operations is
> when removing the agent. In this case, there is no need to update
> the allocator with the augmented `totalResources`.
>
>
> Diffs
> -----
>
> src/master/master.cpp 014e0e053cdf5c53a5ef8d63300205a121bed319
>
>
> Diff: https://reviews.apache.org/r/69962/diff/2/
>
>
> Testing
> -------
>
> See last patch in chain.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 69962: Added cleanup logic for orphaned operations.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69962/#review213175
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On Feb. 22, 2019, 12:06 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69962/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2019, 12:06 a.m.)
>
>
> Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.
>
>
> Bugs: MESOS-9542
> https://issues.apache.org/jira/browse/MESOS-9542
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The resources used by orphaned operations are not accounted for
> in the Slave struct's `usedResources`, and must be treated differently
> when cleaning up the operation. Removal of non-terminal orphan
> operations will instead augment the `totalResources`.
>
> NOTE: The only codepath that can remove non-terminal operations is
> when removing the agent or a resource provider. In this case,
> there is no need to update the allocator with the augmented
> `totalResources` because the removal codepaths will already
> update the allocator.
>
>
> Diffs
> -----
>
> src/master/master.cpp 106d924bf16231b3bda3fb719db68c01d73644ee
>
>
> Diff: https://reviews.apache.org/r/69962/diff/3/
>
>
> Testing
> -------
>
> See last patch in chain.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 69962: Added cleanup logic for orphaned operations.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69962/
-----------------------------------------------------------
(Updated Feb. 21, 2019, 4:06 p.m.)
Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.
Changes
-------
* Modified `Master::removeOperation` to not recover resources from orphaned operations (per https://reviews.apache.org/r/70014/#comment298857 ).
* Clarified a comment.
Bugs: MESOS-9542
https://issues.apache.org/jira/browse/MESOS-9542
Repository: mesos
Description (updated)
-------
The resources used by orphaned operations are not accounted for
in the Slave struct's `usedResources`, and must be treated differently
when cleaning up the operation. Removal of non-terminal orphan
operations will instead augment the `totalResources`.
NOTE: The only codepath that can remove non-terminal operations is
when removing the agent or a resource provider. In this case,
there is no need to update the allocator with the augmented
`totalResources` because the removal codepaths will already
update the allocator.
Diffs (updated)
-----
src/master/master.cpp 106d924bf16231b3bda3fb719db68c01d73644ee
Diff: https://reviews.apache.org/r/69962/diff/3/
Changes: https://reviews.apache.org/r/69962/diff/2-3/
Testing
-------
See last patch in chain.
Thanks,
Joseph Wu