You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "swamirishi (via GitHub)" <gi...@apache.org> on 2025/12/24 19:25:58 UTC
[PR] HDDS-14240. Revert HDDS-13415 to separate out Refactoring and implementation of Delete Range with batch [ozone]
swamirishi opened a new pull request, #9554:
URL: https://github.com/apache/ozone/pull/9554
## What changes were proposed in this pull request?
Revert the patch [HDDS-13415](https://issues.apache.org/jira/browse/HDDS-13415) and do individual deletes on snapshot create
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14237
## How was this patch tested?
Existing tests should be sufficient since we are reverting a patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14240. Revert HDDS-13415 to separate out Refactoring and implementation of Delete Range with batch [ozone]
Posted by "swamirishi (via GitHub)" <gi...@apache.org>.
swamirishi merged PR #9554:
URL: https://github.com/apache/ozone/pull/9554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14240. Revert HDDS-13415 to separate out Refactoring and implementation of Delete Range with batch [ozone]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on PR #9554:
URL: https://github.com/apache/ozone/pull/9554#issuecomment-3693140638
@swamirishi , when someone has a concern, it is better to finish the discussion first. Please don't merge the PR so early. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14240. Revert HDDS-13415 to separate out Refactoring and implementation of Delete Range with batch [ozone]
Posted by "swamirishi (via GitHub)" <gi...@apache.org>.
swamirishi commented on PR #9554:
URL: https://github.com/apache/ozone/pull/9554#issuecomment-3690943854
Thank you @szetszwo for reviewing the patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14240. Revert HDDS-13415 to separate out Refactoring and implementation of Delete Range with batch [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #9554:
URL: https://github.com/apache/ozone/pull/9554#issuecomment-3690491126
> since we are reverting a patch
Please do not create Jira issue for reverting another. Just use the original ticket, like:
```
* 00c935b729 Revert "HDDS-13776. Fail DirectoryPurge requests if previous snapshot ID validation fails. (#9130)"
* aee5aa31a7 Revert "HDDS-13814. Bump opentelemetry to 1.55.0 (#9170)"
* 3e5414d010 Revert "HDDS-13213. KeyDeletingService should limit task size by both key count and serialized size. (#8757)" (#8957)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14240. Revert HDDS-13415 to separate out Refactoring and implementation of Delete Range with batch [ozone]
Posted by "swamirishi (via GitHub)" <gi...@apache.org>.
swamirishi commented on PR #9554:
URL: https://github.com/apache/ozone/pull/9554#issuecomment-3690633613
> Please do not create Jira issue for reverting another. Just use the original ticket, like:
I believe havong another jira for revert makes sense. This is not exactly a full exact revert so it makes sense to have a separate jira.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14240. Revert HDDS-13415 to separate out Refactoring and implementation of Delete Range with batch [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #9554:
URL: https://github.com/apache/ozone/pull/9554#issuecomment-3691103233
> This is not exactly a full exact revert
It fully reverts HDDS-13415, and an additioonal usage of `deleteRangeWithBatch` introduced later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org