You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/07/18 17:13:42 UTC

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #6971: Minor GHA changes

ocket8888 commented on code in PR #6971:
URL: https://github.com/apache/trafficcontrol/pull/6971#discussion_r923624856


##########
.github/workflows/traffic-ops.yml:
##########
@@ -15,7 +15,7 @@
 # specific language governing permissions and limitations
 # under the License.
 
-name: Traffic Ops Go client/API integration tests
+name: TO Integration Tests

Review Comment:
   The cross-app integration being tested here is TO's API with its Go client. TO is basically just an API, so saying API may be redundant, and it can be abbreviated from Traffic Ops to TO, but imo this should still mention the Go client.



##########
.github/workflows/health-client-tests.yml:
##########
@@ -15,7 +15,7 @@
 # specific language governing permissions and limitations
 # under the License.
 
-name: Traffic Control Health Client integration tests
+name: Health Client Integration Tests

Review Comment:
   "Traffic Control Health Client" is the name of the app under test in this workflow, so that was actually appropriate - besides casing. The name can be slightly abbreviated to match the executable name: `tc-health-client`.



##########
.github/workflows/cache-config-tests.yml:
##########
@@ -15,7 +15,7 @@
 # specific language governing permissions and limitations
 # under the License.
 
-name: Traffic Control Cache Config integration tests
+name: Cache Config Integration Tests

Review Comment:
   "Traffic Control Cache Config" is the name of the app being tested, so this was actually appropriate. If the name length bothers you, you could use the abbreviated name "t3c".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org