You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "caigy (via GitHub)" <gi...@apache.org> on 2023/05/09 01:58:21 UTC

[GitHub] [rocketmq] caigy commented on a diff in pull request #6680: [ISSUE #6679]SubscriptionData may not be updated when the client's system time is rolled back

caigy commented on code in PR #6680:
URL: https://github.com/apache/rocketmq/pull/6680#discussion_r1188040113


##########
remoting/src/main/java/org/apache/rocketmq/remoting/protocol/heartbeat/SubscriptionData.java:
##########
@@ -38,6 +38,9 @@ public class SubscriptionData implements Comparable<SubscriptionData> {
     @JSONField(serialize = false)
     private String filterClassSource;
 
+    @JSONField(serialize = false)
+    private transient long lastUpdateTime = System.currentTimeMillis();

Review Comment:
   Should we use nanoTime?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org