[GitHub] [superset] codemaster08240328 commented on a change in pull request #19491: fix: Dynamic form to connect to Snowflake DB is not displaying authentication errors

[GitBox <gi...@apache.org>]

codemaster08240328 commented on a change in pull request #19491:
URL: https://github.com/apache/superset/pull/19491#discussion_r840750313



##########
File path: superset-frontend/src/views/CRUD/hooks.ts
##########
@@ -744,6 +748,15 @@ export function useDatabaseValidation() {
                         ),
                       };
                     }
+                    if (extra.issue_codes?.length) {
+                      return {
+                        ...obj,
+                        error_type,
+                        description:
+                          message || extra?.issue_codes?.[0]?.message,

Review comment:
       we don't need conditional sign `?` here, because you already checked it in line# 751. 
   Just use `extra.issue_codes[0].message`
   
   Btw, are you sure that `issue_code` has always message?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org